Your message dated Mon, 02 Nov 2015 18:35:41 +0000
with message-id <[email protected]>
and subject line Bug#803687: fixed in haskell-devscripts 0.10.1
has caused the Debian Bug report #803687,
regarding haskell-devscripts: should refuse to create an empty documentation 
packages
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
803687: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=803687
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: haskell-devscripts
Version: 0.9.11
Tags: patch

Hi,

haskell-devscripts currently ignores errors when generating haddock
documentation. This seems like a mistake as it:

 a) Masks underlying problems in haddock and/or the build environment
 (eg. #738372)

 b) Results in empty -doc packages

Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
diff --git a/Dh_Haskell.sh b/Dh_Haskell.sh
index eba8c30..ca9be57 100644
--- a/Dh_Haskell.sh
+++ b/Dh_Haskell.sh
@@ -419,8 +419,11 @@ haddock_recipe(){
     # local PS5=$PS4; PS4=" + haddock_recipe> "; set -x
     hc=`packages_hc`
     haddock=`hc_haddock ${hc}`
-    [ ! -x /usr/bin/${haddock} ] || run ${DEB_SETUP_BIN_NAME} haddock 
--builddir=dist-${hc} --with-haddock=/usr/bin/${haddock} --with-ghc=${hc} 
${DEB_HADDOCK_OPTS} || \
-          echo "Haddock failed (no modules?), creating empty documentation 
package."
+    if [ -x /usr/bin/${haddock} ] && \
+          ! run ${DEB_SETUP_BIN_NAME} haddock --builddir=dist-${hc} 
--with-haddock=/usr/bin/${haddock} --with-ghc=${hc} ${DEB_HADDOCK_OPTS} ; then
+       echo "Haddock failed (no modules?), refusing to create empty 
documentation package."
+       exit 1
+    fi
     # PS4=$PS5
 }
 

--- End Message ---
--- Begin Message ---
Source: haskell-devscripts
Source-Version: 0.10.1

We believe that the bug you reported is fixed in the latest version of
haskell-devscripts, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joachim Breitner <[email protected]> (supplier of updated haskell-devscripts 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 02 Nov 2015 19:16:14 +0100
Source: haskell-devscripts
Binary: haskell-devscripts
Architecture: source all
Version: 0.10.1
Distribution: experimental
Urgency: medium
Maintainer: Debian Haskell Group 
<[email protected]>
Changed-By: Joachim Breitner <[email protected]>
Description:
 haskell-devscripts - Tools to help Debian developers build Haskell packages
Closes: 803684 803685 803687
Changes:
 haskell-devscripts (0.10.1) experimental; urgency=medium
 .
   * Don't print a warning if there are no -doc package Recommends
     (Closes: #803684), thanks to Chris Lamb for the patch.
   * Run haddock more verbosely. Closes: #803685. Thanks to Chris Lamb for the
     patch.
   * Abort if haddock fails. Closes: #803687. Thanks to – you guessed it –
     Chris Lamb for the patch.
   * Create a more valid C file as probe.c
Checksums-Sha1:
 22c11b2d6a66459a73c339a05e8c239a94806828 1812 haskell-devscripts_0.10.1.dsc
 a543cda4882e82dc491063c833a866ccdb7cae5d 29456 haskell-devscripts_0.10.1.tar.xz
 d3fb655a6fad527313268b9c855605b63d5988ca 36804 
haskell-devscripts_0.10.1_all.deb
Checksums-Sha256:
 5ee65d827a99355b428d1900c7a9f7d67921f5f1f3beb32560be0209ef252140 1812 
haskell-devscripts_0.10.1.dsc
 c17ef066e7152ff82cf1b3b530ec765ac716987cbb2aacc0afc7e079dac11504 29456 
haskell-devscripts_0.10.1.tar.xz
 848288215c117ea13debed41fa007a62a8e8378da004a251406d431ce37b1ccb 36804 
haskell-devscripts_0.10.1_all.deb
Files:
 5c5946069086ca5e2a84a479f7277ea0 1812 haskell extra 
haskell-devscripts_0.10.1.dsc
 be4501a7ed20a41ce725c5484dc0941d 29456 haskell extra 
haskell-devscripts_0.10.1.tar.xz
 c7847ed6ccbe2d8c9a9d600d83a26cff 36804 haskell extra 
haskell-devscripts_0.10.1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWN6omAAoJED2QirPw+/UfrhYP/j/AoHdPR/92/BvEjuKg4e14
fTvJSFhRLdUExgPutc0xR/02VNQ2gkRFtmbTbe8CE4/OA8GQJkXgDXvCR8CKh2eA
tszl124sHtKHzXtJ4pB+SgZ85xDZqIi/l2YDouLe2nUAlgGTJ+Ezs7A8KFbKsGUd
K611P+9G7YzOt5nanRxY/6ql6HqvZuhbjIahNp+TRFMOt7niXVqVIWHofQD7PxpN
g7jlpZpLf5QGVO33BLzbnKvsFBLA4ElmaMk6WSy69hAlyq/GxjJErnkRSYAFvAl3
pYSLG2JmiRBjUN4g1KzaJHQm0GoX5jQoH7IJf7sIS/6FuB5HA8UtgHV6WVwutwbj
92dGyztW1aoIN9DOn/b2y2zErLb15Qtpp0HU6kQZjRbqt/csU2seEKuFkRwY1CnV
ViSoQflgBntSRAwMR5eX89ipcg8BHrFrWCbe4jeabXPx9k1cDQrUnvTctZkrzIVp
PZjBPaNNj7tCja47L5zcI3iVAUIwC+szlK12sZ06eeKBV9Cq/Cz8b+We48+ADF6B
cWS++1UPganSo01QS9VkC8X7XnD+RqMshgQbWMAAA3rmPybeMQwSHmmOUgVJZuMO
92W3W/uv5dUptQ1WDHr/Mo+b77y+eqQmGUYbNHtQrEhSpi0/9WHa3KQUKEya+U3x
6J5bOo7RL3Vi5i18BSbL
=f81/
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to