Your message dated Fri, 13 Jan 2006 19:05:58 +0100
with message-id <[EMAIL PROTECTED]>
and subject line Bug#347305: planets: don't hardcode the ocaml version in the
package
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 9 Jan 2006 23:26:03 +0000
>From [EMAIL PROTECTED] Mon Jan 09 15:26:03 2006
Return-path: <[EMAIL PROTECTED]>
Received: from shiva.jussieu.fr ([134.157.0.129])
by spohr.debian.org with esmtp (Exim 4.50)
id 1Ew6Op-0007wG-8k
for [EMAIL PROTECTED]; Mon, 09 Jan 2006 15:26:03 -0800
Received: from liafa1.liafa.jussieu.fr (liafa1.liafa.jussieu.fr [132.227.93.1])
by shiva.jussieu.fr (8.13.5/jtpda-5.4) with ESMTP id k09NQ28W000548
for <[EMAIL PROTECTED]>; Tue, 10 Jan 2006 00:26:02 +0100 (CET)
X-Ids: 165
Received: from liafa0p.liafa.jussieu.fr (liafa0p.liafa.jussieu.fr
[132.227.81.252])
by liafa1.liafa.jussieu.fr (8.12.2/jtpda-5.3.2) with ESMTP id
k09NQ1uF016023
for <[EMAIL PROTECTED]>; Tue, 10 Jan 2006 00:26:01 +0100 (CET)
Received: from bryan.is-a-geek.org (morse.liafa.jussieu.fr [132.227.81.80])
by liafa0p.liafa.jussieu.fr (8.13.1/jtpda-5.4) with ESMTP id
k09NQ05Q028466
for <[EMAIL PROTECTED]>; Tue, 10 Jan 2006 00:26:00 +0100
Received: by bryan.is-a-geek.org (Postfix, from userid 1000)
id 80D3B9333F; Tue, 10 Jan 2006 00:26:03 +0100 (CET)
Date: Tue, 10 Jan 2006 00:26:02 +0100
From: Julien Cristau <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: planets: don't hardcode the ocaml version in the package
Message-ID: <[EMAIL PROTECTED]>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="HcAYCG3uE/tztfnV"
Content-Disposition: inline
X-Reportbug-Version: 3.18
X-Operating-System: Linux 2.6.13 i686
User-Agent: Mutt/1.5.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.7.2
(shiva.jussieu.fr [134.157.0.165]); Tue, 10 Jan 2006 00:26:02 +0100 (CET)
X-Antivirus: scanned by sophie at shiva.jussieu.fr
X-j-chkmail-Score: MSGID : 43C2F10A.001 on shiva.jussieu.fr : j-chkmail score :
X : 0/50 1
X-Miltered: at shiva.jussieu.fr with ID 43C2F10A.001 by Joe's j-chkmail
(http://j-chkmail.ensmp.fr)!
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
--HcAYCG3uE/tztfnV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: planets
Version: 0.1.12-5
Severity: wishlist
Tags: patch
Hi,
the attached patch makes planet determine the needed dependency on
ocaml-base at build time, instead of hardcoding it in the package.
This solution makes the package easier to rebuild (no source changes
needed) in case of an ocaml transition or as a backport.
Anyway, planets is uninstallable at the moment and needs a rebuild with
ocaml 3.09.1.
Cheers,
Julien Cristau
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/dash
Kernel: Linux 2.6.13
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
--HcAYCG3uE/tztfnV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="no_hardcoded_ocaml_depends.diff"
diff -u planets-0.1.12/debian/control planets-0.1.12/debian/control
--- planets-0.1.12/debian/control
+++ planets-0.1.12/debian/control
@@ -2,12 +2,12 @@
Section: science
Priority: extra
Maintainer: Martin Pitt <[EMAIL PROTECTED]>
-Build-Depends-Indep: debhelper (>> 4.0.0), ocaml-3.09.0, tk8.4-dev
+Build-Depends-Indep: debhelper (>> 4.0.0), ocaml, tk8.4-dev
Standards-Version: 3.6.1
Package: planets
Architecture: all
-Depends: tk8.4, ocaml-base-3.09.0
+Depends: tk8.4, ocaml-base-${OCamlABI}
Suggests: doc-base
Description: Gravitation simulation of planetary bodies
Planets is a simple interactive program for playing with simulations
diff -u planets-0.1.12/debian/rules planets-0.1.12/debian/rules
--- planets-0.1.12/debian/rules
+++ planets-0.1.12/debian/rules
@@ -7,6 +7,8 @@
MAKEOPTS:=DEBUGFLAGS=-g
endif
+OCAMLABI = $(shell ocamlc -version)
+
build:
dh_testdir
$(MAKE) $(MAKEOPTS) planets.bc
@@ -35,7 +37,7 @@
dh_compress
dh_fixperms
dh_installdeb
- dh_gencontrol
+ dh_gencontrol -- -VOCamlABI=$(OCAMLABI)
dh_md5sums
dh_builddeb
--HcAYCG3uE/tztfnV--
---------------------------------------
Received: (at 347305-done) by bugs.debian.org; 13 Jan 2006 18:06:29 +0000
>From [EMAIL PROTECTED] Fri Jan 13 10:06:29 2006
Return-path: <[EMAIL PROTECTED]>
Received: from box79162.elkhouse.de ([213.9.79.162])
by spohr.debian.org with esmtp (Exim 4.50)
id 1ExTJl-0001L7-1V
for [EMAIL PROTECTED]; Fri, 13 Jan 2006 10:06:29 -0800
Received: from localhost.localdomain (unknown [195.227.105.180])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client CN "Martin Pitt (workstation)", Issuer "piware CA" (verified
OK))
by box79162.elkhouse.de (Postfix) with ESMTP id F24B12E2C2
for <[EMAIL PROTECTED]>; Fri, 13 Jan 2006 19:05:53 +0100 (CET)
Received: by localhost.localdomain (Postfix, from userid 1000)
id 974EC42B7D; Fri, 13 Jan 2006 19:05:58 +0100 (CET)
Date: Fri, 13 Jan 2006 19:05:58 +0100
From: Martin Pitt <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: Re: Bug#347305: planets: don't hardcode the ocaml version in the
package
Message-ID: <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="Clx92ZfkiYIKRjnr"
Content-Disposition: inline
In-Reply-To: <[EMAIL PROTECTED]>
User-Agent: Mutt/1.5.11
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-2.9 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
RCVD_IN_SBLXBL,RCVD_IN_SBLXBL_CBL,RCVD_IN_SORBS,RCVD_IN_SORBS_WEB
autolearn=no version=2.60-bugs.debian.org_2005_01_02
--Clx92ZfkiYIKRjnr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Version: 0.1.12-6
Hi Julien!
Julien Cristau [2006-01-10 0:26 +0100]:
> the attached patch makes planet determine the needed dependency on
> ocaml-base at build time, instead of hardcoding it in the package.
> This solution makes the package easier to rebuild (no source changes
> needed) in case of an ocaml transition or as a backport.
>=20
> Anyway, planets is uninstallable at the moment and needs a rebuild with
> ocaml 3.09.1.
Thanks a lot for noticing and the bug. Unfortunately I forgot to close
the bug in the changelog, so let's do it manually.
planets (0.1.12-6) unstable; urgency=3Dlow
* debian/rules: Build-depend against unversioned ocaml.
* debian/rules, debian/control: Determine ocaml version at build time and
use a variable instead of hardcoding the ocaml version. Thanks to Julien
Cristau for the patch!
-- Martin Pitt <[EMAIL PROTECTED]> Fri, 13 Jan 2006 18:47:55 +0100
Thanks!
Martin
--=20
Martin Pitt http://www.piware.de
Ubuntu Developer http://www.ubuntu.com
Debian Developer http://www.debian.org
In a world without walls and fences, who needs Windows and Gates?
--Clx92ZfkiYIKRjnr
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDx+wGDecnbV4Fd/IRAt/yAJ4rCj7crrAj3rmrEyT8gupdZGzFlgCgizwY
r2Olc3imZlwxd+Hyzfdr0eY=
=hAi/
-----END PGP SIGNATURE-----
--Clx92ZfkiYIKRjnr--
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
