Bug#726511: marked as done (r-base: ARM regexp hack needs to be extended for arm64)

Fri, 13 Nov 2015 11:42:42 -0800 

Your message dated Fri, 13 Nov 2015 13:39:51 -0600
with message-id <[email protected]>
and subject line Re: Bug#726511: r-base: ARM regexp hack needs to be extended 
for arm64
has caused the Debian Bug report #726511,
regarding r-base: ARM regexp hack needs to be extended for arm64
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
726511: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726511
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message --- 
Package: r-base
Version: 3.0.1-3
Severity: important
Tags: patch
User: [email protected]
Usertags: arm64

The ARM regexp hack is apparently necessary for the forthcoming arm64
port as well (whose machine name is "aarch64").  I've attached a patch
that extends it to cover this new architecture; but perhaps this is
evidence that the hack should just cover all architectures to save this
kind of manual porting work?

  * Extend SHLIB_* definition hack in install.R to cover aarch64 as well.

diff -u r-base-3.0.1/debian/arm-perl-regexp.patch 
r-base-3.0.1/debian/arm-perl-regexp.patch
--- r-base-3.0.1/debian/arm-perl-regexp.patch
+++ r-base-3.0.1/debian/arm-perl-regexp.patch
@@ -5,7 +5,7 @@
          ## can we do better?
          mconf <- file.path(R.home(), paste0("etc", rarch), "Makeconf")
 -        sub(".*= ", "", grep("^SHLIB_EXT", readLines(mconf), value = TRUE))
-+        if (substr( Sys.info()["machine"], 1, 3) == "arm") {   # arm has 
broken regexps in libc
++        if (substr( Sys.info()["machine"], 1, 3) == "arm" || 
Sys.info()["machine"] == "aarch64") {   # arm has broken regexps in libc
 +            sub(".*= ", "", grep("^SHLIB_EXT", readLines(mconf), value = 
TRUE), perl = TRUE)
 +        } else {
 +            sub(".*= ", "", grep("^SHLIB_EXT", readLines(mconf), value = 
TRUE))
@@ -19,7 +19,7 @@
                                       "Makeconf"))
 -        SHLIB_EXT <- sub(".*= ", "", grep("^SHLIB_EXT", mconf, value = TRUE))
 -        SHLIB_LIBADD <- sub(".*= ", "", grep("^SHLIB_LIBADD", mconf, value = 
TRUE))
-+        if (substr( Sys.info()["machine"], 1, 3) == "arm") {   # arm has 
broken regexps in libc
++        if (substr( Sys.info()["machine"], 1, 3) == "arm" || 
Sys.info()["machine"] == "aarch64") {   # arm has broken regexps in libc
 +            SHLIB_EXT <- sub(".*= ", "", grep("^SHLIB_EXT", mconf, value = 
TRUE), perl = TRUE)
 +            SHLIB_LIBADD <- sub(".*= ", "", grep("^SHLIB_LIBADD", mconf, 
value = TRUE), perl = TRUE)
 +        } else {
diff -u r-base-3.0.1/src/library/tools/R/install.R 
r-base-3.0.1/src/library/tools/R/install.R
--- r-base-3.0.1/src/library/tools/R/install.R
+++ r-base-3.0.1/src/library/tools/R/install.R
@@ -108,7 +108,7 @@
     SHLIB_EXT <- if (WINDOWS) ".dll" else {
         ## can we do better?
         mconf <- file.path(R.home(), paste0("etc", rarch), "Makeconf")
-        if (substr( Sys.info()["machine"], 1, 3) == "arm") {   # arm has 
broken regexps in libc
+        if (substr( Sys.info()["machine"], 1, 3) == "arm" || 
Sys.info()["machine"] == "aarch64") {   # arm has broken regexps in libc
             sub(".*= ", "", grep("^SHLIB_EXT", readLines(mconf), value = 
TRUE), perl = TRUE)
         } else {
             sub(".*= ", "", grep("^SHLIB_EXT", readLines(mconf), value = TRUE))
@@ -1631,7 +1631,7 @@
         mconf <- readLines(file.path(R.home(),
                                      paste0("etc", Sys.getenv("R_ARCH")),
                                      "Makeconf"))
-        if (substr( Sys.info()["machine"], 1, 3) == "arm") {   # arm has 
broken regexps in libc
+        if (substr( Sys.info()["machine"], 1, 3) == "arm" || 
Sys.info()["machine"] == "aarch64") {   # arm has broken regexps in libc
             SHLIB_EXT <- sub(".*= ", "", grep("^SHLIB_EXT", mconf, value = 
TRUE), perl = TRUE)
             SHLIB_LIBADD <- sub(".*= ", "", grep("^SHLIB_LIBADD", mconf, value 
= TRUE), perl = TRUE)
         } else {

Thanks,

-- 
Colin Watson                                       [[email protected]]

--- End Message ---
--- Begin Message --- 
On 13 November 2015 at 17:24, Daniel Neis wrote:
| Hello,
| 
| the issue on the r-project bug tracker was closed as fixed and r-base
| is now available to apt-get install on aarch64 .
| With this, I think we can close this issue =)

Doing so by sending mail to the "-done" variant of the email address for this
bug report.

Thanks for keeping track!

Dirk
 
| Kind regards,
| Daniel

-- 
http://dirk.eddelbuettel.com | @eddelbuettel | [email protected]

--- End Message ---

Reply via email to