Your message dated Fri, 20 Nov 2015 23:46:31 +0000 with message-id <[email protected]> and subject line Re: Bug#714614: debhelper: A better way to check for make targets has caused the Debian Bug report #714614, regarding debhelper: A better way to check for make targets to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 714614: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=714614 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: debhelper Version: 9.20130630 Severity: normal Dear Maintainer, in light of recent make target detection code bugs #706923, #707481, #713257 I have yet another one. Using hello source package with following rules file & debian/compat 9: %: dh $@ override_dh_auto_test: mkdir -p test dh_auto_test Results in testsuite target "check" to not be executed. since `make -s -n test` exits with 0 "nothing to be done with test". But looking at bash-completion package it does manage to correctly detect that test target doesn't exist, yet check target does. Bash-completion executes this to find all make targets: make -qp | awk -F':' '/^[a-zA-Z0-9][^$#\/\t=]*:([^=]|$)/ \ {split($1,A,/ /);for(i in A)print A[i]}' Maybe something similar to above can be used to search for make targets in debhelper? Seems like a slightly more reliable way to do so. Regards, Dmitrijs.
--- End Message ---
--- Begin Message ---On Mon, 1 Jul 2013 11:40:56 -0400 Joey Hess <[email protected]> wrote: > Dmitrijs Ledkovs wrote: > > Results in testsuite target "check" to not be executed. since `make -s > > -n test` exits with 0 "nothing to be done with test". > > I cannot reproduce that: > > joey@gnu:~/tmp/hello-2.8>mkdir test > joey@gnu:~/tmp/hello-2.8>dh_auto_test -v > make -j1 check > > joey@gnu:~/tmp/hello-2.8>make -s -n test > joey@gnu:~/tmp/hello-2.8> > > When make outputs nothing, exists_make_target takes this to mean > that the target will not do anything, so does not run it. This causes > dh_auto_test to move on to trying the next target, check, which does > exist. > > > Bash-completion executes this to find all make targets: > > make -qp | awk -F':' '/^[a-zA-Z0-9][^$#\/\t=]*:([^=]|$)/ \ > > {split($1,A,/ /);for(i in A)print A[i]}' > > This is the method used by dh. It finds explict targets in the Makefile, > but will not find implicit targets. > > -- > see shy jo Hi, Given no follow up and us being unable to reproduce this bug, I have taken the liberty of closing it. Thanks, ~Niels
--- End Message ---
