Your message dated Tue, 24 Nov 2015 16:24:42 +0000
with message-id <[email protected]>
and subject line Bug#805552: fixed in pbuilder 0.221
has caused the Debian Bug report #805552,
regarding pbuilder: please do the umounts as a last action
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
805552: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805552
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pbuilder
Version: 0.220
Severity: minor
User: [email protected]
Usertag: pbuilder
X-Debbugs-CC: [email protected]
Control: submitter -1 [email protected]
Let me open another bug for this :)
----- Forwarded message from Yves-Alexis Perez <[email protected]> -----
Date: Thu, 19 Nov 2015 11:40:22 +0100
From: Yves-Alexis Perez <[email protected]>
To: [email protected], [email protected]
Subject: Bug#652527: Update on this
I tried to start using an I hook for the exact same reason (dpkg-
scanpackages), but my $BUILDRESULT is a specific folder in my homedir, which
is bind mounted by pbuilder.
Unfortunately, the bind-mounts are removed *before* I hooks are run, which
means I actually can't use it for that.
Is there a possibility to unmount stuff after that?
----- End forwarded message -----
I actually see no reason to umount stuff before the very end, and given
that this behaviour is not documented, so I'm tempted to change this.
Personally I'd also find it more clean/clear.
See the attached diff, would it solve the problem for you? Maybe you
can think of any downside?
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
diff --git a/pbuilder-buildpackage b/pbuilder-buildpackage
index 54cf13e..ccd7eb7 100755
--- a/pbuilder-buildpackage
+++ b/pbuilder-buildpackage
@@ -174,37 +174,38 @@ if ! wait "${BUILD_PID}"; then
eval "${KILL_WAIT_PID}"
log.e "Failed autobuilding of package"
executehooks "C"
exit 1;
else
eval ${KILL_WAIT_PID}
# build was successful
fi
-trap umountproc_cleanbuildplace_trap exit sighup sigpipe
executehooks "B"
-save_aptcache
-trap cleanbuildplace_trap exit sighup sigpipe
-umountproc
if [ -d "${BUILDRESULT}" ]; then
chown "${BUILDRESULTUID}:${BUILDRESULTGID}" "${BUILDPLACE}$BUILDDIR/"*
chgrp "${BUILDRESULTGID}" "${BUILDPLACE}$BUILDDIR/"*
for FILE in "${BUILDPLACE}$BUILDDIR"/*; do
if [ -f "${FILE}" ]; then
cp -p "${FILE}" "${BUILDRESULT}" || true
fi
done
for FILE in "${ADDITIONAL_BUILDRESULTS[@]}"; do
log.i "Trying to save additional result ${FILE}"
cp -a "${BUILDPLACE}$BUILDDIR/"*"/${FILE}" "${BUILDRESULT}" || true
done
executehooks "I"
else
log.e "BUILDRESULT=[$BUILDRESULT] is not a directory."
fi
+# final cleanup
+trap umountproc_cleanbuildplace_trap exit sighup sigpipe
+save_aptcache
+trap cleanbuildplace_trap exit sighup sigpipe
+umountproc
:
cleanbuildplace
trap - exit sighup sigpipe
echobacktime
exit 0
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: pbuilder
Source-Version: 0.221
We believe that the bug you reported is fixed in the latest version of
pbuilder, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mattia Rizzolo <[email protected]> (supplier of updated pbuilder package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 24 Nov 2015 14:04:30 +0000
Source: pbuilder
Binary: pbuilder pbuilder-uml
Architecture: source
Version: 0.221
Distribution: unstable
Urgency: medium
Maintainer: Debian pbuilder maintenance team
<[email protected]>
Changed-By: Mattia Rizzolo <[email protected]>
Description:
pbuilder - personal package builder for Debian packages
pbuilder-uml - user-mode-linux version of pbuilder
Closes: 490184 607607 608636 629947 683848 753944 804729 804905 805392 805552
Changes:
pbuilder (0.221) unstable; urgency=medium
.
[ Reiner Herrmann ]
* doc/Makefile: make the build reproducible by using a fixed temp dir to
build the pdf. Closes: #804729
.
[ Luca Falavigna ]
* add binNMU support. Closes: #683848
.
[ Andreas Beckmann ]
* add "binary-only=yes" mark to the binNMU changelog.
* only set Changed-By to --binnmu-maintainer in .changes do not override
Maintainer.
.
[ Mattia Rizzolo ]
* debian/control:
+ Add dependency on dpkg-dev >= 1.7.0 due to `dpkg-parsechangelog -S`
* {create,update}: consider APTGETOPT also when running apt-get update.
Closes: #608636
* make the output level configurable through LOGLEVEL (--loglevel)
valid values are D/I/W/E. Closes: #490184
* pbuilder:
+ add an (undocumented) --help operation. Exit 0 if the help was
requested.
+ clean: use `rm -f` when removing APTCACHE/*, so we don't fail when there
is nothing in it. Closes: #607607
+ update: correctly detect if debdelta is available. Closes: #805392
+ build: umount as the very last option, due keeping the bindmounts while
executing the hooks. Closes: #805552
* pdebuild:
+ make debsign work if only a source build was perfomed and only
_source.changes is available. Closes: #804905
Thanks to Marcin Kulisz <[email protected]> for the original patch.
* modules:
+ add 3 log.{i,w,e}() functions to be used instead of log().
- also use them instead of plain log() everywhere in the code.
+ mainly style improvments to binNMU().
+ short the --help output and point to the manual pages instead.
+ copy /etc/resolv.conf from the host only when USENETWORK=yes.
Closes: #753944
* checkparams:
+ override "experimental" DISTRIBUTION only in the create and update
target.
* docs:
+ add an empty POT file in the documentation directory, to ease the work of
translators. Closes: #629947
* t:
+ testlib: add a expect_stderr(), to explicitly test stderr.
+ pbuilder-modules: also test the expected stderr from log().
* debian/tests/build-procenv: use archive.ubuntu.com for amd64/i386 and
ports.ubuntu.com for everything else to fix autopkgtests on ubuntu.
Checksums-Sha1:
62a5aff97746252d7d653dfcbe3505fa89b5a976 1915 pbuilder_0.221.dsc
03855ecd2a5782b8abbc0bd627c383b8b7f5009f 306672 pbuilder_0.221.tar.xz
Checksums-Sha256:
5394b7f85463a9853ad9cad6e98af728a8b4caf867ec6fcdf2f84e20738beba8 1915
pbuilder_0.221.dsc
4a4a150bd5dd48e2d4f3cf0c9ac98754661c9069ebeeee9fa828722e782b8903 306672
pbuilder_0.221.tar.xz
Files:
13a84bab32662f398055ec9eb059e880 1915 devel extra pbuilder_0.221.dsc
9a9c114b5aa184bf0be1b88927702162 306672 devel extra pbuilder_0.221.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJWVG6kAAoJEEsEP825REVAVR0QAKN+EqLpkCWdtBlKAbBUjky3
MXJTiQLooxPuglGyEixJVMpldIDcRLj0htqjkqqJlJ82njo4ZjyBuHeVr3Zrfe/D
pUhsHpU1REe3zVWs9dtRtMjVVpkyCcDwZh+DQKKxdI2STHcM8ba01UY3TAKXelRL
7uLAQEBWOXPvl265EQECTHcNajyGEtzVoQtb5ZUTsYxhwRSLLD8IhZ9+wlwoAGDe
N8e3jARtLIySBAIEtGaC80PCvq89BGxRU8yfELwz6z1Feb/KD2PHBXuruNy3rFog
1UJ+ce6NNF2mnt3exqsqhiUwtE3et5tK5j+EdsZhJ3YX/flL2Nj05CvugUWv+M58
17Klgap+lOqBQoTzuPXMBpnRFL+7168acwoYpQCbkCR7q0tGpD0Um4AhOB3mgHmq
rFIjiIBLtDmQZOID0HJAteVIuB7jTd0+B7gONfwCSaLB5YjkI+UrcLA4i8FLICef
ocNEgu4agLe1BOzRSTK2WtvvEAHrRziwFZivoPaWowLwAvFXw9B35MvdaOQgIYaB
96r8YzbigNC/wPHuRwNc1wSumUGayET5gjsXCTfnqzsdwUFdg4i1tHN4jfKolhmZ
P8iL3bc+hnkgci62byTrERliZvIBQFS0xb7A/3z1nv/NxyetNdPeNnelKX8dKUCP
7YhY1vAdiNwpAx9GS8xb
=o9Sr
-----END PGP SIGNATURE-----
--- End Message ---
