Your message dated Thu, 26 Nov 2015 17:20:25 +0000
with message-id <[email protected]>
and subject line Bug#754226: fixed in holotz-castle 1.3.14-7
has caused the Debian Bug report #754226,
regarding FTBFS with clang instead of gcc
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
754226: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754226
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: holotz-castle
Severity: minor
Tags: patch
User: [email protected]
Usertags: clang-ftbfs
Hello,
Using the rebuild infrastructure, your package fails to build with clang
(instead of gcc).
We detected this kinf of error:
http://clang.debian.net/status.php?version=3.4.2&key=TAUTOLOGICAL-COMPARE
Full build log is available here:
http://clang.debian.net/logs/2014-06-16/holotz-castle_1.3.14-6_unstable_clang.log
Thanks,
Alexander
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- holotz-castle-1.3.14/src/HCed.cpp 2014-07-09 00:12:03.000000000 +0400
+++ holotz-castle-1.3.14-my/src/HCed.cpp 2014-07-09 00:08:22.610463365 +0400
@@ -49,7 +49,7 @@
void HCed::PrintUsage(char *program)
{
- fprintf(stderr, "HCed v1.3. (C) Juan Carlos Seijo Pérez - 2004.\n\n");
+ fprintf(stderr, "HCed v1.3. (C) Juan Carlos Seijo Perez - 2004.\n\n");
fprintf(stderr, "Usage: %s [-t themeName] [story name] [levelToLoad]", program);
fprintf(stderr, " [-h] [-r numRows] [-c numColumns]");
fprintf(stderr, " [-f]ullscreen [-w]indowed [--fps nnn] [-mWxHxBPP]\n");
--- holotz-castle-1.3.14/src/HolotzCastle.cpp 2014-07-09 00:12:03.000000000 +0400
+++ holotz-castle-1.3.14-my/src/HolotzCastle.cpp 2014-07-08 23:59:37.160061106 +0400
@@ -232,7 +232,7 @@
return false;
}
- if (!JApp::Init())
+ if (!JApp::Init(0, 0))
{
return false;
}
--- holotz-castle-1.3.14/JLib/JLib/Util/JApp.cpp 2009-05-02 13:17:15.000000000 +0400
+++ holotz-castle-1.3.14-my/JLib/JLib/Util/JApp.cpp 2014-07-09 00:06:38.996359392 +0400
@@ -57,7 +57,7 @@
}
// Inicializa la aplicación
-bool JApp::Init()
+bool JApp::Init(s32 argc, char **argv)
{
if (-1 == SDL_Init(SDL_INIT_EVERYTHING))
{
--- holotz-castle-1.3.14/JLib/JLib/Util/JApp.h 2009-05-02 13:17:15.000000000 +0400
+++ holotz-castle-1.3.14-my/JLib/JLib/Util/JApp.h 2014-07-09 00:04:41.322507594 +0400
@@ -175,7 +175,7 @@
* to do the SDL initialization stuff.
* @return <b>true</b> if the creation succeded <b>false</b> if not.
*/
- virtual bool Init();
+ virtual bool Init(s32 argc = 0, char **argv = 0);
/** Updates the application objects (graphics, sounds, A.I., etc.). Must be implemented in the child class.
* JApp will call this method before Draw in the child class (by means of MainLoop().
--- holotz-castle-1.3.14/src/HCPreferences.cpp 2009-05-02 13:17:15.000000000 +0400
+++ holotz-castle-1.3.14-my/src/HCPreferences.cpp 2014-07-08 23:53:41.678621912 +0400
@@ -219,7 +219,7 @@
}
// Saves the preferences
- if (0 > f.Printf("language=%d\nvideo=%d\nbpp=%d\nfullscreen=%d\naudio=%d\ndifficulty=%d", curLang, videoMode, bpp, fullscreen ? 1 : 0, sound ? 1 : 0, difficulty))
+ if (0 == f.Printf("language=%d\nvideo=%d\nbpp=%d\nfullscreen=%d\naudio=%d\ndifficulty=%d", curLang, videoMode, bpp, fullscreen ? 1 : 0, sound ? 1 : 0, difficulty))
{
// Incorrect file
return 2;
--- holotz-castle-1.3.14/src/HCObject.h 2009-05-02 13:17:15.000000000 +0400
+++ holotz-castle-1.3.14-my/src/HCObject.h 2014-07-08 23:51:46.376746784 +0400
@@ -118,7 +118,7 @@
/** Gets this object's position.
* @return Object's position.
*/
- virtual const JVector & Pos() {return pos;}
+ virtual const JVector & Pos() const {return pos;}
/** Returns the normal sprite.
* @return The normal sprite.
--- holotz-castle-1.3.14/JLib/JLib/Graphics/JSprite.h 2009-05-02 13:17:15.000000000 +0400
+++ holotz-castle-1.3.14-my/JLib/JLib/Graphics/JSprite.h 2014-07-08 23:49:21.619414398 +0400
@@ -143,7 +143,7 @@
*/
void CurFrame(const u32 newFrame)
{
- if (newFrame >= 0 && newFrame < numFrames) curFrame = newFrame;
+ if (newFrame < numFrames) curFrame = newFrame;
}
/** Devuelve el frame en la posición indicada.
--- holotz-castle-1.3.14/JLib/JLib/Util/JString.h 2009-05-02 13:17:15.000000000 +0400
+++ holotz-castle-1.3.14-my/JLib/JLib/Util/JString.h 2014-07-08 23:48:32.476319993 +0400
@@ -405,7 +405,7 @@
if (end == (u32)-1)
end = s.Length();
- if (start >= 0 && start < s.Length() && end > start && end <= s.Length())
+ if (start < s.Length() && end > start && end <= s.Length())
{
length = end - start;
data = new char[length + 1];
@@ -429,7 +429,7 @@
if (end == (u32)-1)
end = len;
- if (start >= 0 && start < len && end > start && end <= len)
+ if (start < len && end > start && end <= len)
{
length = end - start;
data = new char[length + 1];
--- End Message ---
--- Begin Message ---
Source: holotz-castle
Source-Version: 1.3.14-7
We believe that the bug you reported is fixed in the latest version of
holotz-castle, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Markus Koschany <[email protected]> (supplier of updated holotz-castle package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 26 Nov 2015 16:09:36 +0100
Source: holotz-castle
Binary: holotz-castle holotz-castle-data holotz-castle-editor
Architecture: source
Version: 1.3.14-7
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Markus Koschany <[email protected]>
Description:
holotz-castle - platform game with high doses of mystery
holotz-castle-data - platform game with high doses of mystery - data files
holotz-castle-editor - platform game with high doses of mystery - level editor
Closes: 754226
Changes:
holotz-castle (1.3.14-7) unstable; urgency=medium
.
* Team upload.
* Vcs-Browser: Use canonical Vcs-URI and https.
* wrap-and-sort -sa.
* Declare compliance with Debian Policy 3.9.6.
* Add keywords and a comment in German.
* Change homepage address to Debian Wiki because the original website is
gone.
* Update debian/copyright to copyright format 1.0. Add missing LGPL-2
licensed files.
* Add 15_clang-FTBFS.patch. Fix tautological comparison build failures
with the clang compiler. Thanks to Alexander for the report and patch.
(Closes: #754226)
* Add hardening.patch and pass all build flags to the build system.
* Remove Suggests: holotz-castle-milanb because this package does not exist
anymore. Milanb is already part of holotz-castle.
Checksums-Sha1:
043bb626fa57a10bfab0dfe6f61ae76e9f383caf 2417 holotz-castle_1.3.14-7.dsc
8d6cbdcd54f67e61dd916ec57545014b799a8f97 14588
holotz-castle_1.3.14-7.debian.tar.xz
Checksums-Sha256:
238c3ca8994a741f3ed1d17d6b66a50d171b2ee27fbb84f48404231f67cb3c3a 2417
holotz-castle_1.3.14-7.dsc
cfdfc48a6297413d3fc2cfaac8bf1a5dba3694144d54406f1bfcdec1aa5b1669 14588
holotz-castle_1.3.14-7.debian.tar.xz
Files:
c5f2c2daa6aeea4dccca2a9d79997abb 2417 games optional holotz-castle_1.3.14-7.dsc
b13d756613db064b09194eb92561dcaf 14588 games optional
holotz-castle_1.3.14-7.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJWVzSnXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBQ0YzRDA4OEVGMzJFREVGNkExQTgzNUZE
OUFEMTRCOTUxM0I1MUU0AAoJENmtFLlRO1Hk55wP/23lNYO0zO6DZ1pl2uOalITx
dNF1h2oEwt4MIw/66AmkikocjKZ/LkyOLz5BvHecSYOhn4AXegjByQyzpYGSwCNl
0hYh4/Zp9jGuFHGbPocZwwdIMWPus3+Ujxis5HpQ0nmjRf44rZXFduBiYlJRnNRh
9lDWBdgtEGE394PfeKCneRwwqVqpoByh4nWsIiL9orVilDmGCnZyHKBZdUvGKaC4
KkgynDNKT9T7liNXPTlJf51qa9gx2ZgGo1ziGAZbM2eUgqvI0j4bkGlWwPuKvoQz
LPlM9oG4uJNJKSc7TxWFaGHLLNI24KvgQHZF4Ce4CZNnlhx0u3n1uzRwtEMst97f
pdkmQWz7XxagFeF15u4lMc5VKC84iS8VOKKXFfQ5QFQ3aXOJizCxZvvlHOtvLRpi
xg9uRzO84DZBWpPQS/KNM/Vn6OYHTG0I7MvgVBm97gw6asvIv4pkcWazwCuTCpIO
z9BWujal38eUgINWg8CFyQ6uYD8+OAleqnuxV0236zqV0Bm30nGNtsu852CTB3vj
XtaiQ+7Bz3IQ6DEWV7/hNveKn1f0MbL9/ds7Db2FwvJX1GfIpGZYcBfVcPfqwSc8
OT1s59lc3Vvg4BDzYGaXRzqKWyTCfMcWxlXwww8vPAM2av8uENz0wqwGuPV4UxKV
Ip8H4Y1Trn5nk3rGmhtf
=L7/a
-----END PGP SIGNATURE-----
--- End Message ---
