Your message dated Fri, 04 Dec 2015 23:21:51 +0000 with message-id <[email protected]> and subject line Bug#806949: fixed in ifupdown 0.8.2 has caused the Debian Bug report #806949, regarding ifupdown: some tweaks to networking.service to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 806949: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806949 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: ifupdown Version: 0.8.1 Tags: patch Hello Guus, many thanks for adding a native networking.service! Michael and I found some corrections and tweaks to be made, and we would also like to remove the /lib/systemd/system/networking.service.d/systemd.conf drop-in. The attached patch to networking.service changes the following: - Drop Wants=network-pre.target. This is a passive target which should be pulled in by e. g. firewalls, not network management service. See man systemd.special(7). - Add Wants=network.target instead. It's passive target too, and as networking.service is a provider it needs to pull it in. - Add Before=network.target. This is important during shutdown to avoid stopping networking.service before any consumer of it (e. g. NFS, apache, etc.) -- otherwise shutting down these might hang due to cutting the network too early. The above are similar to systemd-networkd.service or NetworkManager.service. - Add After=local-fs.target. Depending on a read-only root partition might not be enough, as there might be actions in /e/n/i which require a writable root, or other mounted partitions. The current sysvinit file has "Required-Start: $local_fs" and we should probably keep that until we are really sure that we can drop it. - Add After=apparmor.service. Apparmor needs to run very early as it commonly installs profiles for network-facing software like dhcp-client. Note that this is a no-op when apparmor isn't being used, as there is no Wants= (i. e. just ordering, no dependency). - Drop systemd-udev-settle.service. Please let's not do this unconditionally. udev-settle is a really bad workaround for software which does not know about hotplugging, it's racy, might take a long time unnecessarily, and isn't required at all when one does not actually use ifupdown. The init.d script does this conditionally at least: if [ -n "$(ifquery --list --exclude=lo)" ] || [ -n "$(ifquery --list --allow=hotplug)" ]; then udevadm settle || true Although this looks overzealous to me -- I thought the intention was to make sure that all "static" interfaces are present before you start ifup'ing them, i. e. for the "auto" class. We specifically want "allow-hotplug" devices to *not* block the boot, only for the "auto" ones, no? So if you want to keep the current approach, I suggest adding this instead: ExecStartPre=-/bin/sh -c '[ -n "$(ifquery --list --exclude=lo)" ] && udevadm settle' (which is what the patch does ATM). In the medium term I'd be interested in cleaning this up, though. IMHO there needs to be a proper ifupdown-wait-online.service which just starts the virtual interfaces, let all the real ones be handleld by udev hotplug rules, and just waits until all "auto" services are up. This avoids the race condition and unnecessary blocking on udev settle. But this should be discussed in a separate bug, and I'll also send one for moving the "allow-hotplug" handling bits into ifupdown (where they fit much better than in the udev package). But the above just mimics what the sysvinit script does, so it's a good iteration. :-) Thanks for considering, Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)--- /lib/systemd/system/networking.service.orig 2015-12-03 12:12:15.299546792 +0100 +++ /lib/systemd/system/networking.service 2015-12-03 12:58:07.456211751 +0100 @@ -2,10 +2,9 @@ Description=Raise network interfaces Documentation=man:interfaces(5) DefaultDependencies=no -Wants=network-pre.target -Wants=systemd-udev-settle.service -After=network-pre.target systemd-udev-settle.service -Before=network-online.target shutdown.target +Wants=network.target +After=local-fs.target network-pre.target apparmor.service +Before=network.target shutdown.target Conflicts=shutdown.target [Install] @@ -14,6 +13,7 @@ [Service] Type=oneshot EnvironmentFile=-/etc/default/networking +ExecStartPre=-/bin/sh -c '[ -n "$(ifquery --list --exclude=lo)" ] && udevadm settle' ExecStart=/sbin/ifup -a --read-environment ExecStop=/sbin/ifdown -a --read-environment RemainAfterExit=true
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---Source: ifupdown Source-Version: 0.8.2 We believe that the bug you reported is fixed in the latest version of ifupdown, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Guus Sliepen <[email protected]> (supplier of updated ifupdown package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Fri, 04 Dec 2015 23:52:30 +0100 Source: ifupdown Binary: ifupdown Architecture: source amd64 Version: 0.8.2 Distribution: unstable Urgency: medium Maintainer: Guus Sliepen <[email protected]> Changed-By: Guus Sliepen <[email protected]> Description: ifupdown - high level tools to configure network interfaces Closes: 806949 806964 Changes: ifupdown (0.8.2) unstable; urgency=medium . [ Martin Pitt ] * Some tweaks to networking.service. Closes: #806949 . [ Guus Sliepen ] * Don't call udevadm settle if configuring interfaces is disabled or all auto interfaces are excluded. * Start ifupdown after sysctl.conf and modules have been loaded. * Don't use the -D LLT option for dhclient, some DHCP servers apparently don't like it. Closes: #806964 * Clarify configuration of dual-stack interfaces. Checksums-Sha1: d666e60130f01a1d8f0f64c229f958c4c5a45ada 1524 ifupdown_0.8.2.dsc e302f4a7172f3bb475f621e8070b123276882088 68676 ifupdown_0.8.2.tar.xz 3eb2ae4314f482ac668e10a83e6c0a37550f42bd 69852 ifupdown_0.8.2_amd64.deb Checksums-Sha256: 95731356a0ca8050504864b4d312723382665cc49dd4c220b779da08ca23c62b 1524 ifupdown_0.8.2.dsc edb08f935fea9bc376c3faa0140c04c7a4d4ef5f22fd280ec4060386a75df10b 68676 ifupdown_0.8.2.tar.xz 69de418aac4765e6a3f23e84b638a8bd91f0a9b3528f4e432d7db2dbf54a27e5 69852 ifupdown_0.8.2_amd64.deb Files: 3a1450b9b9104375b575ad355fd61d55 1524 admin important ifupdown_0.8.2.dsc 522bab06309e7eca3dc3280bf3cc54a2 68676 admin important ifupdown_0.8.2.tar.xz dfe6abc840bbbcf9d6583bc4a576a070 69852 admin important ifupdown_0.8.2_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJWYhlIAAoJED9JDeuHHvn6svwP/j9RwITZ4FnHu6ndEt7E8Z7p Q0HVZBJGkL69TZOx0/6NA6wOgVXOeY9EJzWcM3EXTvDI61wFCh0r+THnTYYCzM2W znKA0CD4YC9ARzsiO/aCWMiygK7H2y5MzlmtIyWL3EmqxMz8t/dV3klyvnTaQQhi 7C6GaZRzzeDvZaUoC2GzZ1yQZcOpet9g9rX+bg5dRYKa6iBBJ6Bo8v191Dq8OLp5 DAQGSjiX5whCxP3p986TxoBkrJIiFCxXp0VgyThYhv7ga63Kjt03Qd6nAkslkL0w cfxCWvyj7/sGqlSPPhFf0uWHkFteBWoD2/9Uvi1718MNR64q/AJuOvH8w1Lk1uCv tv1jWRP4QtnD7rKi/KfLEAAVEQkD/5ZzbyqNFNjzQ+tE05zDqHJXbmRfcilNjDFs UMmvssJJnLQnJ+DYsJ5L5WdyKRSg97Y5YCFtynyW5T7Pfbz+yD3k6tugPRgFBn0L UXrVgxr6X7Ja+yW2MW/AN+/TheNMHi7E6OtlCitWdnN1s45Z5adf+v1utZYCT91Y wgU+4abbCuNivh8SYMjQFZsh95QHa8J+FCwMxmrrWg2/iRjogsVUdn3yapZpjzln tFdq+kkKdLIc1UqQ6Na2Wr+cx1ughI1m7OWdfGDpo+TBymu5LPg+TRPutJ7lKUW1 Ek6Q7JrJXCQL+8BYhlFc =HYeq -----END PGP SIGNATURE-----
--- End Message ---
