Your message dated Thu, 21 Jan 2016 14:18:34 +0100
with message-id <[email protected]>
and subject line Re: Bug#740460: calypso: TypeError importing acl module
has caused the Debian Bug report #740460,
regarding calypso: TypeError importing acl module
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
740460: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740460
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: calypso
Version: 1.3
Severity: normal

With a fairly standard calypso config, I get a TypeError starting it:

% calypso
Traceback (most recent call last):
  File "/usr/bin/calypso", line 144, in <module>
    run_server()
  File "/usr/bin/calypso", line 137, in run_server
    (options.host, options.port), calypso.CollectionHTTPHandler)
  File "/usr/lib/python2.7/dist-packages/calypso/__init__.py", line 105, in 
__init__
    self.acl = acl.load()
  File "/usr/lib/python2.7/dist-packages/calypso/acl/__init__.py", line 34, in 
load
    module = __import__("calypso.acl", fromlist=[config.get("acl", "type")])
TypeError: Item in ``from list'' not a string

This is my config:

[server]
ssl=false

[acl]
type=htpasswd
filename=/home/jelmer/.config/calypso/passwd

The following patch seems to fix the issue:

diff --git a/calypso/acl/__init__.py b/calypso/acl/__init__.py
index c042dcf..9142433 100644
--- a/calypso/acl/__init__.py
+++ b/calypso/acl/__init__.py
@@ -31,5 +31,6 @@ from calypso import config
 
 def load():
     """Load list of available ACL managers."""
-    module = __import__("calypso.acl", fromlist=[config.get("acl", "type")])
-    return getattr(module, config.get("acl", "type"))
+    acl_type = config.get("acl", "type").encode("utf-8")
+    module = __import__("calypso.acl", fromlist=[acl_type])
+    return getattr(module, acl_type)

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.12-1-amd64 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages calypso depends on:
ii  git             1:1.9.0-1
ii  python          2.7.5-5
ii  python-daemon   1.5.5-1
ii  python-vobject  0.8.1c-4

calypso recommends no packages.

calypso suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message ---
Version: 1.4

This issue was fixed in version 1.4, but not closed because of a typo in the
changelog.

calypso (1.4) unstable; urgency=medium

  [ Keith Packard ]
  * Add quicker checks for calendar objects
  * Add --allow-empty to git commit command line
  * Split import of calendar with multiple vevents apart
  * Remove DURATION from events with both DTSTART and DURATION
  * Avoid trying to deep-copy the whole imported event

  [ Jelmer Vernooij ]
  * Ensure acl type loaded from config is a utf-8 string. Closes 740460.

-- 
Happy hacking
Petter Reinholdtsen

--- End Message ---

Reply via email to