Your message dated Thu, 21 Jan 2016 15:52:56 +0000
with message-id <[email protected]>
and subject line Bug#775972: fixed in libgnomeui 2.24.5-3.1
has caused the Debian Bug report #775972,
regarding src:libgnomeui: FTFBS on x32: -Werror printf warnings
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
775972: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775972
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:libgnomeui
Version: 2.24.5-3
Severity: normal
Tags: patch
Justification: fails to build from source (but built successfully in the past)
Hi!
I'm afraid that libgnomeui has regressed due to use of -Werror. It fails
to build on any architecture where time_t has a different size than long.
That's not the case on any of current Debian release arch, but, per Linus'
decree, applies to any new 32-bit arch (because Y2k38).
Sadly, this regression hasn't been noticed for a year, as -ports archs are
allowed to go out of sync from release ones, and any reverse-dependencies
built happily using 2.24.5-2 which used different build flags.
A readable patch attached. This one will fail in 23 years, but this code
needs to be rewritten for any arch other than x32 anyway. A proper patch
would use hairy casts as there's no standard printf format string for
time_t.
-- System Information:
Debian Release: 8.0
APT prefers unstable
APT policy: (600, 'unstable'), (500, 'unreleased'), (50, 'experimental')
Architecture: x32 (x86_64)
Kernel: Linux 3.18.2-x32 (SMP w/6 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
Description: cast time_t printfs
Upstream code uses printf("%ld") with a time_t argument. This causes a
warning if time_t is a different type than long, which causes a FTBFS
under -Werror.
Author: Adam Borowski <[email protected]>
--- libgnomeui-2.24.5.orig/libgnomeui/gnome-thumbnail.c
+++ libgnomeui-2.24.5/libgnomeui/gnome-thumbnail.c
@@ -863,7 +863,7 @@ gnome_thumbnail_factory_save_thumbnail (
}
close (tmp_fd);
- g_snprintf (mtime_str, 21, "%ld", original_mtime);
+ g_snprintf (mtime_str, 21, "%ld", (long)original_mtime);
width = gdk_pixbuf_get_option (thumbnail, "tEXt::Thumb::Image::Width");
height = gdk_pixbuf_get_option (thumbnail, "tEXt::Thumb::Image::Height");
@@ -970,7 +970,7 @@ gnome_thumbnail_factory_create_failed_th
}
close (tmp_fd);
- g_snprintf (mtime_str, 21, "%ld", mtime);
+ g_snprintf (mtime_str, 21, "%ld", (long)mtime);
pixbuf = gdk_pixbuf_new (GDK_COLORSPACE_RGB, TRUE, 8, 1, 1);
saved_ok = gdk_pixbuf_save (pixbuf,
tmp_path,
--- End Message ---
--- Begin Message ---
Source: libgnomeui
Source-Version: 2.24.5-3.1
We believe that the bug you reported is fixed in the latest version of
libgnomeui, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Adam Borowski <[email protected]> (supplier of updated libgnomeui package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 14 Jan 2016 07:19:13 +0100
Source: libgnomeui
Binary: libgnomeui-0 libgnomeui-0-dbg libgnomeui-dev libgnomeui-common
libgnomeui-doc
Architecture: source
Version: 2.24.5-3.1
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers
<[email protected]>
Changed-By: Adam Borowski <[email protected]>
Description:
libgnomeui-0 - GNOME user interface library - runtime files
libgnomeui-0-dbg - GNOME user interface library - debugging symbols
libgnomeui-common - GNOME user interface library - common files
libgnomeui-dev - GNOME user interface library - development files
libgnomeui-doc - GNOME user interface library - documentation files
Closes: 775972
Changes:
libgnomeui (2.24.5-3.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Fix FTFBS on x32. Closes: #775972.
Checksums-Sha1:
b8198e657f21ad5cfef71fecfe7ad5a8cf0dbd15 2320 libgnomeui_2.24.5-3.1.dsc
d00dbdceca093e03cdd7fb6e6529462153157ec3 9668
libgnomeui_2.24.5-3.1.debian.tar.xz
Checksums-Sha256:
619e8b8b45e05741037d7fed44588f292853ce53445082d66215c82cfa14e029 2320
libgnomeui_2.24.5-3.1.dsc
9059c7bbc60daca06bbc6b6b447e89a96f81151c3154f5722aa3db068d327f09 9668
libgnomeui_2.24.5-3.1.debian.tar.xz
Files:
79fc86f12da3f8a7aeb0e37f64307ac0 2320 oldlibs optional
libgnomeui_2.24.5-3.1.dsc
0983724b4e9cb26a5b25c16e016ab012 9668 oldlibs optional
libgnomeui_2.24.5-3.1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJWlz50AAoJECw7Q2/qxoEB7xAIAIBQnojHASrFW7hHGlJNg+C6
U55fNXRWUTsocXxnRbIrCSomZ02gUpjpgj+GNHTaK2GEQD4wsQqD3sGqes7pjA7T
4EwfxXLNHiV1U5EsQNMxrxteu1kVDbT0ZE6NpgGu/4z1N9mbCyxapmPARkBcQEjV
Yb0c0Ataf3Aqw3d3ZxcGVD/4zG06RpaKMAukmzQwz3wsYH7grOnpB5xB0xrqm+1H
4RAl0F1yjWs69ULT1FUbahL1AVMtuDpt+Ve2LPk8yp1IcNHHcSwAaev8an/JzQhM
4Xkcl3uaXnrf+TUUBDUb6kGL4rneS/Bs/Nmsnk7frMVGr26d77PKpOaEm2zazgE=
=fWhO
-----END PGP SIGNATURE-----
--- End Message ---
