Your message dated Fri, 29 Jan 2016 11:19:43 +0000
with message-id <[email protected]>
and subject line Bug#813072: fixed in virtualbox 5.0.14-dfsg-2
has caused the Debian Bug report #813072,
regarding Remove broken ExecStopPost in vboxweb.service
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
813072: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813072
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: virtualbox
Version: 5.0.14-dfsg-1+b1
Severity: important
File: /lib/systemd/system/vboxweb.service
Tags: patch

Hi,

vboxweb.service contains the following:
ExecStopPost=/usr/bin/rm /run/vboxweb.pid

This is broken in Debian:
$ type rm
rm is /bin/rm


And leads to a failure if you try to stop vboxweb.service:

# systemctl status vboxweb.service 
โ— vboxweb.service - VirtualBox Web Service
   Loaded: loaded (/lib/systemd/system/vboxweb.service; enabled; vendor preset: 
enabled)
   Active: failed (Result: exit-code) since Fr 2016-01-29 05:28:55 CET; 3s ago
  Process: 5499 ExecStopPost=/usr/bin/rm /run/vboxweb.pid (code=exited, 
status=203/EXEC)
  Process: 829 ExecStart=/usr/bin/vboxwebsrv --pidfile /run/vboxweb.pid 
--background (code=exited, status=0/SUCCESS)
 Main PID: 902 (code=killed, signal=TERM)
   CGroup: /system.slice/vboxweb.service
           โ””โ”€944 /usr/lib/virtualbox/VBoxSVC --auto-shutdown

Jan 29 04:09:03 pluto vboxwebsrv[829]: 00:00:00.002146 main     Executable: 
/usr/lib/virtualbox/vboxwebsrv
Jan 29 04:09:03 pluto vboxwebsrv[829]: 00:00:00.002147 main     Process ID: 829
Jan 29 04:09:03 pluto vboxwebsrv[829]: 00:00:00.002148 main     Package type: 
LINUX_64BITS_GENERIC (OSE)
Jan 29 04:09:03 pluto systemd[1]: Started VirtualBox Web Service.
Jan 29 05:28:55 pluto systemd[1]: Stopping VirtualBox Web Service...
Jan 29 05:28:55 pluto systemd[5499]: vboxweb.service: Failed at step EXEC 
spawning /usr/bin/rm: No such file or directory
Jan 29 05:28:55 pluto systemd[1]: vboxweb.service: Control process exited, 
code=exited status=203
Jan 29 05:28:55 pluto systemd[1]: Stopped VirtualBox Web Service.
Jan 29 05:28:55 pluto systemd[1]: vboxweb.service: Unit entered failed state.
Jan 29 05:28:55 pluto systemd[1]: vboxweb.service: Failed with result 
'exit-code'.


The fix is rather simple: Simply drop the ExecStopPost line.
As you can see in the documentation [ยน], systemd will automatically
clean up stale pid files, so there is no need to do that manually.

Trivial patch attached.

Btw, it would be great if /etc/init.d/virtualbox would have an
equivalent systemd service file. Most of the script seems to be about
loading kernel modules. Maybe that can be dropped completely due to
kernel auto-loading or could be replaced by a simple
/usr/lib/modules-load.d/ snippet.

Regards,
Michael


[1] 
http://www.freedesktop.org/software/systemd/man/systemd.service.html#PIDFile=


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages virtualbox depends on:
ii  adduser                               3.113+nmu3
ii  init-system-helpers                   1.27
ii  libc6                                 2.21-7
ii  libcurl3-gnutls                       7.47.0-1
ii  libgcc1                               1:5.3.1-7
ii  libgsoap7                             2.8.22-2
ii  libpng12-0                            1.2.54-1
ii  libpython2.7                          2.7.11-3
ii  libsdl1.2debian                       1.2.15-12
ii  libssl1.0.2                           1.0.2f-2
ii  libstdc++6                            5.3.1-7
ii  libvncserver1                         0.9.10+dfsg-3+b1
ii  libvpx3                               1.5.0-2
ii  libx11-6                              2:1.6.3-1
ii  libxcursor1                           1:1.1.14-1+b1
ii  libxext6                              2:1.3.3-1
ii  libxml2                               2.9.3+dfsg1-1
ii  libxmu6                               2:1.1.2-2
ii  libxt6                                1:1.1.5-1
ii  procps                                2:3.3.11-3
ii  python                                2.7.11-1
ii  python2.7                             2.7.11-3
pn  python:any                            <none>
ii  virtualbox-dkms [virtualbox-modules]  5.0.14-dfsg-1
ii  zlib1g                                1:1.2.8.dfsg-2+b1

Versions of packages virtualbox recommends:
ii  libgl1-mesa-glx [libgl1]  11.1.1-2
ii  libqt4-opengl             4:4.8.7+dfsg-5
ii  libqtcore4                4:4.8.7+dfsg-5
ii  libqtgui4                 4:4.8.7+dfsg-5
ii  virtualbox-qt             5.0.14-dfsg-1+b1

Versions of packages virtualbox suggests:
pn  vde2                            <none>
ii  virtualbox-guest-additions-iso  5.0.14-1

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: virtualbox
Source-Version: 5.0.14-dfsg-2

We believe that the bug you reported is fixed in the latest version of
virtualbox, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gianfranco Costamagna <[email protected]> (supplier of updated 
virtualbox package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 29 Jan 2016 12:01:48 +0100
Source: virtualbox
Binary: virtualbox-qt virtualbox virtualbox-dbg virtualbox-dkms 
virtualbox-source virtualbox-guest-dkms virtualbox-guest-source 
virtualbox-guest-x11 virtualbox-guest-utils
Architecture: source
Version: 5.0.14-dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Virtualbox Team 
<[email protected]>
Changed-By: Gianfranco Costamagna <[email protected]>
Description:
 virtualbox - x86 virtualization solution - base binaries
 virtualbox-dbg - x86 virtualization solution - debugging symbols
 virtualbox-dkms - x86 virtualization solution - kernel module sources for dkms
 virtualbox-guest-dkms - x86 virtualization solution - guest addition module 
source for dk
 virtualbox-guest-source - x86 virtualization solution - guest addition module 
source
 virtualbox-guest-utils - x86 virtualization solution - non-X11 guest utilities
 virtualbox-guest-x11 - x86 virtualization solution - X11 guest utilities
 virtualbox-qt - x86 virtualization solution - Qt based user interface
 virtualbox-source - x86 virtualization solution - kernel module source
Closes: 813072
Changes:
 virtualbox (5.0.14-dfsg-2) unstable; urgency=medium
 .
   [ Michael Biebl ]
   * debian/vboxweb.service: drop wrong/useless ExecStopPost
     keyword: (Closes: #813072)
Checksums-Sha1:
 3596b6f6e281408859df775268fe628048d93208 3700 virtualbox_5.0.14-dfsg-2.dsc
 71ddd9fb86f7ea653a99511014459da2c6ca98d2 77284 
virtualbox_5.0.14-dfsg-2.debian.tar.xz
Checksums-Sha256:
 12665f0a73887d66837c8e2f3388da73f97fdbe308f9f1fe36111eaf15d9f9ae 3700 
virtualbox_5.0.14-dfsg-2.dsc
 7c722fb52ba609cabefbe4eab1e408f47c8f11be07c86e569eeff7cff1af6446 77284 
virtualbox_5.0.14-dfsg-2.debian.tar.xz
Files:
 c6bc10aeafa0af16e1deaca8984a0827 3700 contrib/misc optional 
virtualbox_5.0.14-dfsg-2.dsc
 a13ab244e1b0edbe834dafeb022cdda9 77284 contrib/misc optional 
virtualbox_5.0.14-dfsg-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWq0b+AAoJEPNPCXROn13ZMUkQANkqNVra82xLfH6cUOvN6Mux
sImFANzZ9USGgReDyzoH2yVmxMBS3kbqcUNw8hmdYwj4LL7jEbTzFKlB2VpIMM+L
ofupFsVIJwi5pCBTVxBReeh8roiPOFiPshLt5J6tqZ1EyfnGAnq+GM9NUeUm6X6E
dC2Jl97P7TVcXuF+JpeGnojeYisotGT74MUzItyaNsRT6BpXdWMrK5ZT5blA70ic
tnQeI6Bd459zSc2o6Gvr85YqddQB/QSMn6Mr2vvshDmO0zdyhPbM5/QVbhV1ErM7
YSPRjR3whdCefDXwXHk0Kp7RoA5NkXI6TCZNg2wQQuzxFOqpoObsgHnR5fjQ5BH+
IDhnJx7UHmBwWIhINQOMXM2WlArirX2OWnCN6ygzt72lYQ/Qat/3SQ4+20hc7vwq
do1c718wJuH8YpJUlBil6QIOLQWD+BGLTszDwMVn1o0xRf+sGM/MK9zNm5sHqW4l
gkEBZIhPSTteixeMDm8W4EN65YHjpfmc4E775FW0flW1Izj93Y1rUPizBDWMIMEU
/G4UgeojoXkDi1a11Ml4uJLhnyeSxH/KUtkoqAfhx0ftNhRh57fdDnH0VAb1XKuJ
dY8SVSS726pMvFWgf/WGh2Iot02rNdr6t6GSxdCBzHOq0MPhGLA/O3fFH1Ck5ScH
mo/IP6lrk2elzGmVWlBL
=sKNx
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to