Your message dated Fri, 05 Feb 2016 11:49:33 +0000
with message-id <[email protected]>
and subject line Bug#747851: fixed in init-system-helpers 1.28
has caused the Debian Bug report #747851,
regarding invoke-rc.d: does not execute action if a package only has an upstart
job and a systemd unit
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
747851: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747851
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: sysv-rc
Version: 2.88dsf-55
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch utopic
Hello,
When running under systemd and a package only has an upstart job and a
systemd unit, the "testexec" in invoke-rc.d will be false and
is_upstart as well, thus the actions are never run in this case. This
causes invoke-rc.d to just exit with code 102 without actually doing
anything.
I realize that this is a corner case in Debian as packages are
required to have an init.d script; but it currently is quite common in
Ubuntu, so it would be nice if this could be fixed in Debian as well.
It's also quite an obvious omission from the "if" statement, as the
subsequent inner case distinction between the init systems includes
is_systemd as well.
Patch attached against current packaging git.
Thanks for considering,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
From 52fb58ef83a5fcdfc2d55af806a10bce9676b12e Mon Sep 17 00:00:00 2001
From: Martin Pitt <[email protected]>
Date: Mon, 12 May 2014 10:13:17 +0200
Subject: [PATCH] invoke-rc.d: Fix actions to run under systemd if there is no
init.d script
When running under systemd and a package only has an upstart job and a systemd
unit, the "testexec" will be false and is_upstart as well, thus the actions are
never run in this case. Add the missing "is_systemd" check for this.
---
debian/changelog | 4 ++++
debian/src/sysv-rc/sbin/invoke-rc.d | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/debian/changelog b/debian/changelog
index 0c52c10..9beb398 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -18,6 +18,10 @@ sysvinit (2.88dsf-56) UNRELEASED; urgency=medium
claim sysvinit have never been used on hurd. It is not true any
more.
+ [ Martin Pitt ]
+ * invoke-rc.d: Fix actions to run under systemd if there is no init.d
+ script.
+
-- Dimitri John Ledkov <[email protected]> Tue, 22 Apr 2014 14:41:18 +0100
sysvinit (2.88dsf-55) experimental; urgency=medium
diff --git a/debian/src/sysv-rc/sbin/invoke-rc.d b/debian/src/sysv-rc/sbin/invoke-rc.d
index cdfc8d8..2ce4abc 100644
--- a/debian/src/sysv-rc/sbin/invoke-rc.d
+++ b/debian/src/sysv-rc/sbin/invoke-rc.d
@@ -464,7 +464,7 @@ fi
## note that $ACTION is a space-separated list of actions
## to be attempted in order until one suceeds.
if test x${FORCE} != x || test ${RC} -eq 104 ; then
- if [ -n "$is_upstart" ] || testexec "${INITDPREFIX}${INITSCRIPTID}" ; then
+ if [ -n "$is_upstart" ] || [ -n "$is_systemd" ] || testexec "${INITDPREFIX}${INITSCRIPTID}" ; then
RC=102
setechoactions ${ACTION}
while test ! -z "${ACTION}" ; do
--
2.0.0.rc0
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: init-system-helpers
Source-Version: 1.28
We believe that the bug you reported is fixed in the latest version of
init-system-helpers, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Martin Pitt <[email protected]> (supplier of updated init-system-helpers package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 05 Feb 2016 12:30:53 +0100
Source: init-system-helpers
Binary: init-system-helpers dh-systemd init
Architecture: source all amd64
Version: 1.28
Distribution: unstable
Urgency: medium
Maintainer: pkg-systemd-maintainers
<[email protected]>
Changed-By: Martin Pitt <[email protected]>
Description:
dh-systemd - debhelper add-on to handle systemd unit files
init - System-V-like init utilities - metapackage
init-system-helpers - helper tools for all init systems
Closes: 717109 747851 760168 768450
Changes:
init-system-helpers (1.28) unstable; urgency=medium
.
[ Martin Pitt ]
* invoke-rc.d: Fix actions to run under systemd if there is no init.d
script. (Closes: #747851)
* invoke-rc.d: Don't start systemd units which are disabled. Restart them
only if they were already running (i. e. started manually by the admin).
(Closes: #768450)
* update-rc.d: Support /usr/lib/insserv/insserv location too, as with
newer sysvinit versions.
* Add autopkgtest which runs the tests in t/.
* Drop Michael Stapelberg and Tollef Fog Heen from Uploaders:, they stopped
systemd work long ago. Thanks for your great work in the past!
* Run wrap-and-sort -at over our debian control files.
.
[ Andreas Henriksson ]
* Add support for -X option. (Closes: #760168)
.
[ Michael Biebl ]
* invoke-rc.d: Allow stop and status requests for masked systemd services.
(Closes: #717109)
Checksums-Sha1:
19bc65676c3f27d22851a0642d34b79c10427146 1876 init-system-helpers_1.28.dsc
8c47dad657808696688fd24d1de0c425581089c4 54624 init-system-helpers_1.28.tar.xz
7ee558cb0bf94a29f901016e76fed4e39591d29e 19752 dh-systemd_1.28_all.deb
f39e0e464f782f3a7729ee22a50f9c87565d98ef 32632 init-system-helpers_1.28_all.deb
9bc360a2db852820bb26bef0e8501a876cee9125 6398 init_1.28_amd64.deb
Checksums-Sha256:
0350b5c294a445c8fc5860ad799d4be4fad584952aa2786e782beaf738cbd52e 1876
init-system-helpers_1.28.dsc
476d83a998a9e19d2b05d17341ae1cbfd6d9b7af8bfbaf1b941499ff6f7d4e2b 54624
init-system-helpers_1.28.tar.xz
7a7662ffc7394817c416210ca51fa3b5881e24fe1a628607adba97da526d1c17 19752
dh-systemd_1.28_all.deb
33f8dd17a53330f71ed41bc179314018eaea073670a06239cb4be67f1115398c 32632
init-system-helpers_1.28_all.deb
4440929b5aee71c14f8891d7f8045d2414be001ab41267e7922675735fc4829e 6398
init_1.28_amd64.deb
Files:
51f78d6d3fb2cc2b27815e688ffb56e1 1876 admin extra init-system-helpers_1.28.dsc
b5d38db797bb673c6e196d3c416134c6 54624 admin extra
init-system-helpers_1.28.tar.xz
ff5aa34d2eb749b603e1ed5cb1cbfaa6 19752 admin extra dh-systemd_1.28_all.deb
9116fdccca5e2f3f4607bf758022babf 32632 admin required
init-system-helpers_1.28_all.deb
c1809d59bc9c339134e4a53b714dff3f 6398 metapackages required init_1.28_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJWtIkgAAoJENFO8V2v4RNHYvcP/1cW07jze8B9WY7BEL3MNfvd
hCk7nzXFBfEdCUplN3FHJnK0hjlqutpFInlebJUuwBATDCoScVRuSP/E573pu+i3
4CGlA8iwXu3HJqO8ZaYPtYnfnzIpX05ZVPqjDyv7i1p29/1LxtMJSNjrbd40NmPO
WI6N1qtFrlvklPWgIFIyIycdjaJi2eSVmb/MFJaRe1vllaYN2+aJR5PbITkj/KIL
RNfBskxFUsKMXDx5iSsdq7OCnXupXZ44pvndb+3PYhJVJFwwv6cp8BhB1g+5w234
X6DRhpyfObu3a7/XNdxcbSF3+zIaWorDye5aLNLzI0wZ04T3Xvz0Op+Vh+uTZEH8
tsu/QlmDy1LLFd5p3JWqbSos537QCKRigv1WRSNWP1SLtaqj869rGjOQztLWT3/e
nzegYUn879nMgHiDPjgK3bQjzpZKpxYe8tkPB3VKLB6EmYSyUENuptgX0lunzymE
/0VdXpxryafoBZ/Jv11J+Yqi69624Q3IsLL83CrkXdD4JjQrsssgsubfXy3Ioog4
aGji/QJmdyw+E7vwDtUyz6y+KrAuDxGQySBS3kl0ttdbCUwdm/LRoszBvrpdyDIc
MNF8z/kGBAkwn3jSSCFqDo3u0o+bta/B/PEXJCXZpbXEzakOjIFQww4cRJ110dLJ
3x4Pwk/sz7mspeuoJIQI
=vJcN
-----END PGP SIGNATURE-----
--- End Message ---
