Your message dated Wed, 10 Feb 2016 16:32:12 +0000
with message-id <[email protected]>
and subject line Bug#814076: fixed in parted 3.2-15
has caused the Debian Bug report #814076,
regarding parted crashes on lvm, on a dasd drive
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
814076: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=814076
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: parted
Version: 3.2
Severity: normal
Tags: patch upstream
Dear Maintainer,
Running parted <logical volume name> print against a logical volume
residing on a DASD will result in a core dump, caused by divide by zero.
See also https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1541510
and
http://lists.alioth.debian.org/pipermail/parted-devel/2016-February/004790.html.
The attached patch provides a solution for the problem.
Thanks!
>From c351c57bb440d7b56830832a255b62d89804ea3d Mon Sep 17 00:00:00 2001
From: Viktor Mihajlovski <[email protected]>
Date: Thu, 4 Feb 2016 16:47:21 +0100
Subject: [PATCH] fdasd.c: Safeguard against geometry misprobing
Fixes an issue with parted print being run against a logical
volume realised by extents on a physical volume residing on
a DASD.
We must make sure that geometry, device blocksize and DASD
attributes are present before we start format verifications
If any of it is missing this is not a DASD.
Signed-off-by: Viktor Mihajlovski <[email protected]>
---
libparted/labels/fdasd.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/libparted/labels/fdasd.c b/libparted/labels/fdasd.c
index 7e6a77a..968b332 100644
--- a/libparted/labels/fdasd.c
+++ b/libparted/labels/fdasd.c
@@ -1021,13 +1021,20 @@ fdasd_get_geometry (const PedDevice *dev, fdasd_anchor_t *anc, int f)
goto error;
}
- if (ioctl(f, HDIO_GETGEO, &anc->geo) != 0)
+ if (ioctl(f, HDIO_GETGEO, &anc->geo) != 0 ||
+ anc->geo.heads == 0 ||
+ anc->geo.sectors == 0 ||
+ anc->geo.cylinders == 0 ) {
fdasd_error(anc, unable_to_ioctl,
_("Could not retrieve disk geometry information."));
+ goto error;
+ }
- if (ioctl(f, BLKSSZGET, &blksize) != 0)
+ if (ioctl(f, BLKSSZGET, &blksize) != 0) {
fdasd_error(anc, unable_to_ioctl,
_("Could not retrieve blocksize information."));
+ goto error;
+ }
/* get disk type */
if (ioctl(f, BIODASDINFO, &dasd_info) != 0) {
--
1.9.1
--- End Message ---
--- Begin Message ---
Source: parted
Source-Version: 3.2-15
We believe that the bug you reported is fixed in the latest version of
parted, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Colin Watson <[email protected]> (supplier of updated parted package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 10 Feb 2016 14:26:23 +0000
Source: parted
Binary: parted parted-udeb libparted2 libparted-fs-resize0 libparted2-udeb
libparted-fs-resize0-udeb libparted-i18n libparted-dev libparted0-dev parted-doc
Architecture: source
Version: 3.2-15
Distribution: unstable
Urgency: medium
Maintainer: Parted Maintainer Team <[email protected]>
Changed-By: Colin Watson <[email protected]>
Description:
libparted-dev - disk partition manipulator - development files
libparted-fs-resize0 - disk partition manipulator - shared FS resizing library
libparted-fs-resize0-udeb - disk partition manipulator - FS resizing library
udeb (udeb)
libparted-i18n - disk partition manipulator - i18n support
libparted0-dev - disk partition manipulator - transitional package
libparted2 - disk partition manipulator - shared library
libparted2-udeb - disk partition manipulator - library udeb (udeb)
parted - disk partition manipulator
parted-doc - disk partition manipulator - documentation
parted-udeb - Manually partition a hard drive (parted) (udeb)
Closes: 814076
Changes:
parted (3.2-15) unstable; urgency=medium
.
* Cherry-pick upstream patch to check DASD geometry more carefully to
avoid problems with LVM (closes: #814076, LP: #1541510).
Checksums-Sha1:
7e4971113d866ae1793a93397e67c02091c91efe 2950 parted_3.2-15.dsc
c63ecbe8b85ea8bfab649c9a017b4eef5046e589 69260 parted_3.2-15.debian.tar.xz
Checksums-Sha256:
4ca51fa072fe22a83f0e9666b203d8d8641065cd2921e0a0031689c9f17ba9fe 2950
parted_3.2-15.dsc
c72356eedf93afb191581b447f4b973b05aa12ce758e2827cb912ad144eae352 69260
parted_3.2-15.debian.tar.xz
Files:
63d45622d5bf08b66cf16a504418b016 2950 admin optional parted_3.2-15.dsc
de9d7fbb03da2cfe608bb4d44c45f25a 69260 admin optional
parted_3.2-15.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Colin Watson <[email protected]> -- Debian developer
iQIVAwUBVrtIpDk1h9l9hlALAQheEg//efuQHlpc91A7exUp9t+gRKt7tvgAYrtF
20sL0WmD+BsevKTFloSV0t7suzRiMB1jh3o95e7TAoFdMPGjq4n2lEYa1s6dKsfz
D1xhoGQhAnuWljAY4oj0NtJbYE+j1Y8yWqVb0oWxr+Ute6+8sYeDvblPtPjVZ8YK
A4ZliUbNAmpdfcNvZSAnejAC3hnVetX5kuobqzqhORFKUyHhuQuS/lfQ6snNt8TL
gMO7XA6av7fP9kpzqIoxuClI/jUPgG01EPHfTNPOy5szem1zOrVqW+CV+HaDpPDG
i+17Bk0zWR9D6YntmfWA4zmAXxDO0Nzv597yh1A78cDQOxZZy43luivjIk2uJpir
Qjv8ipsG/QvFrzTZ4VdNaSyjArpFdlhyZAmoKpzjJq6Ntnmt5O6+xqTWIbmbw2YU
MkXfwd2cTyImbGgJvsKzisoT/WJ2J//LwDikFeJ05+mOlnfWqA5cAPG6EcGZXmtj
0xq/pbMohSxJlbZiYPQLsASe7cnnJX2VGK4Kobp5mY8IIize+z9sgn9QehGJ0XAc
vLbOTCjUT7nUaszxYJiVy674cpTP9GDOqeH6nfxhLOppoxoylbcyIJxpzsVKFipf
Jv7yQWfUYPOEgvGxljH7sKw4cfvlVUYB0Q3HMBlu6Zcenx3ov46jQneh8ru8KQie
ZGbZWE788BI=
=Ok6x
-----END PGP SIGNATURE-----
--- End Message ---
