Your message dated Sun, 14 Feb 2016 16:46:57 +0100
with message-id <[email protected]>
and subject line Re: crmsh does not respect EDITOR and/or PAGER
has caused the Debian Bug report #749370,
regarding crmsh does not respect EDITOR and/or PAGER
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
749370: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749370
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: crmsh
Version: 1.2.6+git+e77add-1.2
Severity: normal
Tags: patch
Dear Maintainer,
crmsh does not respect EDITOR and/or PAGER, for example when doing
# crm configure edit
This always opens vi/vim instead of the chosen EDITOR environment
variable. (Unless vi/vim is not installed, then it might fall back to
either emacs or nano.)
This is a regression compared to the 'crm' command that was part of the
pacemaker package in Wheezy.
Changing this manually in the installed .py file makes crmsh properly
respect those environment variables.
I've attached a patch that fixes this. (See the opt_program class at
the beginning of the file as to why the $ sign has to be removed.)
Versions of packages crmsh depends on:
ii python 2.7.3-4+deb7u1
ii python-lxml 2.3.2-1
ii python-support 1.0.15
ii python-yaml 3.10-4
Versions of packages crmsh recommends:
ii pacemaker 1.1.11-1
Description: Respect EDITOR and PAGER environment variables
Make crmsh properly respect EDITOR and PAGER environment variables,
which did not work properly before.
Author: Christian Seiler <[email protected]>
Last-Update: 2014-05-26 18:04:00+0200
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
Index: crmsh-1.2.6+git+e77add/modules/config.py
===================================================================
--- crmsh-1.2.6+git+e77add.orig/modules/config.py 2014-02-19
10:54:43.000000000 +0100
+++ crmsh-1.2.6+git+e77add/modules/config.py 2014-05-26 18:01:05.432753048
+0200
@@ -166,8 +166,8 @@
DEFAULTS = {
'core': {
- 'editor': opt_program('$EDITOR', ('vim', 'vi', 'emacs', 'nano')),
- 'pager': opt_program('$PAGER', ('less', 'more', 'pg')),
+ 'editor': opt_program('EDITOR', ('vim', 'vi', 'emacs', 'nano')),
+ 'pager': opt_program('PAGER', ('less', 'more', 'pg')),
'user': opt_string(''),
'skill_level': opt_choice('expert', ('operator', 'administrator',
'expert')),
'sort_elements': opt_boolean('yes'),
--- End Message ---
--- Begin Message ---
Version: 2.2.0-1
On Thu, Jul 17, 2014 at 05:14:51PM +0200, Christian Seiler wrote:
> Control: tags -1 fixed-upstream
>
> FYI: This bug was just fixed upstream:
> https://github.com/crmsh/crmsh/commit/b5962a2bb1d98d53ed559cb27be17e2041bab68c
The fix is included in debian version 2.2.0-1.
Regards,
- Adrian
--- End Message ---
