Your message dated Mon, 15 Feb 2016 18:49:42 +0000
with message-id <[email protected]>
and subject line Bug#814713: fixed in gitlab 8.4.3+dfsg-7
has caused the Debian Bug report #814713,
regarding gitlab failes to start under systemd with: Dependency failed for 
GitLab Service.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
814713: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=814713
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gitlab
Version: 8.4.3+dfsg-6
Severity: important

Hi,

after upgrading to the latest gitlab version, gitlab.target fails to
load:

root@22gitlab:~# systemctl status gitlab.target          
● gitlab.target - GitLab Service
   Loaded: loaded (/lib/systemd/system/gitlab.target; enabled)
   Active: inactive (dead)

Feb 14 15:04:21 22gitlab systemd[1]: Dependency failed for GitLab Service.
root@22gitlab:~# journalctl -xn
-- Logs begin at Sun 2016-02-14 15:04:16 CET, end at Sun 2016-02-14 15:06:14 
CET. --
Feb 14 15:06:13 22gitlab gitlab-unicorn[224]: from 
/usr/lib/ruby/vendor_ruby/unicorn/http_server.rb:100:in `initialize'
Feb 14 15:06:13 22gitlab gitlab-unicorn[224]: from 
/usr/bin/unicorn_rails:209:in `new'
Feb 14 15:06:13 22gitlab gitlab-unicorn[224]: from 
/usr/bin/unicorn_rails:209:in `<main>'
Feb 14 15:06:13 22gitlab gitlab-unicorn[224]: master failed to start, check 
stderr log for details
Feb 14 15:06:13 22gitlab systemd[1]: gitlab-unicorn.service: main process 
exited, code=exited, status=1/FAILURE
Feb 14 15:06:13 22gitlab gitlab-unicorn[264]: cat: 
/var/run/gitlab/pids/unicorn.pid: No such file or directory
Feb 14 15:06:13 22gitlab gitlab-unicorn[264]: Could not find a PID in 
/var/run/gitlab/pids/unicorn.pid
Feb 14 15:06:13 22gitlab systemd[1]: gitlab-unicorn.service: control process 
exited, code=exited status=1
Feb 14 15:06:13 22gitlab systemd[1]: Unit gitlab-unicorn.service entered failed 
state.
Feb 14 15:06:14 22gitlab systemd[1]: Started GitLab Sidekiq Worker.
-- Subject: Unit gitlab-sidekiq.service has finished start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
-- 
-- Unit gitlab-sidekiq.service has finished starting up.
-- 
-- The start-up result is done.


The error message seems to indicate that it cannot find
/var/run/gitlab/pids/unicorn.pid which indeed doesn't exist on my
system. In fact, /var/run/gitlab/pids/ doesn't exist either. And neither
does /var/run/gitlab/.

As an attempt to fix the problem, I manually did:

$ mkdir -p /var/run/gitlab/pids/
$ mkdir -p /var/run/gitlab/sockets
$ chown -R gitlab:gitlab /var/run/gitlab

And now gitlab.target succeeds to load. Did you forget to create these
directories?

On the other hand, when I look at your postinst, I see that you have:

    su ${gitlab_user} -s /bin/sh -c "mkdir -p ${gitlab_pid_path}/pids"
    su ${gitlab_user} -s /bin/sh -c "mkdir -p ${gitlab_pid_path}/sockets"

which seems to be unconditionally executed. Here is the relevant snippet
from the postinst output when I used apt to upgrade to the latest
version:

Creating/updating gitlab user account...
adduser: The user `gitlab' already exists.
Proceeding with existing gitlab user...
Create database if not present

Since the mkdir command comes between the "adduser" and "create
database" part and since there seem to have been no error messages, I'm
at a loss about what went wrong.

Any ideas?

Could it be that somehow ${gitlab_pid_path} was still
/usr/share/gitlab/tmp/ and not /var/run/gitlab/ and thus the two mkdir
lines above succeeded?

Thanks!

cheers, josch

--- End Message ---
--- Begin Message ---
Source: gitlab
Source-Version: 8.4.3+dfsg-7

We believe that the bug you reported is fixed in the latest version of
gitlab, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pirate Praveen <[email protected]> (supplier of updated gitlab package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 16 Feb 2016 00:08:18 +0530
Source: gitlab
Binary: gitlab
Architecture: source all
Version: 8.4.3+dfsg-7
Distribution: unstable
Urgency: medium
Maintainer: Debian Ruby Extras Maintainers 
<[email protected]>
Changed-By: Pirate Praveen <[email protected]>
Description:
 gitlab     - git powered software platform to collaborate on code
Closes: 814695 814713 814714
Changes:
 gitlab (8.4.3+dfsg-7) unstable; urgency=medium
 .
   * bc should be in build-dep (Closes: #814695)
   * fix pid file mismatch between /etc/default/gitlab and systemd service files
     (Closes: #814714)
   * use tmpfiles.d for /run/gitlab (Closes: #814713) Thanks to Christian Seiler
Checksums-Sha1:
 24317248eadecb17cf19d05dcfefc397634e2837 2066 gitlab_8.4.3+dfsg-7.dsc
 8922bdb0b01e45a7c9b311029889e7a1f75f6c73 32592 
gitlab_8.4.3+dfsg-7.debian.tar.xz
 104a2b699cb831411b02013cd3b061635378706b 11517398 gitlab_8.4.3+dfsg-7_all.deb
Checksums-Sha256:
 b425398ba7b79002576ffa3106ae25794a4ce465e892b4da317c54d5e9fe06bb 2066 
gitlab_8.4.3+dfsg-7.dsc
 ca383259bdaaf7430eb64bfe55541431b5ff12bdfbbe67bdf2eb9cc3901664ce 32592 
gitlab_8.4.3+dfsg-7.debian.tar.xz
 35122341ba41b20b3aef0ac32f2494dcff4351fe22d7890242d94fca9fd55e6b 11517398 
gitlab_8.4.3+dfsg-7_all.deb
Files:
 748438e7f884c2a3376554389cc6bf53 2066 ruby optional gitlab_8.4.3+dfsg-7.dsc
 c70f94dfd9da19ff5b49585240cb3dd3 32592 ruby optional 
gitlab_8.4.3+dfsg-7.debian.tar.xz
 5eae4663073dcdc1046b12a184893ccd 11517398 ruby optional 
gitlab_8.4.3+dfsg-7_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWwhvdAAoJEM4fnGdFEsIqHhsP/iRWPlplTbOq7akQrD9UuxF9
qfilFY7IIKlOFxz6ktXIeWDUr9jYMoRdLPKqesNAB0GSSrQe/MnRTJ3acN6Fmptq
tkmAXqPz1yoQ6bgJ1o9PW8VRu3GadwW8/i1Rsj7vYbLDQFQfsYS47ivB8QLsC+FO
kI5gIoRi5M/VOSYnogHR0xS+vAwYvRS6SfpmqYSAhMbHzxNt61jfQY3xmoQ7O9CJ
Pm1TxHz4T3YggkDkF2wr0l3xmf+fb2OD3X6EVIpphkTgWtRId9oZJXEg3r9mRyPz
xnLegbnoW1rnbq6Puo7qD91+iV937wn3jz7xqVxDIq/ioLrQ7E/UEOPk2MOvHRp8
gSXlbr8Eg2XT4WA29sJykxfsdFYKmnyKQDOqZWOE3F1fvOCCU8BbS5+wz+sj8kf5
wBlK1o6fvoOu1Zd5lYy5COXtMX1PnyVT2FPFHf1m6xZsepcZrrzbDVHmIsACTdbQ
GWh6uqUXkCsOBnq02cda0AWcbLhaEVdIqX16JlVhgVclMb194mlXZgitaBHX4yz9
AdyHlVxFQ/rpLcRT5JpvlaNcEqsnvAqL4z9vAXV+JFIYfPUzen9RU38rr3UFvZQb
A60TsOWhvyeNMF21yiPUvC535GfCBc8gkXFF1GclN/H0G/DKM2/qhByXJhJZyqkl
GorJu+to7QEeURZyZO51
=wvaY
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to