Your message dated Mon, 07 Mar 2016 18:49:40 +0000
with message-id <[email protected]>
and subject line Bug#813598: fixed in gnutls28 3.4.10-2
has caused the Debian Bug report #813598,
regarding gnutls28: FTBFS[kfreebsd]: tests/mini-loss-time race
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
813598: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813598
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gnutls28
Version: 3.4.8-3
Severity: important

Hi,

gnutls28 tests/mini-loss-time fails about 20% of the time when I try it
on kfreebsd-amd64.  I think probably introduced by this commit:
https://gitlab.com/gnutls/gnutls/commit/e2a3ad31c487cbce997a08dddc55db639b60c024

The failure happens at ~60 seconds elapsed, when some (expected) timeout
is reached.  The child always exits first, and closes fds:

(49946 101730 = child)
49946 101730 mini-loss-time 60.187211 CALL  close(0x4)                      
49946 101730 mini-loss-time 60.187244 RET   close 0                         
49946 101730 mini-loss-time 60.187346 CALL  close(0x3)                      
49946 101730 mini-loss-time 60.187363 RET   close 0                         
49946 101730 mini-loss-time 60.187830 CALL  exit(0)                         

The parent receives SIGCHLD, and some wait() call on the child pid
returns:

(49871 102302 = parent)
49871 102302 mini-loss-time 60.188448 RET   select -1 errno 4 Interrupted 
system call
49871 102302 mini-loss-time 60.188572 PSIG  SIGCHLD caught handler=0x401570 
mask=0x0 code=CLD_EXITED
49871 102302 mini-loss-time 60.188594 CALL  wait4(0xffffffff,0x7fffffffdd44,0,0)
49871 102302 mini-loss-time 60.188657 RET   wait4 49946/0xc31a              
49871 102302 mini-loss-time 60.188673 CALL  sigreturn(0x7fffffffdd70)       
49871 102302 mini-loss-time 60.188689 RET   sigreturn JUSTRETURN            
49871 102302 mini-loss-time 60.188713 CALL  clock_gettime(0,0x7fffffffe320) 
49871 102302 mini-loss-time 60.188808 RET   clock_gettime 0                 
49871 102302 mini-loss-time 60.188831 CALL  clock_gettime(0,0x7fffffffe320) 
49871 102302 mini-loss-time 60.188847 RET   clock_gettime 0                 

In the successful case, the parent exits now.

In the failure case, the parent tries to read something from an fd
first, I guess a pipe that was just closed at the other end
(maybe the server didn't time out quite yet?) :

(50000 101614 = parent)
50000 101614 mini-loss-time 59.273668 CALL  recvfrom(0x5,0x624833,0x415c,0,0,0)
50000 101614 mini-loss-time 59.273686 RET   recvfrom -1 errno 54 Connection 
reset by peer

leading to GNUTLS_E_PUSH_ERROR rather than expected GNUTLS_E_TIMEDOUT.

The attached ktrace dumps can be compared using vimdiff to help
study this.  I haven't tested on GNU/Linux.

If I lower the server timeout to 29 seconds, I haven't seen this failure
any more.

--- tests/mini-loss-time.c.orig
+++ tests/mini-loss-time.c
@@ -196,7 +196,7 @@
 
        gnutls_init(&session, GNUTLS_SERVER | GNUTLS_DATAGRAM);
        gnutls_dtls_set_mtu(session, 1500);
-       gnutls_dtls_set_timeouts(session, 1 * 1000, 30 * 1000);
+       gnutls_dtls_set_timeouts(session, 1 * 1000, 29 * 1000);
 
        /* avoid calling all the priority functions, since the defaults
         * are adequate.

Thanks!

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: kfreebsd-amd64 (x86_64)

Kernel: kFreeBSD 10.1-0-amd64
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Attachment: kdump.ok.gz
Description: application/gzip

Attachment: kdump.fail.gz
Description: application/gzip


--- End Message ---
--- Begin Message ---
Source: gnutls28
Source-Version: 3.4.10-2

We believe that the bug you reported is fixed in the latest version of
gnutls28, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Metzler <[email protected]> (supplier of updated gnutls28 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 07 Mar 2016 19:22:57 +0100
Source: gnutls28
Binary: libgnutls28-dev libgnutls30 gnutls-bin gnutls-doc guile-gnutls 
libgnutlsxx28 libgnutls-openssl27
Architecture: all source
Version: 3.4.10-2
Distribution: experimental
Urgency: medium
Maintainer: Debian GnuTLS Maintainers <[email protected]>
Changed-By: Andreas Metzler <[email protected]>
Closes: 813598
Description: 
 gnutls-bin - GNU TLS library - commandline utilities
 gnutls-doc - GNU TLS library - documentation and examples
 guile-gnutls - GNU TLS library - GNU Guile bindings
 libgnutls28-dev - GNU TLS library - development files
 libgnutls30 - GNU TLS library - main runtime library
 libgnutls-openssl27 - GNU TLS library - OpenSSL wrapper
 libgnutlsxx28 - GNU TLS library - C++ runtime library
Changes:
 gnutls28 (3.4.10-2) experimental; urgency=medium
 .
   * Simplify override_dh_auto_test target. (Thanks, Steven Chamberlain)
   * Add debian/patches/42_mini-loss-time-improved-timeout-detection.patch,
     another try for Closes: #813598
Checksums-Sha1: 
 447eddf8147118040f83e6b07e5192aa33c4ad98 2900 gnutls28_3.4.10-2.dsc
 2c71c9d5bf7d275f5300027605f44567047c841d 88096 gnutls28_3.4.10-2.debian.tar.xz
 e73c384cdee37fa3d6d8a04d4fc1760c298f7bc9 3933240 gnutls-doc_3.4.10-2_all.deb
Checksums-Sha256: 
 aaecacd22aa676172047734134109333e9ac2481f270f059c7a4296f989ce746 2900 
gnutls28_3.4.10-2.dsc
 fd5dced44cbca73863d995fed072c5916b764550a8e76a57d39770d40b2da685 88096 
gnutls28_3.4.10-2.debian.tar.xz
 9e245459924271c6c32a1aa648593120675ebc2c9698bb390fe70c22c9d955e1 3933240 
gnutls-doc_3.4.10-2_all.deb
Files: 
 106a699fb3886e6c6e6909b10cc3d37f 2900 libs optional gnutls28_3.4.10-2.dsc
 78674cf72c8b5553b5f59f0bdba6d0e3 88096 libs optional 
gnutls28_3.4.10-2.debian.tar.xz
 51e773a4f77cf9a1d8c2e9113fca2904 3933240 doc optional 
gnutls-doc_3.4.10-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJW3ct1AAoJEKVPAYVDghSEo5UP/R14pRkyClCmlRjUT0oKDG8L
GdbUXfbyBeHyZDUnC8+ZbwI4M/32a6bIUtfvGBT1aKzumvCR2Y9rmC/KSSwx6FjX
J9SLyTRV50Uwx4d8yCY6U8LafTXDRnXR3Y/E7yKZSWNOMO7oXWz/9lKRJ938Tej1
rqtmzE60JMqcmhCccXX1bn02DPsfN1oXthv/J1Ue9EoCkahMcKSjvbvvd7Wlnh6b
+1QSn5iFi0Lbouo2lWLR8ZkVav4v6sSoDHpXa76JHSJjcmjdSagumJz6HwyP8Awi
5nWV+LAvx+3PhtqCyxmsq54iuVWyagiUtZDIyxrxOi1V3pGMMVMI91g6KRo2Bz1q
GUDYipQvOZz62GAor4XMXw51c0ZaSOVLwEbDMYi52Kyk/cntMDC/Tt2ZPKJOXV8q
azaYmllX0J+E5fRfXMuVon1GoFfAVDMTVVKOCVvutPiwgyrN2KfZZHLzhjyElfTt
dljcgnMQhKkCPwznpbgh91U1RRjrwGwT7Bi3CTvBrVYH8eH0fvaUPX8BxERMjDiY
xmqccnG8tupuvmoQR3UI3D8kgTJDbmw3hvBUYpRtPcjNGBHFRrcgguk3woeXnGah
NK9Zbxg2NKDofLUr5rW6u0m+L0yzSrXc1A3QmUDQZOnr0vV7FceeC8QpboTPCJZW
iXB72/yNCpTxv1YiF+Qc
=2ptb
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to