Your message dated Sun, 03 Apr 2016 19:50:12 +0000
with message-id <[email protected]>
and subject line Bug#808198: fixed in calibre 2.54.0+dfsg-1
has caused the Debian Bug report #808198,
regarding markdown-calibre: ImportError: No module named markdown.__main__
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
808198: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808198
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: calibre
Version: 2.45.0+dfsg-1
Severity: important
Tags: patch


Invocating markdown-calibre fails with an ImportError:

  Traceback (most recent call last):
    File "/usr/bin/markdown-calibre", line 19, in <module>
      from calibre.ebooks.markdown.__main__ import run
  ImportError: No module named markdown.__main__

this happens because the command fixing the import statements for
calibre.ebooks.markdown in debian/rules:

  find debian/tmp/ -name '*.py' | xargs sed -i 
's/calibre.ebooks.markdown/markdown/g'

only affects files having a .py extension which the executable
/usr/bin/markdown-calibre does not have so that markdown-calibre
continues to be included in the package with the wrong import statement.

In case markdown-calibre should continue to be part of the calibre
package (it does not appear to do more than /usr/bin/markdown_py from
the python-markdown package) I created an updated
use_system_markdown.patch file that I appended.

Alternatively one could adjust the aforementioned find command in
debian/rules to also list the markdown-calibre file:

  find debian/tmp -name "*.py" -or -name "markdown-calibre" | ...


I do not know which is to be preferred and am wondering: is there a
reason to motify the imports both via a patch file and by using sed in
debian/rules?


Another option might be to remove the calibre-markdown executable – if
it in fact does the same thing as markdown_py from python-markdown –
from the package as I did not find invocations of markdown-calibre in
the source using grep (grep -r markdown-calibre .).


--
Felix Dietrich


Author: Dmitry Shachnev <[email protected]>
Description: use system python-markdown
Forwarded: not-needed
Last-Update: 2013-04-04

Index: calibre-2.45.0+dfsg/src/calibre/library/comments.py
===================================================================
--- calibre-2.45.0+dfsg.orig/src/calibre/library/comments.py
+++ calibre-2.45.0+dfsg/src/calibre/library/comments.py
@@ -150,7 +150,7 @@ def sanitize_html(html):
     return serializer.render(stream)
 
 def sanitize_comments_html(html):
-    from calibre.ebooks.markdown import Markdown
+    from markdown import Markdown
     text = html2text(html)
     md = Markdown()
     html = md.convert(text)
Index: calibre-2.45.0+dfsg/src/calibre/linux.py
===================================================================
--- calibre-2.45.0+dfsg.orig/src/calibre/linux.py
+++ calibre-2.45.0+dfsg/src/calibre/linux.py
@@ -20,7 +20,7 @@ entry_points = {
              'ebook-meta         = calibre.ebooks.metadata.cli:main',
              'ebook-convert      = calibre.ebooks.conversion.cli:main',
              'ebook-polish       = calibre.ebooks.oeb.polish.main:main',
-             'markdown-calibre   = calibre.ebooks.markdown.__main__:run',
+             'markdown-calibre   = markdown.__main__:run',
              'web2disk           = calibre.web.fetch.simple:main',
              'calibre-server     = calibre.library.server.main:main',
              'lrf2lrs            = calibre.ebooks.lrf.lrfparser:main',

--- End Message ---
--- Begin Message ---
Source: calibre
Source-Version: 2.54.0+dfsg-1

We believe that the bug you reported is fixed in the latest version of
calibre, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Martin Pitt <[email protected]> (supplier of updated calibre package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 03 Apr 2016 21:18:01 +0200
Source: calibre
Binary: calibre calibre-bin
Architecture: source amd64 all
Version: 2.54.0+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Miriam Ruiz <[email protected]>
Changed-By: Martin Pitt <[email protected]>
Description:
 calibre    - e-book converter and library management
 calibre-bin - e-book converter and library management
Closes: 808198
Changes:
 calibre (2.54.0+dfsg-1) unstable; urgency=medium
 .
   * New upstream release.
   * Drop use_system_markdown.patch, redundant with the sedding in
     debian/rules. Thanks Felix Dietrich.
   * markdown-calibre: Use system "markdown" module. Thanks Felix Dietrich.
     (Closes: #808198)
Checksums-Sha1:
 d26d6e0f76d646e026fb97db6eb617ae309e65ae 2643 calibre_2.54.0+dfsg-1.dsc
 f6784fb2adfc9a44c217a4bdf518767e9f784142 39554788 
calibre_2.54.0+dfsg.orig.tar.xz
 a2eb2beda0aa75da569d067a814d86a8f20206d5 22668 
calibre_2.54.0+dfsg-1.debian.tar.xz
 068b45e4fdbce035903b5def4c6a9b55ccda3881 1486522 
calibre-bin-dbgsym_2.54.0+dfsg-1_amd64.deb
 d00ecc5443d00f686ab252a02702ec17c485f61b 647606 
calibre-bin_2.54.0+dfsg-1_amd64.deb
 b4a2b86344ff13059c9581126326c60f01932050 23127536 calibre_2.54.0+dfsg-1_all.deb
Checksums-Sha256:
 c5fb246b28d05facf44477eeafb5bb9fd8a5c1e0c3624625a498c1792eb1e0ac 2643 
calibre_2.54.0+dfsg-1.dsc
 e59f714ed7a38249ea77db4661e906621c86bfa589c692f22f573a1bba536c47 39554788 
calibre_2.54.0+dfsg.orig.tar.xz
 c8c5f96d4c10772dcd4fa76e8a9664ae09a529dfb5e60d9a0d9412cfd580c74d 22668 
calibre_2.54.0+dfsg-1.debian.tar.xz
 c9f5955af344886b781ad8cf1f2f8ec6e125c23d2da82942b08d209d9300824d 1486522 
calibre-bin-dbgsym_2.54.0+dfsg-1_amd64.deb
 e2168756fa0a32c57dfc37baf3dbb114af112a71848285eb45c53f46c737cbf5 647606 
calibre-bin_2.54.0+dfsg-1_amd64.deb
 80dadec4e91b567128a8e44791c4d198010aea1b089347d219e842cd495bbf26 23127536 
calibre_2.54.0+dfsg-1_all.deb
Files:
 386ab9128fa8ea1d4d661a92bcafad3d 2643 text extra calibre_2.54.0+dfsg-1.dsc
 55fc44608dffe7d7218bb345317a729a 39554788 text extra 
calibre_2.54.0+dfsg.orig.tar.xz
 30ec3e252f246de09a1f1b077e1a9b5e 22668 text extra 
calibre_2.54.0+dfsg-1.debian.tar.xz
 ae94241992942b7e59b836a5758e8e76 1486522 debug extra 
calibre-bin-dbgsym_2.54.0+dfsg-1_amd64.deb
 1f4b3880ee2eb05d995d13087d966186 647606 text extra 
calibre-bin_2.54.0+dfsg-1_amd64.deb
 4f30ae6ff751c836085d372d77c5a3c6 23127536 text extra 
calibre_2.54.0+dfsg-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXAXD0AAoJENFO8V2v4RNHN24QAJVqp35q1omgNMgvoiOi+oke
81vpOh39u76YOSUT7a6Ac8NUHbXyd8zKnzAdYzNHdM1r0amKoMEFnDddWf5f2txi
m7qwUlxHi7Rf3qVzSEbvBR2aEDSTo2i1BZBpOpETut8R/IxNnhmANFfD2lOkL0/D
Dq0x1YVRzdy4NuaQybQfN5RGIROr6Zjr1hribgPwUTqnTQmesr5OBMhLhoXap1Sk
Apk93/dbIAmldNNjGnpH6HpR/qvDoJim6WIKw4AhZ8VmhLGCV0Qu1Vnu4dgqZgjC
MCFtCwJjwCUijj+QgLH166TkCjszI6H+Ez6ZEA+qznxTQgkr/TLJVnxjL+7iSMPP
hKf64q4LX2cGu42I/7PCxdopuaZxok4ClUR0Vxkvql8TGnbLCj+HuVgQ0yj611Dx
zLCXoj5RU7Y02jHuodGpLxa1fiboaXlZp7dAd6yxDP+m9w/AdXdECr1AdFF3YGUj
CLDqiK1TQYfXar4bh8G3vYf7g2L8Z9kGGG4sKXpt6GvFq/AA5UKfbGTujgXm/Ola
RdVefs+DhPleGOgdbqNs5Su2mwuNpx1M77I8z/ArBUMHYw7s40URPO7iH2j8ZsMg
Bf7p1n5c0KmoZHcJjApAsLhg1hiyldxtAWYLZGuK/M55Y2juIipCioAS4rUWukD/
piTVvbNhuDHD2Zbs9hAL
=QWb5
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to