Your message dated Sat, 09 Apr 2016 18:34:18 +0000
with message-id <[email protected]>
and subject line Bug#780034: fixed in calypso 1.5-1
has caused the Debian Bug report #780034,
regarding calypso: --import has problems with encodings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
780034: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=780034
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: calypso
Version: 1.4
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

When I imported a ics file which was utf-8 encoded and contained
non-ascii chars, I ended up with something which looked like double
encoding, both in the actual data and the git commit messages.

After asking a friend who actually speaks python, the situation seems
to be as follows:

- - vobject's serialize() method (in import_file) returns a str
- - the Item() constructor expects a Unicode object, and failing to get
  one like here, we run into the UnicodeDecodeError with the
  decode('latin1').encode('utf-8') fallback

(At least with python 2.7, there might be something different with
python 3.*.)

Converting the serialize output to utf-8 as in the attached patch
(which is against git HEAD, not the current debian package) seems to
fix the issue. At least importing my utf-8 calendar files works, I
haven't check what happens to other encodings.


Cheers,
gregor


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQJ8BAEBCgBmBQJU/Gf4XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREMUUxMzE2RTkzQTc2MEE4MTA0RDg1RkFC
QjNBNjgwMTg2NDlBQTA2AAoJELs6aAGGSaoGwa8P/iFniiRfANxYqwPlg+E55CrG
rAE1snkf5dZToGvVyytP9YV6vgvcVdBinUro9+9mVq8CD2zi54qQGMFbT3Mx645v
N9fztvXyDdPAMvw7OssH8ZOkzCjxwhhT2nKx+pP+etUQojfFmQsS5I5yFBJ0YnYV
HGlY2D9TBcAPdQPiWXsW4M4+DoJQk+GlI+NF9c+EFBmycKLa/lVT5N/vEJsPc9/b
ZM8BpMv4SE/EuubWn27oY2sNjkwtagTYBu9Bo847f4jX9Jh9vG9HAlsuVTawx8g6
gFQcf+BUaC1IuZNzSuQgmBKoIuasbTYomiXzMbaGFknpni7NhaZpfgbUzcs7xUyR
e/OqWn1riyozEO+m/Tw8mNhOFmEdoG6shKp/WXB5SpdT1JQyNjAcWbP+UXk9HAMW
SK9rTxjCo9UHXflOr+0as3ICM/rxeT1Pm+6BvU1k3+lpFtp+wLL0fdadCRqg1bir
/0gpd+n7xH0XS30MkyV0JyVdXuvSc6vAjQ4W0W8s9opPIDt1SWLUviYz/ByhZOLE
gbNBgbogCAMb02ky3OVf3oh3MyncfEk95rPgH4Ff7kMGqmG1j9fINKc0kVh23EMY
ULXjZkts79P5SRqykE+vcuwsq4yb6dys83FSNAqjjxAAsNrr+XmqQO6qlIegZfkt
NNX0enafTZtS2QXMQ3H/
=2lzk
-----END PGP SIGNATURE-----
diff --git a/calypso/webdav.py b/calypso/webdav.py
index 2292841..4f9ef1a 100644
--- a/calypso/webdav.py
+++ b/calypso/webdav.py
@@ -506,10 +506,11 @@ class Collection(object):
                     if ve.contents.has_key('dtstart') and ve.contents.has_key('duration'):
                         del ve.contents['duration']
                     new_ics.vevent_list = [ve]
-                    new_item = Item(new_ics.serialize(), None, path)
+                    # serialize returns a str, Item expects unicode
+                    new_item = Item(new_ics.serialize().decode('utf8'), None, path)
                     self.import_item(new_item, path)
             else:
-                new_item = Item(new_ics.serialize(), None, path)
+                new_item = Item(new_ics.serialize().decode('utf8'), None, path)
                 self.import_item(new_item, path)
             return True
         except Exception, ex:

--- End Message ---
--- Begin Message ---
Source: calypso
Source-Version: 1.5-1

We believe that the bug you reported is fixed in the latest version of
calypso, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guido Günther <[email protected]> (supplier of updated calypso package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 09 Apr 2016 19:21:31 +0200
Source: calypso
Binary: calypso
Architecture: source all
Version: 1.5-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Calypso Maintaners <[email protected]>
Changed-By: Guido Günther <[email protected]>
Description:
 calypso    - CalDAV/CardDAV server with git backend
Closes: 743048 753536 753766 780034 789905
Changes:
 calypso (1.5-1) unstable; urgency=medium
 .
   [ Keith Packard ]
   * [96dc2d6] Add dependencies on python-lockfile
     (Closes: #789905)
   * [2712225] Update to debian standards version 3.9.6
 .
   [ Guido Günther ]
   * New upstream version 1.5
     * Fixes incorrect use of import_item()
       (Closes: #753766)
     * Corrects --import encoding problems
       (Closes: #780034)
     * Supports empty request body in propfind
       (Closes: #753536)
   * [3e08116] Set calypso alioth project as maintainer
   * [0970b56] Switch to 3.0 (quilt) instead of a native package
   * [08a55e3] Don't be verbose by default
   * [898c149] Add autopkgtest based on caldav-tester.
     This makes sure the server listens and processes events. This will need
     more work to pass more parts of the testsuite. (Closes: #743048)
   * [e6263cd] Bump standards version to 3.9.7 (no changes needed)
   * [70957f8] Add VCS-{Git,Browser} URLs
   * [89a7168] Allow one to override calypso's config dir
Checksums-Sha1:
 6b045e25cbab412bfdedd5b726f0b5646751d15d 2019 calypso_1.5-1.dsc
 1e7608147be5a6db75a095db804e49e9dcabf2c2 34879 calypso_1.5.orig.tar.gz
 4422cf462f1618d56f86e274d0b22650949541f9 6476 calypso_1.5-1.debian.tar.xz
 ce90673e5410afc30ae7850e00537130c502232e 19814 calypso_1.5-1_all.deb
Checksums-Sha256:
 ddcbbf05835587875d13a33be6ceb166f0f636bb49ac4311213c1b474abf7bb5 2019 
calypso_1.5-1.dsc
 895229b01597e14599ecae33109d5fac268423b0fd191d6ab21e4accfab60a92 34879 
calypso_1.5.orig.tar.gz
 335473b69a9646f4f4b75c5ec0bdf51c1804af9f6ce5df9fe1399d8c93316663 6476 
calypso_1.5-1.debian.tar.xz
 8da939a73c813bbf6b091a2502005d4cbebfab118c411c6093a0e993a882df98 19814 
calypso_1.5-1_all.deb
Files:
 ce1667df8a9fc78cded65420eb1363d5 2019 web extra calypso_1.5-1.dsc
 d15b80f74cb115749eae19b78c0a6758 34879 web extra calypso_1.5.orig.tar.gz
 b78b7612eca1135af12a7de9e88ea35a 6476 web extra calypso_1.5-1.debian.tar.xz
 fac46d676e2911635c5e981dbce1a42b 19814 web extra calypso_1.5-1_all.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJXCUhYAAoJEAe4t7DqmBILFAsP/R6NT04NxGEalHFOuYFJM0BJ
EkswJsVLaS0rDrCZ+7aMivH3fXLuLFVQ8jeolWqtzXHmAU/fdHTPaEwqoLzYNy2T
pJWGAb5foAu3+KYXmtz4v08B65mXzriwbLeRrOjPmHfLHhpTypTWnMO+Nv/NxlhX
9+JPiEE8QMmJDa7RmLC9odoEb4PaDVYTI3pDuhMHo+UemyXFxNS2k3mPjLANTb49
09unOJ7QKLcukBv3AE03zF1LdFpJ2pxGW8wCARhRlGcdKtU/y7kzzoZYFPDKJkWQ
olX6rv0SXWq+C2YrWsb36vvnVPvhp639y/yZOn4u6rQn24cYnGZPB3E4kJERxanN
C4bY99/XXNqQMYkSGjd9Ystw0JP3YjfKwrDGhNg+7zItD7jxnF+sD/izrbih8mJg
mId5Dpbjeijnq5oxqfPAF9D7OAhDH3fKc+U96N92aDvlNU/TOpoqAjuLcLGfy3Hp
n/g8F9pmferqYNZ8UxrOmligux8RLphERuYKd0V4WuyfMLPmjIopxy9ucGG3W9i9
5u7huMPpYAz/O9nwFmigYGeSPFw534t5DcCBFAXSDpCY6n4965j9RUdFCauVBLHd
nG+of7gzx4s8LpRVTHGwRBUiBXyNLDLqxmmlF1PcTklUa8nFqzWwI9ZQL8yNJ6KF
CR5XX82Mocw5eCaPwsvV
=6xsO
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to