Your message dated Wed, 13 Apr 2016 06:19:07 +0000
with message-id <[email protected]>
and subject line Bug#819340: fixed in ipmitool 1.8.16-3
has caused the Debian Bug report #819340,
regarding ipmitool: fix for missing getpass() prototype (latent segfault bug)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
819340: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819340
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ipmitool
Version: 1.8.16-2
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu xenial ubuntu-patch
Hi Jörg,
I see that you included a patch in the previous upload which fixes a number
of undeclared function errors; that's great! However, the Ubuntu
autobuilders are detecting that there is still a missing prototype for
getpass(). When building on 64-bit architectures, this is a segfault
waiting to happen, due to truncation of the return pointer.
The attached patch fixes lib/ipmi_main.c so that the prototype for the
(deprecated and non-standard) getpass() function is found, ensuring that the
build will not segfault whenever prompting for a password on 64-bit
architectures.
Thanks for considering the patch.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru ipmitool-1.8.16/debian/patches/getpass-prototype.patch ipmitool-1.8.16/debian/patches/getpass-prototype.patch
--- ipmitool-1.8.16/debian/patches/getpass-prototype.patch 1969-12-31 16:00:00.000000000 -0800
+++ ipmitool-1.8.16/debian/patches/getpass-prototype.patch 2016-03-26 17:41:18.000000000 -0700
@@ -0,0 +1,18 @@
+Description: use necessary source dialect to ensure getpass() availability
+ getpass is a deprecated function, and building with either c99 or gnu99
+ does not ensure this function's availability. So instead, declare
+ _MISC_SOURCE so that the function remains available.
+Author: Steve Langasek <[email protected]>
+
+Index: ipmitool-1.8.16/lib/ipmi_main.c
+===================================================================
+--- ipmitool-1.8.16.orig/lib/ipmi_main.c
++++ ipmitool-1.8.16/lib/ipmi_main.c
+@@ -30,6 +30,7 @@
+ * EVEN IF SUN HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES.
+ */
+ #define _XOPEN_SOURCE 700
++#define _MISC_SOURCE
+
+ #include <stdlib.h>
+ #include <stdio.h>
diff -Nru ipmitool-1.8.16/debian/patches/series ipmitool-1.8.16/debian/patches/series
--- ipmitool-1.8.16/debian/patches/series 2016-03-02 17:03:52.000000000 -0800
+++ ipmitool-1.8.16/debian/patches/series 2016-03-26 17:29:42.000000000 -0700
@@ -5,3 +5,4 @@
0610-readme_typo.patch
0600-manpage_longlines.patch
0001-Dialect_change.patch
+getpass-prototype.patch
--- End Message ---
--- Begin Message ---
Source: ipmitool
Source-Version: 1.8.16-3
We believe that the bug you reported is fixed in the latest version of
ipmitool, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jörg Frings-Fürst <[email protected]> (supplier of updated ipmitool
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 13 Apr 2016 07:45:13 +0200
Source: ipmitool
Binary: ipmitool
Architecture: source
Version: 1.8.16-3
Distribution: unstable
Urgency: medium
Maintainer: Jörg Frings-Fürst <[email protected]>
Changed-By: Jörg Frings-Fürst <[email protected]>
Description:
ipmitool - utility for IPMI control with kernel driver or LAN interface (dae
Closes: 819340 820007
Changes:
ipmitool (1.8.16-3) unstable; urgency=medium
.
* debian/rules:
- Use of USB only on Linux architectures (Closes: #820007).
Thanks to Steven Chamberlain <[email protected]>.
* New debian/patches/0110-getpass-prototype.patch:
- use necessary source dialect to ensure getpass() availability
(Closes: #819340).
Thanks to Steve Langasek <[email protected]>.
* debian/control:
- Bump Standards-Version to 3.9.8 (no changes required).
Checksums-Sha1:
7552a2008c709abca6c06b8496fcd8d2ee0cd7a8 1976 ipmitool_1.8.16-3.dsc
2884f7e651b54333fada11d0f7999415d50b4440 17788 ipmitool_1.8.16-3.debian.tar.xz
Checksums-Sha256:
4ceae40b012f2b9282e4318ad22dad15e01d5b87d73e2f81dc2a77b6d9324305 1976
ipmitool_1.8.16-3.dsc
89f5d5bfae8a856c24249b98b2d9efbc6d39b5cc1536911efd2944c5f88d6205 17788
ipmitool_1.8.16-3.debian.tar.xz
Files:
51aadfcdd819e38552bce5f848c88a0c 1976 utils optional ipmitool_1.8.16-3.dsc
32878ba06034e945e1981b40c99ed20f 17788 utils optional
ipmitool_1.8.16-3.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJXDeF6AAoJEI7tzBuqHzL/+MwQAJYE0QIhAZpVej65465GMWoY
D05HLPj3VO9n2ULgRCAkKzChZ70xQUdwF1+Fvs9oikb0Dk5Qz1vSPahsOfblsdvi
IItZG8fTEQg19slgYwnZ1RFtlQj9ulJRrWFwFoAFZWAtseOsDsojejo2zRVd2oEO
mRgqBke71Eg13LHvdhNNt56x7EFTyAvHVKOQxSCZXTVW/4m8WVrmskY+Zo3bepKZ
Auh44eLaLSWQE8nMWpgqC6yTvSFK9JXJT1V2gVMi4NYMTHvIUjfIAdw+4x/3apTu
U+P8kf0xTFK0AQZ6QfYCSUoGDjvq8bBy2J9UY0+e1WLbLUL61+rXDbi5sQqzBfZE
mlRNeV1XZ+7O+FOs3snkpALKPXc7l8pBgoeNBb4PFnjMgWRhZKPXY50NHDBUlLEX
psgiu4NSFkje97nMIlCFSaaNfMOZPbtEL9OzuChpHNLAMn63Xdt6dVoVbzUwJ7eW
j0QYRKY6BonFVIc5SZ5KaBMmuAqpCoI7eHkpwA9OTxXWIBlMA44sA+L65iXZtPIK
BkudwQV9YgEfZzBlo+1q8t2LfbWiIi6gbaogplz+ZyJkkuXSkV+zJucTfrFud5AR
cslsJBHlN/5uLADXKahA/ne1sjbNm9GNihZUnmepUFS98NwHe4Vhr3jd/eYDPjZg
sgd4f8l9tWJtdO3MW7rt
=SZZW
-----END PGP SIGNATURE-----
--- End Message ---
