Your message dated Sun, 01 May 2016 16:53:01 +0000
with message-id <[email protected]>
and subject line Bug#822848: fixed in mpd 0.19.15-1
has caused the Debian Bug report #822848,
regarding mpd FTBFS on Alpha; misaligned arrays in the test suite
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
822848: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822848
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: mpd
Version: 0.19.14-2
Severity: important
Justification: fails to build form source (but built in the past)
Tags: patch
User: [email protected]
Usertags: alpha
mpd FTBFS on Alpha with a failure in the test suite [1]:
FAIL: test/test_byte_reverse
============================
.F...
!!!FAILURES!!!
Test Results:
Run: 4 Failures: 1 Errors: 0
1) test: ByteReverseTest::TestByteReverse2 (F) line: 58
test/test_byte_reverse.cxx
assertion failed
- Expression: strcmp(result, (const char *)dest) == 0
This occurs because the test suite (in test/test_byte_reversal.cxx)
allocates static char arrays and passes the char arrays to functions
whose respective arguments were declared to be uint16_t *, etc., in
the main code.
This is in the realm of undefined behaviour on architectures with
strict memory alignment requirements. Although the test only fails
on Alpha (because Alpha has a particular CPU load instruction that
gcc likes to use to add bugs ..., ahem, optimise the code on the
assumption of alignment) it is potentially a latent bug for other
architectures with strict alignment requirements.
Since the code is compiled with the c++11 standard I attach a patch
that modifies the test suite to align the non-compliant strings with
the alignas() attribute. The test suite now passes on Alpha with
that patch.
Cheers
Michael
[1]
https://buildd.debian.org/status/fetch.php?pkg=mpd&arch=alpha&ver=0.19.14-2&stamp=1461542099
Index: mpd-0.19.14/test/test_byte_reverse.cxx
===================================================================
--- mpd-0.19.14.orig/test/test_byte_reverse.cxx
+++ mpd-0.19.14/test/test_byte_reverse.cxx
@@ -49,9 +49,9 @@ CPPUNIT_TEST_SUITE_REGISTRATION(ByteReve
void
ByteReverseTest::TestByteReverse2()
{
- static const char src[] = "123456";
+ static const char src[] alignas(uint16_t) = "123456";
static const char result[] = "214365";
- static uint8_t dest[ARRAY_SIZE(src)];
+ static uint8_t dest[ARRAY_SIZE(src)] alignas(uint16_t);
reverse_bytes(dest, (const uint8_t *)src,
(const uint8_t *)(src + ARRAY_SIZE(src) - 1), 2);
@@ -73,9 +73,9 @@ ByteReverseTest::TestByteReverse3()
void
ByteReverseTest::TestByteReverse4()
{
- static const char src[] = "12345678";
+ static const char src[] alignas(uint32_t) = "12345678";
static const char result[] = "43218765";
- static uint8_t dest[ARRAY_SIZE(src)];
+ static uint8_t dest[ARRAY_SIZE(src)] alignas(uint32_t);
reverse_bytes(dest, (const uint8_t *)src,
(const uint8_t *)(src + ARRAY_SIZE(src) - 1), 4);
--- End Message ---
--- Begin Message ---
Source: mpd
Source-Version: 0.19.15-1
We believe that the bug you reported is fixed in the latest version of
mpd, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Florian Schlichting <[email protected]> (supplier of updated mpd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 30 Apr 2016 23:47:35 +0200
Source: mpd
Binary: mpd
Architecture: source amd64
Version: 0.19.15-1
Distribution: unstable
Urgency: medium
Maintainer: mpd maintainers <[email protected]>
Changed-By: Florian Schlichting <[email protected]>
Description:
mpd - Music Player Daemon
Closes: 822848
Changes:
mpd (0.19.15-1) unstable; urgency=medium
.
* Import Upstream version 0.19.15 (Closes: #822848)
* Disable failing tests on mips64el (Binutils assertion), like we do on mips
and mipsel
* Drop typo.patch and stdint.patch, applied upstream; refresh
curl-proxy.patch and libsystemd.patch (offset)
* Add doc/include/tags.xml from upstream git, missing in tarball
Checksums-Sha1:
206e05ac5164dd5e6bd0062e18e0dfbd0c98b6ef 2942 mpd_0.19.15-1.dsc
5c32aff6ea3f031de5802a39a222efd7e4b1bafd 704000 mpd_0.19.15.orig.tar.xz
f79d07f4aca1fa5a1e0b5a2399d30291b48c4dca 31196 mpd_0.19.15-1.debian.tar.xz
366ee0a28a856ac7bc22f9ab125b1df6412b425d 6935812 mpd-dbgsym_0.19.15-1_amd64.deb
1b213029674fe5bf39a10c8886b2f56028141d05 368278 mpd_0.19.15-1_amd64.deb
Checksums-Sha256:
68c08e515f2b6cd98003de115bc7a0c5ba1c6b830ccb906ff52975d996c957fb 2942
mpd_0.19.15-1.dsc
0cb9a223894b038ce966ce6d651d9b3ea3bdc7d7b9bec8d1e9e7e091cbc29b8b 704000
mpd_0.19.15.orig.tar.xz
4cb74279b8afee369a2e788954bb6e0be657a9a51dc8cc63875f20c1511d2da8 31196
mpd_0.19.15-1.debian.tar.xz
e88a160d89b25ad138ff296b394991a345138339db0d7715fa6bf5131d18b8df 6935812
mpd-dbgsym_0.19.15-1_amd64.deb
50ad0f1a267973b08ba5693a7d2699d581b3508c50d3c0d0710141b0d999fbb6 368278
mpd_0.19.15-1_amd64.deb
Files:
d36f1259a95fceb1ffd8b3ad0508bf2a 2942 sound optional mpd_0.19.15-1.dsc
bb855b1689c9e863c2dd214ab1cb9344 704000 sound optional mpd_0.19.15.orig.tar.xz
4cbe1ea73372661790beb7984b8104a4 31196 sound optional
mpd_0.19.15-1.debian.tar.xz
3c44066fb72bc3d66cfe1d6407769bb5 6935812 debug extra
mpd-dbgsym_0.19.15-1_amd64.deb
aa88fc51809232914d8bb6a4ba0ff7a8 368278 sound optional mpd_0.19.15-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJXJjKFAAoJEBKXO25y3Ae1HeAP/jbxC2V0t/xhmm6jnhfUrLEZ
b7S/PDl1wIJ9BCuUTb05KGIOSCGwftYlrFS4En0/x/YH7qEFy7bMkDXF4cr4iUsE
lrZSNYlUI0Dj4+QrUBeJDWHTsQtKs67QWjA9WQ1pfrlr9a2za6D5z0F7+sqX5bS/
bG6zCG1uxl5odS4eGpJU6ATaX34/0zgVAU56VDPCvXiaFcnhn139swEDcyN5TNhN
X4QbcRUdl8voKvdjGP7urIWuaLorsfIpWD5iLHVh9STy8xa3m6bgvExzQa2vnpGy
HdN8pSf799zNntyw7yjPk2dKlgfetQl9ngUuG9FfYQvE7jdZhugTXVJFNXv2fcP9
4eaJlnsaepPQ/bnEPM/4Ubi2MfjGH4aZi+uRYC0M+iqObZ6RZ2iUghZl5Xk+AvjV
p256p6z0zw5YWKjshCsdxKF4NjI2FDwrVt8DgjD0RU+5xN7ZNHg2JH2tm3+sL7jq
y92seJfwFif7aBXsmMGay0jWbwVv7FSdDgTbrQv7Rrj3XvAEcq/zBStnnWHIbAIH
mmLV6ZTBpHaVHEB35Rgr8BR5geVSoqaaOVtJKjFAEA7hAIwv8Y6Yu5rVDIYf886L
Wdy7BeaF0QXJvrNzfT2QEuY7gkh6IhgmAqHTBZTOzE/9K6SUcLnPIZxSt6qqM9WO
Jyy2dQaIaiorhmMt177G
=vpgV
-----END PGP SIGNATURE-----
--- End Message ---
