Your message dated Tue, 17 May 2016 17:23:22 +0000
with message-id <[email protected]>
and subject line Bug#817927: fixed in needrestart 2.8-1
has caused the Debian Bug report #817927,
regarding needrestart emits a lot of "Unknown option:" warnings (python 
buildbot)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
817927: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=817927
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: needrestart
Version: 1.2-8+deb8u1
Severity: normal
Tags: upstream

Dear Maintainer,

I have installed needrestart on a number of jessie systems.
 Yesterday, I upgraded a machine from wheezy to jessie,
This system acts as a buildmaster.
 and asoon asI instaled needrestart, I get the following warnings after
each run of apt/aptitude::
=================
[Core] Using UI 'NeedRestart::UI::stdio'...
[main] detected systemd
[Core] #1537 is a NeedRestart::Interp::Python
Unknown option: -
Unknown option: n
Unknown option: o
Unknown option: _
Unknown option: a
Unknown option: e
Unknown option: -
Unknown option: l
Unknown option: o
Unknown option: g
Unknown option: f
Unknown option: l
Unknown option: e
Unknown option: =
Unknown option: w
Unknown option: .
Unknown option: l
Unknown option: o
Unknown option: g
Unknown option: -
Unknown option: p
Unknown option: y
Unknown option: o
Unknown option: n
Unknown option: =
Unknown option: b
Unknown option: l
Unknown option: b
Unknown option: o
Unknown option: .
Unknown option: a
[Python] #1537: could not get a source file, skipping
=================


The 1537 processus is the twisted daemon (buildmaster)
fp2x@drbuildbot:~$ ps -edf | fgrep 1537
buildbot  1537     1  0 10:24 ?        00:00:05 /usr/bin/python -c from 
twisted.scripts import twistd; twistd.run() --no_save --logfile=twistd.log 
--python=buildbot.tac
fp2x     13192 10967  0 17:34 pts/1    00:00:00 grep -F --color=auto 1537
fp2x@drbuildbot:~$ cat /proc/1537/cmdline | tr '\0' '\n'
/usr/bin/python
-c                                                [1]
from twisted.scripts import twistd; twistd.run()  [2]
--no_save                                         [3]
--logfile=twistd.log                              [4]
--python=buildbot.tac                             [5]

Extract of /usr/share/perl5/NeedRestart/Interp/Python.pm
   104      # get original ARGV
   105      (my $bin, local @ARGV) = nr_parse_cmd($pid);

   106      # eat Python's command line options
   107      my %opts;
   108      getopts('BdEhim:ORQ:sStuvVW:x3?c:', \%opts);

   109      # extract source file
   110      unless($#ARGV > -1) {
   111          chdir($cwd);
   112          print STDERR "$LOGPREF #$pid: could not get a source file, 
skipping\n" if($self->{debug});
   113          return ();
   114      }
   115      my $src = $ARGV[0];

We see that the getops() in line 108 emits a warning for each letter in 
lines
[3] through [5] of ARGV which is not in the 'BdEhim:ORQ:sStuvVW:x3?c: set

This parsing of a python command line is wrong. getopts() should be 
applied
only to the part of ARGV which is before the '-c' option.

The [3-[5] parameters are interpreted by the python twited daemon 
instance.

I am not at ease enough with perl programming to provide a patch but the 
logic is
Search backwards the (python) command line  (argv) if there is a '-c' 
option.
If the '-c' option is found, please ignore all the following tokens, and
thre is no hope to detect a source file.

IMHO, it is not a packagning bug, and it can affect a number of systems.


-- Package-specific info:
needrestart output:
Running kernel seems to be up-to-date.
No services need to be restarted.

checkrestart output:


-- System Information:
Debian Release: 8.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages needrestart depends on:
ii  dpkg                       1.17.26
ii  libmodule-find-perl        0.12-1
ii  libmodule-scandeps-perl    1.16-1
ii  libproc-processtable-perl  0.51-1
ii  libsort-naturally-perl     1.03-1
ii  libterm-readkey-perl       2.32-1+b1
ii  perl                       5.20.2-3+deb8u4

needrestart recommends no packages.

needrestart suggests no packages.

-- no debconf information

Cordialement,
Regards,
Mit freundlichen Grüßen,
مع  تحياتي الخالصة  
---
F. Petitjean
Bureau Veritas

Département Recherche, le département de l'excellence technique

Fier d'être depuis 40 ans au service de Bureau Veritas Branche Marine

Moi, lorsque je n’ai rien à dire, je veux qu’on le sache. (R. Devos)

This message contains confidential information. 
To know more, please click on the following link: 
http://disclaimer.bureauveritas.com

--- End Message ---
--- Begin Message ---
Source: needrestart
Source-Version: 2.8-1

We believe that the bug you reported is fixed in the latest version of
needrestart, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Patrick Matthäi <[email protected]> (supplier of updated needrestart package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 17 May 2016 18:54:20 +0200
Source: needrestart
Binary: needrestart
Architecture: source all
Version: 2.8-1
Distribution: unstable
Urgency: medium
Maintainer: Patrick Matthäi <[email protected]>
Changed-By: Patrick Matthäi <[email protected]>
Description:
 needrestart - check which daemons need to be restarted after library upgrades
Closes: 817807 817927 818001 818853 819824
Changes:
 needrestart (2.8-1) unstable; urgency=medium
 .
   * New upstream release.
     - Disable mail notification by default (notify.conf).
     - Restart SysV init services on systemd using systemctl.
       Closes: #818853
     - Add a easy UI mode hiding technical details for non-technical users.
       Closes: #819824
     - Add xendomains to override_rc.
       Closes: #817807
     - Improve getopts parsing to remove "Uknown option:" warnings.
       Closes: #817927
     - Fix bashisms in /etc/needrestart/notify.d/*.
       Closes: #818001
   * Merge 2.7-1~bpo8+1 changelog.
   * Bump Standards-Version to 3.9.8 (no changes required).
   * Add upstream patch 01-getterminalsize-workaround to work around the
     libterm-readkey-perl bug #824564.
Checksums-Sha1:
 f2b6783d1bc363c3dbcbef5dc7f9c84e77e748ce 1744 needrestart_2.8-1.dsc
 4ddb885aa4c24fd05657b95f635cca917887663e 46414 needrestart_2.8.orig.tar.gz
 e8c048c852e3840f885c0f5cf0a162f67323accd 6360 needrestart_2.8-1.debian.tar.xz
 b57b28c4f27e30638dc70678c7c04f3731ff8801 37980 needrestart_2.8-1_all.deb
Checksums-Sha256:
 19d80259f153066dc728f34c5bf27ce91d5cb8cffd26954e20efdc7c1fd63315 1744 
needrestart_2.8-1.dsc
 77892ad5b8873a9218d106f3b95767f008d351ebba3e3ca31b12c0189376ec85 46414 
needrestart_2.8.orig.tar.gz
 4a7b501480c7b07cc473091ddcd92556c4852d0c7756073132a8c30e44bf0ced 6360 
needrestart_2.8-1.debian.tar.xz
 152f13d019309961ef3cb00bca54576dc7297527b75895a1db5e4159c4f56c76 37980 
needrestart_2.8-1_all.deb
Files:
 66b71d2dd4bc05d23bd1549ae5d36b31 1744 admin optional needrestart_2.8-1.dsc
 0b73b910b31d36c59cf7b2d78cf0d766 46414 admin optional 
needrestart_2.8.orig.tar.gz
 5fd8651ff68629d460bcf458558c029c 6360 admin optional 
needrestart_2.8-1.debian.tar.xz
 440350dcbb23425bf464324561d54945 37980 admin optional needrestart_2.8-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXO02AAAoJEBLZsEqQy9jkqDAP/1603Uqfpsw2fxvIBkihuYxk
iCyJVJ3t4Peg0sKgGdNacMfEbR+MgM1qtcSokXMZnm4c7KPP00Z7MC4oOaXIuNdC
hIUT6kp2uiGu0Q/NkU4SQEzUTTKWAgUNkkeKyX8XZcmuw1MbxtN8gBz7bEpnv/In
CvAWLJza20qYPCcuigAIza0J+WvYBHdLjTczFniaWieNLglJ7qGaaNGOKDiFt2q9
bX8WhA3vge+EuHHddc/SDFAnc0LitUFgrw6XVPsCP2x7YLBKmQp/DtRT3QehE9mp
tcW4dgAHX+HwMuc9zKMvxcHuXewJgdltaT5TBl5eObx9v0z6gN/K4foCf9h+Jw6l
DNCdc5mhcda714LSmEnHu+yhJWJPUHHgKlTocZjJ4BSuYjfyO7OhjwdwySzBJMy6
xUJHHRBh0m0aA+1D6QPkFVXZ0oj/G//05xBaSLkmzqZx+X7X9e+EbL3mQ9L4bSum
PcEbNZBtnxvImNn0KyPv9ihaFaacPiUFijfCG0p0umAA8f0Cg0qWactEMooF9BfX
rgcNVFIL43Rbmzyy64oMWAznWzwekvPKlAL6L/CBLQd6KZKHfxopyp3TV/cJjCSd
/QxQ9zO8DE0tvvs8OM2VRWBLRmGOXlwIlDyGauotgTY+UIgH8OlKkdCMwm1qKR3V
rp+eperQpo6KSi3Euzwf
=bkqK
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to