Your message dated Mon, 23 May 2016 22:24:34 +0000
with message-id <[email protected]>
and subject line Bug#824156: fixed in vor 0.5.7-1
has caused the Debian Bug report #824156,
regarding vor: Segfaults on startup if you have a high score file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
824156: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824156
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: vor
Version: 0.5.6-1
Severity: important

Dear Maintainer,

Firstly, I'm so excited that this package has a new maintainer.
Thanks for stepping up!

It seems that the patch you added (01-string-formatting.diff) makes
the game segfault immediately on startup if you have a high score
file.

This is the change/line that's problematic:

        fscanf(f, "%s", titles[j]);

I think this says to read a string into titles[j] but titles[j] is
not writeable, it's two string constants.

The original code (before your patch) does the correct thing: it
scans (not saving the characters anywhere) past the title of the
score file section.

The other change introduced by this patch looks harmless enough,
though unnecessary, since titles[] are static strings that don't
have percents in them.

I'm attaching a score file, to save you the trouble of surviving
for 31 seconds and entering your name.

To reproduce:

1.      rename this attachment to ~/.vor-scores, or don't do that, and
        survive for over 30 seconds, and enter your name into the high
        score list, and quit.

2.      run the game

Result: segfault

Thanks!

-- 
Jason


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 4.5.0-2-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages vor depends on:
ii  libc6            2.22-7
ii  libsdl-image1.2  1.2.12-5+b6
ii  libsdl-mixer1.2  1.2.12-11+b1
ii  libsdl1.2debian  1.2.15+dfsg1-4

vor recommends no packages.

vor suggests no packages.

-- debconf-show failed
Normal
120000 -
105000 -
90000 -
75000 -
60000 -
50000 -
40000 -
34108 JasonTesting
Easy
120000 -
105000 -
90000 -
75000 -
60000 -
50000 -
40000 -
30000 -

--- End Message ---
--- Begin Message ---
Source: vor
Source-Version: 0.5.7-1

We believe that the bug you reported is fixed in the latest version of
vor, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ana Custura <[email protected]> (supplier of updated vor package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 23 May 2016 22:42:35 +0100
Source: vor
Binary: vor
Architecture: source amd64
Version: 0.5.7-1
Distribution: unstable
Urgency: medium
Maintainer: Ana Custura <[email protected]>
Changed-By: Ana Custura <[email protected]>
Description:
 vor        - 2D action game about dodging rocks in space
Closes: 824156 824159
Changes:
 vor (0.5.7-1) unstable; urgency=medium
 .
   * New upstream release, fixes string formatting compiler warnings
     (Closes: #824156)
   * Adds information to manpages (Closes: #824159)
   * Changes watch file location
Checksums-Sha1:
 bffcca808b4541c5d574a985d956fc8b33a92f33 1507 vor_0.5.7-1.dsc
 780661e0dce5602b1a7aaae443b15ecc4021e16f 279483 vor_0.5.7.orig.tar.bz2
 48fd31b4fb1f9512c44b152cbd62183253da3ca1 3608 vor_0.5.7-1.debian.tar.xz
 590c88b7a6f94e4eae7c5b9cdd4fc854735d81a1 42686 vor-dbgsym_0.5.7-1_amd64.deb
 b488e087af26da2535849ec18dd4962c23c1ec82 188272 vor_0.5.7-1_amd64.deb
Checksums-Sha256:
 2894c207f5de597bc90cb19de3d004cd5f7e846e383dac59c164ab9b7e535480 1507 
vor_0.5.7-1.dsc
 121aff9e0de541b5ab33b522b6115e515192295940b88968fc8e4e838911210a 279483 
vor_0.5.7.orig.tar.bz2
 e81bea945ee43ec32d09f68a24cf018cdd087edd13414a8381868010f2da9b16 3608 
vor_0.5.7-1.debian.tar.xz
 946acc6759e4b62edc459838c55229aeeb183c869d002eb5425a49c269a86459 42686 
vor-dbgsym_0.5.7-1_amd64.deb
 8e9352d37faa429337851c0322b06517c7e9da12c0683c0c308cd6dec8a1b69f 188272 
vor_0.5.7-1_amd64.deb
Files:
 d52ccfa20e96499e1cfe9f804b967128 1507 games optional vor_0.5.7-1.dsc
 deab8490e1eca432205bd7d61087ffa7 279483 games optional vor_0.5.7.orig.tar.bz2
 03a84dd2fd857ed4d691f74909dab955 3608 games optional vor_0.5.7-1.debian.tar.xz
 a214f5e8e6eb54753b3c7822b4053535 42686 debug extra vor-dbgsym_0.5.7-1_amd64.deb
 0266189de9c3f89c0a1af1995809c5c0 188272 games optional vor_0.5.7-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJXQ4BoAAoJEMx+J398PcNNxjUH/RM9qJPIBdwgurnrgzqZd7jc
LSJXt3zsKhPOH5pbmXcupa3A6Q92PkTgvjN3VoUIUHss7ArsR2OybZ3A3ihMdqR/
9TN83dRXuee+E7VrsPRZ0K0ov1QtrOmvCdrSLa3JRyjQ6IivfTyPYBhp6Y0z0MKg
lPaepwIZTZYVkI5BWw3V1RnGHu7csv2coQgBZLu469tDEfaF/TDUNvCOlXVg6oM7
Y5YpOvnbhxfQT0K36vFPnozTg3iYZ4kBCko9nhzwjOz/Ee6mtrmh8zFemVJJB84i
N/+v/Z5/P+LUoCMxE4yPKrY1tHJOuJvPk0xI/LrEgyUtHxrAa0SdLasVxhJgIt0=
=AX6F
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to