Your message dated Mon, 30 May 2016 13:35:41 +0000
with message-id <[email protected]>
and subject line Bug#825578: fixed in salt 2016.3.0+ds-1
has caused the Debian Bug report #825578,
regarding Support overriding salt binary locations on Debian 7
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
825578: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=825578
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: salt
Version: 2015.8.8+ds-1
Severity: minor
I believe I've ran into a small bug in the Debian 7 init.d script. I'm
currently working on a feature for the salt-bootstrap project to enable
installing salt into a virtualenv on Debian (
https://github.com/l2ol33rt/salt-bootstrap/tree/debian_venv_support). This
moves the daemon binary to a location other than the default:
/usr/bin/salt-<daemon>. I've attempted to leverage the
/etc/default/salt-<daemon> file to point to the new binary location. For
example, the file /etc/default/salt-master would contain:
DAEMON=/usr/lib/virtualenv/salt/bin/salt-master
The salt-bootstrap script pulls directly from the debian git repository (
http://anonscm.debian.org/cgit/pkg-salt/salt.git/) for its init.d scripts
since they are not bundled with the salt project itself. However, the
init.d scripts test for the daemon binary's existence right before the
loading of /etc/default/salt-<daemon> which then fails causing the service
to exit immediately.
Attached is my patch for the 4 salt init.d scripts, I hope this would be
something worth including into the salt debian repo.
System Versions:
dist: debian 7.10
machine: x86_64
release: 3.2.0-4-amd64
system: Linux
version: debian 7.10
Thanks for your time,
~Rob
https://github.com/l2ol33rt
From bd0fffa6050fead2559610ceb318f8610f518fe6 Mon Sep 17 00:00:00 2001
From: Robert James Hernandez <[email protected]>
Date: Fri, 6 May 2016 10:13:00 -0700
Subject: [PATCH] Moving daemon check to after loading default
---
debian/salt-api.init | 6 +++---
debian/salt-master.init | 6 +++---
debian/salt-minion.init | 6 +++---
debian/salt-syndic.init | 6 +++---
4 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/debian/salt-api.init b/debian/salt-api.init
index be719b8..be398cd 100644
--- a/debian/salt-api.init
+++ b/debian/salt-api.init
@@ -19,12 +19,12 @@ DAEMON_ARGS="-d"
PIDFILE=/var/run/$NAME.pid
SCRIPTNAME=/etc/init.d/$NAME
-# Exit if the package is not installed
-[ -x "$DAEMON" ] || exit 0
-
# Read configuration variable file if it is present
[ -r /etc/default/$NAME ] && . /etc/default/$NAME
+# Exit if the package is not installed
+[ -x "$DAEMON" ] || exit 0
+
. /lib/init/vars.sh
. /lib/lsb/init-functions
diff --git a/debian/salt-master.init b/debian/salt-master.init
index b92ba30..6643a25 100644
--- a/debian/salt-master.init
+++ b/debian/salt-master.init
@@ -19,12 +19,12 @@ DAEMON_ARGS="-d"
PIDFILE=/var/run/$NAME.pid
SCRIPTNAME=/etc/init.d/$NAME
-# Exit if the package is not installed
-[ -x "$DAEMON" ] || exit 0
-
# Read configuration variable file if it is present
[ -r /etc/default/$NAME ] && . /etc/default/$NAME
+# Exit if the package is not installed
+[ -x "$DAEMON" ] || exit 0
+
. /lib/lsb/init-functions
do_start() {
diff --git a/debian/salt-minion.init b/debian/salt-minion.init
index 4384747..d22fdc0 100644
--- a/debian/salt-minion.init
+++ b/debian/salt-minion.init
@@ -19,12 +19,12 @@ DAEMON_ARGS="-d"
PIDFILE=/var/run/$NAME.pid
SCRIPTNAME=/etc/init.d/$NAME
-# Exit if the package is not installed
-[ -x "$DAEMON" ] || exit 0
-
# Read configuration variable file if it is present
[ -r /etc/default/$NAME ] && . /etc/default/$NAME
+# Exit if the package is not installed
+[ -x "$DAEMON" ] || exit 0
+
. /lib/lsb/init-functions
do_start() {
diff --git a/debian/salt-syndic.init b/debian/salt-syndic.init
index 6142522..d824b54 100644
--- a/debian/salt-syndic.init
+++ b/debian/salt-syndic.init
@@ -19,12 +19,12 @@ DAEMON_ARGS="-d"
PIDFILE=/var/run/$NAME.pid
SCRIPTNAME=/etc/init.d/$NAME
-# Exit if the package is not installed
-[ -x "$DAEMON" ] || exit 0
-
# Read configuration variable file if it is present
[ -r /etc/default/$NAME ] && . /etc/default/$NAME
+# Exit if the package is not installed
+[ -x "$DAEMON" ] || exit 0
+
. /lib/lsb/init-functions
do_start() {
--
1.9.1
--- End Message ---
--- Begin Message ---
Source: salt
Source-Version: 2016.3.0+ds-1
We believe that the bug you reported is fixed in the latest version of
salt, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Wolodja Wentland <[email protected]> (supplier of updated salt package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 30 May 2016 09:01:20 +0000
Source: salt
Binary: salt-common salt-master salt-minion salt-syndic salt-ssh salt-doc
salt-cloud salt-api salt-proxy
Architecture: source all
Version: 2016.3.0+ds-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Salt Team <[email protected]>
Changed-By: Wolodja Wentland <[email protected]>
Description:
salt-api - Generic, modular network access system
salt-cloud - public cloud VM management system
salt-common - shared libraries that salt requires for all packages
salt-doc - additional documentation for salt, the distributed remote executi
salt-master - remote manager to administer servers via salt
salt-minion - client package for salt, the distributed remote execution system
salt-proxy - Proxy client package for salt stack
salt-ssh - remote manager to administer servers via Salt SSH
salt-syndic - master-of-masters for salt, the distributed remote execution syst
Closes: 825578
Changes:
salt (2016.3.0+ds-1) unstable; urgency=medium
.
[ Wolodja Wentland ]
* New upstream release
* Bump Standards-Version to 3.9.8
* Use Build-Depends-Indep for arch independent build dependencies
- Bump python-sphinx dependency to 1.3.5 as salt-doc FTBFS with earlier
versions due to https://github.com/sphinx-doc/sphinx/issues/2247
- Add python2.7-doc to correctly resolve intersphinx references to the
Python documentation
* Drop patches accepted upstream
* Fix crashing maintenance process
- See https://github.com/saltstack/salt/issues/33544 and the 2016.3.0
release notes for details
.
[ Robert James Hernandez ]
* Moving daemon check to after loading default (Closes: #825578)
Checksums-Sha1:
74739108e9386db242e63bbc4eef43e8904df351 2686 salt_2016.3.0+ds-1.dsc
b60c0b4fc923bfc7442a5549258cb056453a8bbf 5089032 salt_2016.3.0+ds.orig.tar.xz
829bf403c5c0bf235821346d635613964d1fffd4 26440 salt_2016.3.0+ds-1.debian.tar.xz
b200e4ae387b1ca2faa08abef706a89499b49c6d 22650 salt-api_2016.3.0+ds-1_all.deb
3299ac7df49bf6d7b361b2650971404389dd44e1 24142 salt-cloud_2016.3.0+ds-1_all.deb
6608128574feeef52c5c4b5a03c33f31dea5ee9c 3575054
salt-common_2016.3.0+ds-1_all.deb
759e3748515df3c23b87a836d0301dbe2b603e9b 3898898 salt-doc_2016.3.0+ds-1_all.deb
f40c11e113798974b3ae3ee0ca94fe7fe2bed98f 45674
salt-master_2016.3.0+ds-1_all.deb
b951f49df7800ba0dfb7885e03d2948d6488cf01 33370
salt-minion_2016.3.0+ds-1_all.deb
991e49c53fe8158b2419fd2737715da58796ac82 21454 salt-proxy_2016.3.0+ds-1_all.deb
1c45133d713bcafa8949d7bd955a74796a2a9dde 22740 salt-ssh_2016.3.0+ds-1_all.deb
690b9124d7c98377a1cee09bba1a4350eff2fe26 22958
salt-syndic_2016.3.0+ds-1_all.deb
Checksums-Sha256:
8d1a08b881e68788cb78ad083baa975f4aa6495da5239168ba4391520265d41b 2686
salt_2016.3.0+ds-1.dsc
f04aebf9f15d05f9c902198bb70905be02350a0e9a9d9fad7214cc8227f7c83f 5089032
salt_2016.3.0+ds.orig.tar.xz
4e165fbec81e84c5f115c7edd2145d1cb551fea8e697603d62d99989f5438570 26440
salt_2016.3.0+ds-1.debian.tar.xz
30bc1ebabf25a66f500171354740a1bd6aa335510b9d849bd38988f2ea173a5b 22650
salt-api_2016.3.0+ds-1_all.deb
ed6ead533aa63e45173485b5acccb3ca45d633ebf7a225e1d781e4d41076b129 24142
salt-cloud_2016.3.0+ds-1_all.deb
5e597899965c5dc8c8eef8d5226da54e94f33846768e84722779343212bd039c 3575054
salt-common_2016.3.0+ds-1_all.deb
40f34161733f52d9eefc68ce36987d051c629e25c1475105a80e30be1d7e5aaa 3898898
salt-doc_2016.3.0+ds-1_all.deb
3eb96ac7a4ff5a13b1a4e162d67ec8736563ad450b75aa7c7a240f6e536b8a11 45674
salt-master_2016.3.0+ds-1_all.deb
4a4bb046efaa33fea6b36528203fd5400431c7842fe0d7fc62821d54ce7edb2a 33370
salt-minion_2016.3.0+ds-1_all.deb
c6d1cd1989149dbd1a3ca11406b46cf3c73fa48e8fbc4b3932c758ca8fe8c5d8 21454
salt-proxy_2016.3.0+ds-1_all.deb
5b804a1a13f64e16eb76cc4a1a8f7f95c47b8f313ca753ae163ac54aea3bb516 22740
salt-ssh_2016.3.0+ds-1_all.deb
4b4f60c0b31b052b624a1d005c2bc0d51e0a7dd0520eb3f0728e86f43626187a 22958
salt-syndic_2016.3.0+ds-1_all.deb
Files:
c922bc9e23e817a8170eadbb6f0e15a0 2686 admin extra salt_2016.3.0+ds-1.dsc
e9be1927eba7227ff84ed87d208dec70 5089032 admin extra
salt_2016.3.0+ds.orig.tar.xz
643e7deb919edd1ed71c4df97f337fb7 26440 admin extra
salt_2016.3.0+ds-1.debian.tar.xz
ad49ad0072ab00b1d759f2910ff765a0 22650 admin extra
salt-api_2016.3.0+ds-1_all.deb
9e3b1a37c49bf83d02e10490cc239f68 24142 admin extra
salt-cloud_2016.3.0+ds-1_all.deb
eb1cfb3c85dd2ae6c72669911a73926e 3575054 admin extra
salt-common_2016.3.0+ds-1_all.deb
208d1eb57fe5ed0f8c86c2748f1e3a51 3898898 doc extra
salt-doc_2016.3.0+ds-1_all.deb
aea1f0f545ae06c9be2afd52ff431f72 45674 admin extra
salt-master_2016.3.0+ds-1_all.deb
d2da7578e013c82189ced769aec7d89d 33370 admin extra
salt-minion_2016.3.0+ds-1_all.deb
22c9e9e01d09ccbc905b5efc5ee31160 21454 admin extra
salt-proxy_2016.3.0+ds-1_all.deb
871817371551488466e4d4ae9a18b03c 22740 admin extra
salt-ssh_2016.3.0+ds-1_all.deb
7e85f53930fd1fec995c9dcb3a354d77 22958 admin extra
salt-syndic_2016.3.0+ds-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJXTDl9AAoJEN2M1aXejH56eGYP/2pUFlVu9bIQ9W15fZjGVcdY
Seoj39fcTm46uLpGtGYCkXHyn3BrJS/EQgIULDfkFFuD/LskmsD9AygYjlCulJYj
PlrxG23Iw5X/XG16p6fZV5Euoz8UQj+rE9CeeuvObW9m8sMQffHigJqNKjBDrVwq
S+Mt0KpH7YEZQjmSkvbKDJ3gXuHbvBf8MtEUmoqfdoKW6JB4pVyQ1b0U/0omJJiq
dEgLKGEFPLNPFc0+PqK+X0V6NTk2BOZD0LnX7yd91EsZADM0o5kVzOOkrolDVAxx
RTfEWpqtEirvzfpVJA7mXPj2gteswZaF7B+wAi9ikHwk+FK+qWYYodOwEMEoy6Sp
G2aZPeOVTRFOg6HWqjn7eS680WHMU1tDdeQ/f4ibZCv2uPSZQUBNmDoVpyeIIUTp
wohlxuSY6hP2hgJsv/DYbBUGtVHaToM/0GX4QC73Wn0abEES8vHjIAl7X9gf8CI0
5YnGKsXdDPe8WgcMY60iqkoZwSyV00pxZxNHQcsSUv/NSfvhcAGQJdeeyX/MA7GT
+vLTPRpAySi43rM7Ashf5bZKIIwSAu2UbsLKhyuUwGQ7q3XOsQoOdGiqW8N+NSs5
4km3ZIbcoVZuTFX8UMEORP3S+8ZJd0iDIPK1/87G0ImoFhndLUlTcYUL1BSfSork
WBjBpsalBheICp/YmyMm
=/o2q
-----END PGP SIGNATURE-----
--- End Message ---
