Your message dated Tue, 31 Jan 2006 05:32:08 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#346154: fixed in igal 1.4-15
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 6 Jan 2006 01:15:33 +0000
>From [EMAIL PROTECTED] Thu Jan 05 17:15:33 2006
Return-path: <[EMAIL PROTECTED]>
Received: from colleen.colgarra.priv.at ([82.150.197.85])
by spohr.debian.org with esmtp (Exim 4.50)
id 1EugCa-0000P2-Qb
for [EMAIL PROTECTED]; Thu, 05 Jan 2006 17:15:33 -0800
Received: from gregoa by colleen.colgarra.priv.at with local (Exim 4.60)
(envelope-from <[EMAIL PROTECTED]>)
id 1EugCE-0007D9-2W; Fri, 06 Jan 2006 02:15:10 +0100
Content-Type: multipart/mixed; boundary="===============1205951887=="
MIME-Version: 1.0
From: gregor herrmann <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: igal: HTML in captions: don't replace '&' and strip HTML for
title/alt/...
Message-ID: <[EMAIL PROTECTED]>
X-Mailer: reportbug 3.18
Date: Fri, 06 Jan 2006 02:15:09 +0100
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.5 required=4.0 tests=BAYES_00,HAS_PACKAGE,
HTML_MESSAGE autolearn=no version=2.60-bugs.debian.org_2005_01_02
This is a multi-part MIME message sent by reportbug.
--===============1205951887==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: igal
Version: 1.4-14
Severity: wishlist
Tags: patch
Today I detected that HTML is allowed in the .captions file. That's
nice (for the captions beneath the slides at large) but I stumbled
over two problems:
* s/&/&/ breaks any HTML entitites used in the captions.
* the captions are used for the page <TITLE>, for the alt/title
attributes of <IMG>, <LINK>, the next/prev-links etc. - HTML makes
no sense there or even contradicts HTML standards.
Find attached my patch that
* comments out the &-substitutions.
* introduces @captions_stripped containing captions without HTML tags
by using a function called striphtml.
For the latter I used HTML::Scrubber; if you adopt the patch,
the package must therefore Depends: on libhtml-scrubber-perl.
Greetings,
gregor
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.4.31.20050730
Locale: LANG=C, [EMAIL PROTECTED] (charmap=ISO-8859-15)
Versions of packages igal depends on:
ii imagemagick 6:6.2.4.5-0.2 Image manipulation programs
ii libimage-size-perl 2.992-2 determine the size of images in se
ii liburi-perl 1.35-1 Manipulates and accesses URI strin
ii perl 5.8.7-9 Larry Wall's Practical Extraction
igal recommends no packages.
-- no debconf information
--===============1205951887==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="igal.diff"
--- /usr/bin/igal.orig 2005-11-01 13:28:53.000000000 +0100
+++ /usr/bin/igal 2006-01-06 02:00:22.000000000 +0100
@@ -57,2 +57,7 @@
+# updated by gregor herrmann <[EMAIL PROTECTED]> 2006
+# * comment out substition of & by & (breaks HTML entities in captions)
+# * stripped HTML from $title, $altname, etc. (taking the unmodified captions
is
+# not useful or not allowed if HTML is used in captions; using
HTML::Scrubber)
+
# this is az's local RCS version info: $Id: igal,v 1.24 2005/11/01 12:26:53 az
Exp $
@@ -63,2 +68,3 @@
use URI::Escape;
+use HTML::Scrubber;
@@ -223,3 +229,3 @@
# Store image extensions, fix problematic filenames and complain
[EMAIL PROTECTED] = (); @captions = ();
[EMAIL PROTECTED] = (); @captions = (); @captions_stripped = ();
my @safenames;
@@ -247,2 +253,3 @@
push(@captions, $1);
+ push(@captions_stripped, striphtml($1));
push(@imgnames, $1);
@@ -274,3 +281,3 @@
@safenames = ();
- @captions = (); @imgext = (); $njpg = 0;
+ @captions = (); @captions_stripped = (); @imgext = (); $njpg =
0;
print "Reading the $captionfile file ... ";
@@ -289,2 +296,3 @@
push(@captions,$arr[1]);
+ push(@captions_stripped,striphtml($arr[1]));
$njpg++ if ($arr[0] =~ m/jpe?g/i);
@@ -478,3 +486,3 @@
if ($opt_k) { # use image caption for the HTML slide title
- $title = $captions[$i];
+ $title = $captions_stripped[$i];
} else { # otherwise use the image name (strip suffix)
@@ -483,3 +491,4 @@
}
- $title=~s/&/&/g; $title=~s/"/&\#34;/g; # " make this
attribute-safe
+ # $title=~s/&/&/g;
+ $title=~s/"/&\#34;/g; # " make this attribute-safe
my @[EMAIL PROTECTED]; # don't touch the original template
@@ -527,4 +536,4 @@
{
- $prev=$captions[$i-1];
- $next=$captions[($i==$nfiles-1?0:$i+1)];
+ $prev=$captions_stripped[$i-1];
+ $next=$captions_stripped[($i==$nfiles-1?0:$i+1)];
}
@@ -536,4 +545,6 @@
- $prev=~s/&/&/g; $prev=~s/"/&\#34;/g; # " make
this attribute-safe
- $next=~s/&/&/g; $next=~s/"/&\#34;/g; # " make
this attribute-safe
+ # $prev=~s/&/&/g;
+ $prev=~s/"/&\#34;/g; # " make this attribute-safe
+ # $next=~s/&/&/g;
+ $next=~s/"/&\#34;/g; # " make this attribute-safe
}
@@ -647,3 +658,3 @@
if ($opt_k) { # use image caption for the alt attribute
- $altname = $captions[$i+$j];
+ $altname = $captions_stripped[$i+$j];
} else { # otherwise use the image name (strip suffix)
@@ -653,3 +664,4 @@
- $altname=~s/&/&/g; $altname=~s/"/&\#34;/g; # " make this
attribute-safe
+ #$altname=~s/&/&/g;
+ $altname=~s/"/&\#34;/g; # " make this attribute-safe
$thumb = $thumbprefix . $safenames[$i+$j];
@@ -746 +758,7 @@
}
+
+sub striphtml {
+ local($html) = @_;
+ my $scrubber = HTML::Scrubber->new(default=>0);
+ return $scrubber->scrub($html);
+}
--===============1205951887==--
---------------------------------------
Received: (at 346154-close) by bugs.debian.org; 31 Jan 2006 13:40:43 +0000
>From [EMAIL PROTECTED] Tue Jan 31 05:40:43 2006
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 4.50)
id 1F3vc8-0003oz-4Z; Tue, 31 Jan 2006 05:32:08 -0800
From: Alexander Zangerl <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.65 $
Subject: Bug#346154: fixed in igal 1.4-15
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Tue, 31 Jan 2006 05:32:08 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: igal
Source-Version: 1.4-15
We believe that the bug you reported is fixed in the latest version of
igal, which is due to be installed in the Debian FTP archive:
igal_1.4-15.diff.gz
to pool/main/i/igal/igal_1.4-15.diff.gz
igal_1.4-15.dsc
to pool/main/i/igal/igal_1.4-15.dsc
igal_1.4-15_all.deb
to pool/main/i/igal/igal_1.4-15_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alexander Zangerl <[EMAIL PROTECTED]> (supplier of updated igal package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 31 Jan 2006 22:59:19 +1000
Source: igal
Binary: igal
Architecture: source all
Version: 1.4-15
Distribution: unstable
Urgency: low
Maintainer: Alexander Zangerl <[EMAIL PROTECTED]>
Changed-By: Alexander Zangerl <[EMAIL PROTECTED]>
Description:
igal - online image gallery generator
Closes: 346154
Changes:
igal (1.4-15) unstable; urgency=low
.
* applied/adjusted patch to fix -k -c with html in the captions
(thanks to gregor herrmann for the fix!) (closes: #346154)
* new dependendy libhtml-scrubber-perl
Files:
aab0c29fe7cb5a0279e4add2fd8d2042 551 web optional igal_1.4-15.dsc
b61bebb7962dad2c0afd38f236cddc58 29502 web optional igal_1.4-15.diff.gz
62a55ed75d30fb26ae16523d5620cb22 24868 web optional igal_1.4-15_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFD3188py/2bEK9ZF0RAiPKAJ9ZIDwv183KaOxfUHW1n/qot/y5ZwCeMumH
JSBHRXtWQ4dXFLB5YfK9NlY=
=RjN3
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
