Your message dated Tue, 05 Jul 2016 06:34:06 +0000
with message-id <[email protected]>
and subject line Bug#828953: fixed in mxt-app 1.27-2
has caused the Debian Bug report #828953,
regarding mxt-app FTBFS on 32bit architectures (i386, mips) on testing
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
828953: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=828953
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: mxt-app
Version: 1.27-1
Severity: serious
Tags: sid + patch
Justification: FTBFS
User: [email protected]
Usertags: mips-patch
Hi,
Package mxt-app FTBFS on 32bit architectures with following error:
make --no-print-directory check-TESTS
FAIL: run-unit-tests
====================================
mxt-app 1.27: ./test-suite.log
====================================
# TOTAL: 1
# PASS: 0
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
.. contents:: :depth: 2
FAIL: run-unit-tests
====================
[==========] Running 1 test(s).
[ RUN ] mxt_convert_hex_test
0x1a != 0
src/test/test_utilfuncs.c:65: error: Failure!
[ FAILED ] mxt_convert_hex_test
[==========] 1 test(s) run.
[ PASSED ] 0 test(s).
[ FAILED ] 1 test(s), listed below:
[ FAILED ] mxt_convert_hex_test
1 FAILED TEST(S)
FAIL run-unit-tests (exit status: 1)
build logs:
https://buildd.debian.org/status/fetch.php?pkg=mxt-app&arch=mips&ver=1.27-1&stamp=1465527085
https://buildd.debian.org/status/fetch.php?pkg=mxt-app&arch=mipsel&ver=1.27-1&stamp=1465521348
https://buildd.debian.org/status/fetch.php?pkg=mxt-app&arch=i386&ver=1.27-1&stamp=1464327106
The test is failing because of the undefined behaviour of strcpy() when dest
buffer is smaller than src buffer.
Bug is in mxt_convert_hex_test function in /src/test/test_utilfuncs.c file.
Destination buffer (hex) is 4 bytes, and on strcpy(hex, "0FAB"); there is no
space left to copy the null terminator.
The attached patch resolves buffer owerflow.
Patch is tested on i386, amd64, mips, mipsel, mips64el.
Earlier version was successfully built on 32bit architectures because there
were no tests.
Thank you!
Regards,
Daniel
--- mxt-app-1.27.orig/src/test/test_utilfuncs.c
+++ mxt-app-1.27/src/test/test_utilfuncs.c
@@ -43,7 +43,7 @@ void mxt_convert_hex_test(void **state)
{
/* test setup */
uint8_t databuf[5] = {0};
- char hex[4];
+ char hex[5];
uint16_t count;
int ret;
--- End Message ---
--- Begin Message ---
Source: mxt-app
Source-Version: 1.27-2
We believe that the bug you reported is fixed in the latest version of
mxt-app, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Eric Dorland <[email protected]> (supplier of updated mxt-app package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 05 Jul 2016 02:18:41 -0400
Source: mxt-app
Binary: mxt-app
Architecture: source amd64
Version: 1.27-2
Distribution: unstable
Urgency: medium
Maintainer: Eric Dorland <[email protected]>
Changed-By: Eric Dorland <[email protected]>
Description:
mxt-app - Command line utility for maXTouch devices
Closes: 828953
Changes:
mxt-app (1.27-2) unstable; urgency=medium
.
*
debian/patches/0001-mxt_convert_hex_test-fails-on-32bit-architectures.patch:
Fix build failure on 32-bit arches. (Closes: #828953)
Checksums-Sha1:
2975ac22d240ae84a64355bafb90c5995faedb82 1882 mxt-app_1.27-2.dsc
e6d5f34a2ca82849904d57b727ce1f31119b4ee9 2340 mxt-app_1.27-2.debian.tar.xz
ae6d1027c7b6b79eeef93637e8ea43b86e6a6aba 118380 mxt-app-dbgsym_1.27-2_amd64.deb
97a123c90fd7ccfb02e70d1d3d7d3770921c7c7c 54462 mxt-app_1.27-2_amd64.deb
Checksums-Sha256:
c5887efb40ffcc076c0b86eab1ef9ac22ac21eba19f1ee120ee05e2e55a1900e 1882
mxt-app_1.27-2.dsc
64b43a0168d650766b705e8da9ec77765aad9e87ea45a6d1a0e799500f271b51 2340
mxt-app_1.27-2.debian.tar.xz
81f802f2d924e770aab38eacaddff3e1571764f1a54e887563e9d72efc7abab8 118380
mxt-app-dbgsym_1.27-2_amd64.deb
040b1c8bd3e936a6eee5d02a8a96c0f966e7ad3d0ec8be016843d287c8716532 54462
mxt-app_1.27-2_amd64.deb
Files:
7e86faa4a16545fd61bf5368775d6a35 1882 utils optional mxt-app_1.27-2.dsc
5e805235f05ea2724a492cc223af8ba8 2340 utils optional
mxt-app_1.27-2.debian.tar.xz
2db494f6e34e94e1aeddffa35785c0da 118380 debug extra
mxt-app-dbgsym_1.27-2_amd64.deb
cd987e17fa32ae0f1a88d6923a8fd65f 54462 utils optional mxt-app_1.27-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJXe1JdAAoJEMJW+9UAIh6TGygQAINoNshJbOj4X8pJFU65OjHI
YKPE+AZiENJPqqKdZ8+ah6vaGm8AdYUoq4/9D/DPp8AT9f+wB3g+CfxdGMWiUOES
9GC5XO4mt9F3HbA2mwa2RubxJlVczMmgx3YnO6lFmkFoRYQtZ7PT+FsYQ395WbIO
s49qbdD1wLCsr0a+8DCoOXunGHxEBQd5CP8DWyZFTQ8GfMHeqZfIr+AHw8JrSQq4
IWNYqohX+OVD2nRHSeo1EuOj+t6zZGipbKB43w/mrfIWy1ftpSvfvFVx0C+65O/f
78oAc3LhP3Jp4Tu79/i1RZ+JzGxYBdhDmcAMRl2/qU8XYBk+dztsGx+aNsqL0gy+
49MWt5snWtw/V6etQUswz/f0WEeghK8UV6OjWMxuUtwvEK4b9lNkChzW+q97FpQ6
+bZffz4+L2gs/BFkBFhNlIkJqEdmfd/fKqUHNlRucYlP1863usiqfHNOBqdzXF6p
WtmEpqCI4oKeC3Po5TJ3klqu6u8C70S+hVb4yqoxXmcCP6PHDV7kdz94cGKeeUnU
7zkZJjreyFR4gPvlboplZShgSm/smwC/J+qeHo74RiqvTYPP+U9Io2CT583eC9rP
esTaARXsDZIUSeh6jbajlETNZU00DgoP/7QpyvWWGBsiCa/CrltcpvPcJ4CG1xAF
/9FDeGUymSo/DDUGdgF4
=pGVg
-----END PGP SIGNATURE-----
--- End Message ---
