Your message dated Thu, 14 Jul 2016 05:33:31 +0000 with message-id <[email protected]> and subject line Bug#829302: fixed in dh-golang 1.19 has caused the Debian Bug report #829302, regarding dh-golang: Respect "--parallel" and "--max-parallel" options to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 829302: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829302 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: dh-golang Version: 1.18 Severity: wishlist Tags: patch Currently build is always parallel even in compat <= 9 mode because dh-golang ignores "--parallel" and "--max-parallel" options. Lack of support for parallel options is a practical problem because by default "go build" aggressively uses all CPU cores which can overuse resources on heavy packages. For example Kubernetes FTBFS on workstation with 8 cores and 32+ GiB of RAM due to lack of memory or (when there is enough RAM) it causes so much swapping during build that the whole system becomes nearly unusable. With Kubernetes and other packages it would be quite useful to be able to limit build to certain number of cores by using debhelper's "--max-parallel=N" option. The following patch does that: ~~~~ --- lib/Debian/Debhelper/Buildsystem/golang.pm +++ lib/Debian/Debhelper/Buildsystem/golang.pm @@ -178,8 +178,9 @@ $this->_set_gopath(); if (exists($ENV{DH_GOLANG_GO_GENERATE}) && $ENV{DH_GOLANG_GO_GENERATE} == 1) { $this->doit_in_builddir("go", "generate", "-v", @_, get_targets()); } + unshift @_, ('-p',$this->get_parallel()); $this->doit_in_builddir("go", "install", "-v", @_, get_targets()); } ~~~~ as well as it makes build respect "--parallel" option for DH consistency. -- Best wishes, Dmitry Smirnov GPG key : 4096R/53968D1B --- What can be asserted without proof can be dismissed without proof. -- Christopher Hitchens, 2004
signature.asc
Description: This is a digitally signed message part.
--- End Message ---
--- Begin Message ---Source: dh-golang Source-Version: 1.19 We believe that the bug you reported is fixed in the latest version of dh-golang, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Dmitry Smirnov <[email protected]> (supplier of updated dh-golang package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Thu, 14 Jul 2016 15:07:49 +1000 Source: dh-golang Binary: dh-golang Architecture: source all Version: 1.19 Distribution: unstable Urgency: medium Maintainer: Debian Go Packaging Team <[email protected]> Changed-By: Dmitry Smirnov <[email protected]> Description: dh-golang - debhelper add-on for packaging software written in Go (golang) Closes: 827226 829302 Changes: dh-golang (1.19) unstable; urgency=medium . * Team upload. . [ Paul Tagliamonte ] * Use a secure transport for the Vcs-Git and Vcs-Browser URL . [ Dmitry Smirnov ] * Perlcritic corrections for "Glob written as <...>". * Avoid linking pre-installed DH_GOPKG package to itself (Closes: #827226). * Respect "--parallel" and "--max-parallel" options (Closes: #829302). Checksums-Sha1: b3b35192d83104c5d7ed9c6938ad42ba2e28ac38 1639 dh-golang_1.19.dsc 8c8409b5f85dfba281f5e0e1821e7672ef063479 7560 dh-golang_1.19.tar.xz 141661afca709319e574bdf7e1c49676d1b0fd34 9548 dh-golang_1.19_all.deb Checksums-Sha256: a0ac4050660e9b3e9cd7fd43f14ea2900cf0be3bea28aa6be2fea86a244f9685 1639 dh-golang_1.19.dsc 4cf164f6bc302f9a9d5fe40b8618714a3ef1898bcaa884e0fc5fd49dc71b5574 7560 dh-golang_1.19.tar.xz 4d0953899130c1da1d47df0812c0c9c97b3a0ae7fbabfa5388c8d58de9b1bcb3 9548 dh-golang_1.19_all.deb Files: a8b4cc936806e58d0d9dc6e7789483a7 1639 devel extra dh-golang_1.19.dsc 96d5fd68a477cac53a6b08910629aba2 7560 devel extra dh-golang_1.19.tar.xz 41f91a1858eafc771427191106e9f966 9548 devel extra dh-golang_1.19_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJXhyF/AAoJEFK2u9lTlo0bpMMP/Rrwqnl7K+KDAWF/wq4W38xy aJ5YNVJY8Nc/5ZFqNZm7RpSNArN6z2BIomgD0DYOg6VYSF0zZRRATtGSEVf3RiSQ ZpdKanJvLVpyI/Otr7ZcKxk3vy9CFa8CSPD76QZq9ulbbh+v/o4lKG5Bdn16UwLm bz9CYc5gYOUSJqV9VOHTz7HOD4X+/c9WrdNI1ggtMmdDBtQGlsjgio76lSHWxQmp b6vPXNlSPB/gAIAkngAKYXm5b0LQuKyc7VnKwPW2BKypUUDjHRFzeqvWrZPw0c13 TtlZLH+fIOoVP1BLOrYFbsl319jCCs5dhXFyKF7pl4Psjp7ocmM9j8x0cWR6gIHE acShj4zZ3bqMbxzP07aBwtHCWzNs8KzW6ClGDRhOao7aPU8HQpOnmrV349M/y7zk OdPma6EPWBaqDHTqdq7V2qYrXcDccW2Q61m25UstQzpm8ZpX+xsqMwXJ70gxu8mq ZWLKiuqDm/l2spofoiEBy67YQdwh3XdT2eGTAK55ukk6G0vagP7v4VU67HF6XRPv guNgMHxpfyXZAa1+vls+nEsrDfPEuDRiQ0QKzqCEY5Ekse090Zl5rrBcoA2KfZ/G b3B+OQkx3f+G3H929Sl50FDFfewivrKpL1elI8IUk7ELvfP5WPTJWq5tX7eb0tc7 uubEdMmVGJkh9TEkyy31 =nOpv -----END PGP SIGNATURE-----
--- End Message ---
