Your message dated Thu, 18 Aug 2016 23:54:23 +0100
with message-id 
<1471560863.2445110.699616505.57757...@webmail.messagingengine.com>
and subject line Re: gkrellm: please make the build reproducible
has caused the Debian Bug report #834774,
regarding gkrellm: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
834774: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834774
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: gkrellm
Version: 2.3.7-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: umask
X-Debbugs-Cc: [email protected]

Hi,

Whilst working on the Reproducible Builds effort [0], I noticed
that gkrellm could not be built reproducibly.

This was because dh_fixperms was not being called (to avoid mangling
the existing chmod), meaning that files were installed to the .deb
varying on the current umask.

The solution is to reinstate the call to dh_fixperms but to use its
--exclude argument.

Patch attached.


 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
--- a/debian/patches/11_reproducible_build.patch        1970-01-01 
01:00:00.000000000 +0100
--- b/debian/patches/11_reproducible_build.patch        2016-08-18 
23:15:25.450065961 +0100
@@ -0,0 +1,23 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2016-08-18
+
+--- gkrellm-2.3.7.orig/Makefile
++++ gkrellm-2.3.7/Makefile
+@@ -98,6 +98,7 @@ ifeq ($(INSTALLROOT),)
+       INSTALLROOT = /usr/local
+ endif
+ 
++SHELL = /bin/bash
+ INSTALLDIR = $(INSTALLROOT)/bin
+ SINSTALLDIR ?= $(INSTALLDIR)
+ MANDIR ?= $(INSTALLROOT)/share/man/man1
+@@ -131,7 +132,7 @@ all gkrellm: gkrellm.pc
+       (cd server && ${MAKE} gkrellmd)
+ 
+ gkrellm.pc: Makefile
+-      echo 'prefix=$(INSTALLROOT)\n'\
++      echo -e 'prefix=$(INSTALLROOT)\n'\
+       'Name: GKrellM\n'\
+       'Description: Extensible GTK system monitoring application\n'\
+       'Version: $(VERSION)\n'\
--- a/debian/patches/series     2016-08-18 23:05:15.325157840 +0100
--- b/debian/patches/series     2016-08-18 23:15:23.206047861 +0100
@@ -2,3 +2,4 @@
 04_fix_manpage_hyphen.patch
 05_bts437033_fix_strip.patch
 10_fix_glib_underlinkage.patch
+11_reproducible_build.patch

--- End Message ---
--- Begin Message ---
Not sure what happened here. Whilst I could assign it (etc.) to the right 
package, I think it would be too confusing in the history, so closing and 
re-filing correctly.

Apologies for the noise.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-

--- End Message ---

Reply via email to