Your message dated Sun, 21 Aug 2016 23:19:12 +0000
with message-id <[email protected]>
and subject line Bug#834012: fixed in jenkins-job-builder 1.6.1-1
has caused the Debian Bug report #834012,
regarding jenkins-job-builder: crashes when the job being replaced contains 
non-ASCII
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
834012: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834012
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: jenkins-job-builder
Version: 1.4.0-1
Severity: normal
Tags: fixed-upstream patch

I work with someone who cares about correct Unicode typography,
including in the output of the scripts we !include into Jenkins jobs.
Unfortunately, jenkins-job-builder 1.4 doesn't appear to be fully
Unicode-clean: if the (scripts !include'd into the) job I am replacing
contains non-ASCII, python2-jenkins-job-builder crashes with

  return hashlib.md5(xml).hexdigest()
UnicodeEncodeError: 'ascii' codec can't encode character u'\xb4' in position 
2967: ordinal not in range (128)

while python3-jenkins-job-builder crashes with a different exception:

  return hashlib.md5(xml).hexdigest()
TypeError: Unicode-objects must be encoded before hashing

This upstream commit seems to be the right solution:
https://git.openstack.org/cgit/openstack-infra/jenkins-job-builder/commit/?id=aa3bf5cc195b1e36e5aa8eda2cd7bfc4f192a0d9

Please consider applying the patch, or updating to an upstream
release >= 1.5.0 to get it included.

Thanks,
    S
>From aa3bf5cc195b1e36e5aa8eda2cd7bfc4f192a0d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Joakim=20L=C3=B6fgren?= <[email protected]>
Date: Mon, 22 Feb 2016 12:50:47 +0100
Subject: Fix issue with non-ascii characters in get_job_md5

The xml string needs to be encoded to utf-8
before passing it to the hash function.

Change-Id: I4b6ca7ef459b48a2ba56f788fe37307ee381ced4
Story: 2000488
---
 jenkins_jobs/builder.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/jenkins_jobs/builder.py b/jenkins_jobs/builder.py
index 6e257bb..28901b5 100644
--- a/jenkins_jobs/builder.py
+++ b/jenkins_jobs/builder.py
@@ -158,7 +158,7 @@ class Jenkins(object):
 
     def get_job_md5(self, job_name):
         xml = self.jenkins.get_job_config(job_name)
-        return hashlib.md5(xml).hexdigest()
+        return hashlib.md5(xml.encode('utf-8')).hexdigest()
 
     def delete_job(self, job_name):
         if self.is_job(job_name):
-- 
cgit v0.12


--- End Message ---
--- Begin Message ---
Source: jenkins-job-builder
Source-Version: 1.6.1-1

We believe that the bug you reported is fixed in the latest version of
jenkins-job-builder, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Goirand <[email protected]> (supplier of updated jenkins-job-builder 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 17 Aug 2016 10:59:59 +0000
Source: jenkins-job-builder
Binary: python-jenkins-job-builder python3-jenkins-job-builder 
jenkins-job-builder-doc jenkins-job-builder
Architecture: source all
Version: 1.6.1-1
Distribution: unstable
Urgency: medium
Maintainer: PKG OpenStack <[email protected]>
Changed-By: Thomas Goirand <[email protected]>
Description:
 jenkins-job-builder - Configure Jenkins using YAML files - metapackage
 jenkins-job-builder-doc - Configure Jenkins using YAML files - doc
 python-jenkins-job-builder - Configure Jenkins using YAML files - Python 2.7
 python3-jenkins-job-builder - Configure Jenkins using YAML files - Python 3.x
Closes: 834012
Changes:
 jenkins-job-builder (1.6.1-1) unstable; urgency=medium
 .
   [ Ondřej Nový ]
   * Standards-Version is 3.9.8 now (no change)
   * d/rules: Changed UPSTREAM_GIT protocol to https
 .
   [ Fathi Boudra ]
   * New upstream release (Closes: #834012).
   * Remove removes-deprecated-depends.patch - merged upstream.
   * Add builders-add-publish-over-ssh-support-as-a-build-step.patch
     'Publish over SSH' plugin is only supported in the publishers.
     It can also be used as a build step during the build process.
     https://review.openstack.org/#/c/98437/
   * Bump python-pbr (build-)depends from 0.8.2 to 1.0.0.
 .
   [ Thomas Goirand ]
   * Build-Depends on openstack-pkg-tools >= 52~ and use its new facilities.
   * The binary for generating jobs is now /usr/bin/jenkins-jobs and not
     jenkins-job-builder, updating maintainer scripts (for update-alternatives)
     accordingly.
Checksums-Sha1:
 42dac4f89822ffdc3ed73c349ed1f5c31c8619c1 2811 jenkins-job-builder_1.6.1-1.dsc
 df261c72bd50e1b2dfb7212a1b5cb99dd3a56a82 251244 
jenkins-job-builder_1.6.1.orig.tar.xz
 c57d8e477afeaf8b5f032ab3c07bcd2cefc90df8 8516 
jenkins-job-builder_1.6.1-1.debian.tar.xz
 4434a240036b0e91755ceeadd67704e8f543c64b 156356 
jenkins-job-builder-doc_1.6.1-1_all.deb
 f068b4a2a875413ff342e439b51166c182c0780f 5166 
jenkins-job-builder_1.6.1-1_all.deb
 1cc9d3b74708dcf9b4c7acebbf9856a4d787cd5e 153624 
python-jenkins-job-builder_1.6.1-1_all.deb
 78c9ba6cadec0a9dedd542e33a8f1e96e8e369dc 153478 
python3-jenkins-job-builder_1.6.1-1_all.deb
Checksums-Sha256:
 51cc67c39a23897cee771937622c0dadbed1232e31f86f2e144d1c2c8a671827 2811 
jenkins-job-builder_1.6.1-1.dsc
 07f4697a02d9c7f323dd3a1140e49504cf8c6b9052eee450ee1d3d1cb6f8b763 251244 
jenkins-job-builder_1.6.1.orig.tar.xz
 4b43f22c0ba9f4a6b42a29a89f1a3b028cc416adb8348f5fc3fe59a6355c2805 8516 
jenkins-job-builder_1.6.1-1.debian.tar.xz
 5503a2ef1c5d05e2adfdd06bbf7bac7aae9c4c60954a9542b18cf796d6f319d7 156356 
jenkins-job-builder-doc_1.6.1-1_all.deb
 9f0910931454b96dc94b8e8827006af7f92723d18b23824302019fd98e26593e 5166 
jenkins-job-builder_1.6.1-1_all.deb
 491d7eea19f327f23665139300417c2598cdcbe51689bbbc928eb00f2b82a134 153624 
python-jenkins-job-builder_1.6.1-1_all.deb
 3bd6e628f6b3ba57501015a8f1cbaa9e270cc62cd0060ce51b5c5ba0afd523a3 153478 
python3-jenkins-job-builder_1.6.1-1_all.deb
Files:
 642ed680737930a1f8880eea1b31a844 2811 python optional 
jenkins-job-builder_1.6.1-1.dsc
 7b77088e60cea2ced3e3272076397b84 251244 python optional 
jenkins-job-builder_1.6.1.orig.tar.xz
 cb82a5d19790139a17a540b3c17df55a 8516 python optional 
jenkins-job-builder_1.6.1-1.debian.tar.xz
 c8688e393c8b2655fdaa43b1850d3611 156356 doc optional 
jenkins-job-builder-doc_1.6.1-1_all.deb
 97eb815af9c322dc63eb5d13c037f9f0 5166 python optional 
jenkins-job-builder_1.6.1-1_all.deb
 506f35034af90b50eaa8fd337430a112 153624 python optional 
python-jenkins-job-builder_1.6.1-1_all.deb
 b8e18ea61c33797dbbc0a2a617a2a5ee 153478 python optional 
python3-jenkins-job-builder_1.6.1-1_all.deb

-----BEGIN PGP SIGNATURE-----

iQItBAEBCAAXBQJXujNNEBx6aWdvQGRlYmlhbi5vcmcACgkQ1BatFaxrQ/7llw/9
GAwD+nhdQ57GY3ycElaXnccIYOLj7GTiSEhln5JRFM5qufywOwYiAEwlJHjKVdUo
KbQwQ/jGfi/iZljtM+dWfh9cqEOGyHMMDKfYfSf0JvBl9ymJ6P12pLwjs2u0p/rj
2QMdm8SpsJEnew6oMhJNuWhQt58GlV4uEXHn6RyblqFyn22NehmRWMvNSmbvebaH
HKOs1NJkuImOzZxK/jWGuFrQp43VosUOAIGYuqVIMZ435C+zeYTkUPEZUY0MfunV
7Py5t6dWvpOe0QwJR61E+8rjI7JKQHk4CdrdK6IbXGf0/ta55khMazfrWpIkoxNq
K5evUDsSReOueQIFOrL83QDb15dDUU9Bu30CBnAT4h9Y7my2+dfjBZe7E8q4Vgpx
xcj0/EqFdIjlW2b+cSRmP+TBPKa97DjDHNl5eoG3LGDEywrKd96nhwxDnB4kEpHY
HTcM9C9UjSqeoAFXZL+ukfg8nHZ7/OCAdeNA7/YHqlt1+JIZMBd5hUV628czzlib
CX1xZjHjGamUleWDD32xaENq0GiEeJ9yV0JpW7Rz54/Lh7VY5aR83KRRKtmqZHn1
JGYgYR5r1IJlcPTCVvJ/o5XU/Zq2s4g5FB/C0EuMUVtziI/haiE8dauJfYQ+llvh
gBjrSsTmxAkos1mtASKEl1+u4d+pH1RYFxEugCy8sno=
=rSBT
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to