Your message dated Sat, 03 Sep 2016 18:23:24 +0000
with message-id <[email protected]>
and subject line Bug#829595: fixed in module-assistant 0.11.9
has caused the Debian Bug report #829595,
regarding m-a: please mark packages on install as auto-installed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
829595: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829595
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: module-assistant
Version: 0.11.8
Severity: wishlist
Tags: patch

Hi,

if m-a is ordered to (auto-)install a package it will do so via "dpkg -i
module.deb"[0]. This causes apt and friends to believe that this package
was manually installed and hence never considers it for autoremoval.

apt (and hence his libapt based friends) have for a while now special
support for kernels allowing old kernels to be autoremoved after they
aren't used anymore. That works good, but m-a is raining on this parade:
Module packages tend to depend on the kernel images they were built for
(as they become quite useless without them) hence breaking autoremoval.

apt actually not only prevents the kernel itself, but also out-of-tree
modules (as long as their name matches '^.*-modules-KERNELVERSION$' or
'^.*-kernel-KERNELVERSION$') belonging to those kernels from being
autoremoved, so it would be great if m-a would declare these module
packages as auto-installed to let autoremoval kick in as intended for
kernel images, headers and modules alike.

The attached simple patch implements this auto marking (but probably not
in the greatest of perl as my knowledge in it is very limited).


Best regards

David Kalnischkies


[0] That could be improved upon by now, but that requires a recent apt,
so in the interest of backports I will leave that slide for the moment
– and it doesn't change the manual vs auto part discussed here anyhow.
From fbb1d6e1d19496c52b208fe155fa6eb3bebbaab5 Mon Sep 17 00:00:00 2001
From: David Kalnischkies <[email protected]>
Date: Fri, 1 Jul 2016 12:02:08 +0200
Subject: [PATCH] mark build packages as auto-installed in apt

In the way kernel packages are shipped they are always auto-installed,
but apt protects a reasonable set of them from being autoremoved and it
also protects the modules built for these kernels from being autoremoved.
In this way old kernels can leave the system without requiring users to
manually remove them (before they fill up their disks).

So by marking all modules installed by m-a we can let apt do its kernel
magic as otherwise apt believes these modules were manually installed
and hence never considered for autoremoval (along with the kernel they
are built for as the modules depend on the kernel image).
---
 module-assistant | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/module-assistant b/module-assistant
index 5d36f0e..c83c0c9 100755
--- a/module-assistant
+++ b/module-assistant
@@ -1023,6 +1023,11 @@ sub install {
       print STDERR "\nI: " . gettext("Direct installation failed, trying to post-install the dependencies") . "\n\n";
       $ret += withecho($sudo, $aptcmd, $opt_noninter?"-fy":"-f","install");
    }
+   foreach $deb (@debs) {
+      my @scores = split "_", File::Basename::fileparse($deb);
+      push(@buildpkgs, $scores[0]);
+   }
+   withecho ($sudo, "apt-mark", "auto", @buildpkgs) if($#buildpkgs >= 0);
 }
 
 sub clean {
-- 
2.8.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: module-assistant
Source-Version: 0.11.9

We believe that the bug you reported is fixed in the latest version of
module-assistant, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Eduard Bloch <[email protected]> (supplier of updated module-assistant package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 03 Sep 2016 20:02:21 +0200
Source: module-assistant
Binary: module-assistant
Architecture: source all
Version: 0.11.9
Distribution: unstable
Urgency: low
Maintainer: Eduard Bloch <[email protected]>
Changed-By: Eduard Bloch <[email protected]>
Description:
 module-assistant - tool to make module package creation easier
Closes: 437466 829595
Changes:
 module-assistant (0.11.9) unstable; urgency=low
 .
   * When debian/rules is called without frontend, try to get information from
     include/generated/utsrelease.h as well
   * In generic.sh, rename the internal override variable $BUILDDIR to avoid
     confusion by environments like pbuilder shell
   * Also considering tar.lzma extension in tarball lookup
   * Don't attempt to install linux headers if they have been configured by the
     user via command line option (closes: #437466)
   * Mark module packages as auto-installed (by David Kalnischkies,
     closes: #829595)
Checksums-Sha1:
 e3754076e42b4eedd8f19cae1fa4623c4b899403 1733 module-assistant_0.11.9.dsc
 480e0ef45936220aa625e54947aa7a154cae961a 93680 module-assistant_0.11.9.tar.xz
 c0099693b3da7e8804fdf0bd11d8dd29ee404ab2 100538 module-assistant_0.11.9_all.deb
Checksums-Sha256:
 a3a1e3e21ed5d48797b737185b834a1782511ba725854075e0587376c07d75db 1733 
module-assistant_0.11.9.dsc
 fd4349b41dbadf706291ab462b045831363b8da85edfcee2044725f19d03fa24 93680 
module-assistant_0.11.9.tar.xz
 b9ba353c9c3e15d1520c7bea8d67790fb029f441b6d4c46c60051c8781438d67 100538 
module-assistant_0.11.9_all.deb
Files:
 21da2969e9ef3b0989c4bb5345356029 1733 kernel optional 
module-assistant_0.11.9.dsc
 0a3f6590bc6c6f9ecd3072b1b9e82729 93680 kernel optional 
module-assistant_0.11.9.tar.xz
 c9f1116236bd937b40810290c5b844d7 100538 kernel optional 
module-assistant_0.11.9_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBV8sTGGl0DlyzX+w8AQhmTA/+J2WR6GqvNk2ZPuidfvhUlC+yFeDGtff1
aNIasz5Ja+64CrC+EFOhnJu4thez/6Ytm2dwFHgRbAxbro97p7zTuSkF9QE2g/8P
1aAxcLdFtAHmFeeTkwnEgKMH80rS0+2+NJAz066BNub3xEZyA9z0c1dcqMXINOR9
jFhKwfSeVc9CAdI+Z21a0IsCyGd4cjvSS4Cd0541pBDur7yPKdwiBxzulfdVs9ME
aQ1eNDkZfjQA1Y2ROBcjilYTKQnn6Rlu6+9tmMMT/D4HYj6ZRhXvBHGBaSnHsQ6d
8WpO/AqlBuNeapDZfYkbJc+jBPjrBpOcV87JB+FUdE5rFvAfrw9KP17jZAI4+1EN
Ba+ZLQ7Myg408VqrIp6fnFNQNaDILKbDTM7jA5miABUdghJXWaG2UW/UIYPlfzW8
gO4RmnjigXqWKCJbKw3acURrRvnKXQLV6pR3AWIW53sVbzBuX/GD1SwlmSP7Y0cZ
YFKvmZt1q9SBbIIvCoetOepnKeb9qlegnYWCQwbbGr6zdnBxu0IG5iP5I2z0olyc
mGLSbHd5SIsM7BBAEArc4DiUsKxT9MPJgaS05kfs/LoDGT6H2nhVncTFRwQ7UTvc
qvzDZ2pRXdWbPAL5OweXXoCCWvkb+1JE4MrBGeZGC5aQLpbv8RVY0dzFiQQ35Iwx
ZjI/pJlhlyw=
=aBO2
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to