Your message dated Fri, 07 Oct 2016 00:19:43 +0000 with message-id <[email protected]> and subject line Bug#382550: fixed in xsok 1.02-17.1 has caused the Debian Bug report #382550, regarding xsok can overwrite last level's savefiles to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 382550: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=382550 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: xsok Version: 1.02-16 The find next unsolved level command (shift-U) in xsok can cause the last level's savefiles to be overwritten if no unsolved level is found. To reproduce: - solve last level - go to second last level - press shift-U, then s (for 'save') - this creates a savefile with the wrong level number. The same effect occurs if you now solve this level and beat the current record. Proposed fix: * do not use global variable game.level as a counter --- a/src/commands.c +++ b/src/commands.c @@ -54,9 +54,10 @@ void cmd_LevelInfo(void) { } void cmd_NextUnsolved(void) { - while (game.level < maxlevel) { - if (!highscore[++game.level]) { - NewLevel(game.level); + int level = game.level; + while (level < maxlevel) { + if (!highscore[++level]) { + NewLevel(level); cmd_LevelInfo(); return; } With kind regards, Bertram Felgenhauer
--- End Message ---
--- Begin Message ---Source: xsok Source-Version: 1.02-17.1 We believe that the bug you reported is fixed in the latest version of xsok, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Markus Koschany <[email protected]> (supplier of updated xsok package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 06 Oct 2016 23:32:23 +0200 Source: xsok Binary: xsok Architecture: source Version: 1.02-17.1 Distribution: unstable Urgency: medium Maintainer: Peter Samuelson <[email protected]> Changed-By: Markus Koschany <[email protected]> Description: xsok - generic Sokoban game for X11 Closes: 382550 478985 630230 664300 817738 Changes: xsok (1.02-17.1) unstable; urgency=medium . * Non-maintainer upload. * Switch to compat level 10. (Closes: #817738) * Remove debian/override.Lintian file. * Provide a desktop file and a new icon. (Closes: #478985) * Remove deprecated dpatch and upgrade to packaging format "3.0 quilt". Thanks to Jari Aalto for the report and patch. (Closes: #664300) * Declare compliance with Debian Policy 3.9.8. * Replace dh_clean -k with dh_prep. * Add recommended build-arch and build-indep targets. * Add Homepage field and point to tracker.debian.org. * Use set -e in prerm script. * Add do-not-use-global-variable-as-counter.patch, so that xsok won't overwrite the last level's savefile. Thanks Bertram Felgenhauer for the report and patch. (Closes: #382550) * Translate the help files into German. Allow users to use these translated files when LANG=de_DE.UTF-8 is set. Thanks to Helge Kreutzmann for the report and the translations. (Closes: #630230) Checksums-Sha1: c7b438f0a5caf7b80d83d779837928629e45d67b 1862 xsok_1.02-17.1.dsc fe63cf4b281adf198a7c5d9259291e79cccd5379 18568 xsok_1.02-17.1.debian.tar.xz Checksums-Sha256: 73402612c5bcd12d29901dacdf77c81ddccdf6400ec2424cdd3dd32f11bcb94a 1862 xsok_1.02-17.1.dsc 5806f2132ff4905b2c8fef256aa5509e8f1e40f6838a5f65003b39230bb8ffe0 18568 xsok_1.02-17.1.debian.tar.xz Files: d1a8d73f0a426a89e2c11987e7606749 1862 games optional xsok_1.02-17.1.dsc 3f52e8dc9836ad6c0ef70dda479a89b2 18568 games optional xsok_1.02-17.1.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQKMBAEBCgB2BQJX9t8fXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBQ0YzRDA4OEVGMzJFREVGNkExQTgzNUZE OUFEMTRCOTUxM0I1MUU0DxxhcG9AZGViaWFuLm9yZwAKCRDZrRS5UTtR5GXyD/oC Z2Up1Mb1EQZ2aycENkQywL6PsNVlwhlgqCFP7mpVPwt4r3xL/RCNQ8m7Jdc4kQX/ 3QW6HwJs1m1i7lvkRIoRCKNtO0loU209AeGol7/zWJRDbHELtO4Xs6V+G7zWNYtS b9+kayyAE9K1mQniWX7t4hNxWenpBdlra3NbxBm/eeXcygl3T3wkOkL1zm1/PxsT i5ws6RJh/n+wcwkngfFZ/9XJCe35rQ7IaG38SlcvnfA05Fh0onw/ccdDihQMEJEU 8m4PGOTOH0H+fSOKBVQ4h5S0QLIOQv3BnM/iGTskWZdkHdRZhVjFVGIf6+3tZNcS N1O9nfYwqDk25t+kA3YoB9YRnsuv8MAiFAwRhZ7fBT/3hQEurCPuUItfJWkbP1DZ pJkBwjr0mixjfZm1wSK/bN9rtJI46GXPYlSWT86LjeAwJUnlR0FH0TJFnenBw26t LQm0uCjsk+zU25zprJbCgNPgjxiUNrGjrDioCWe3z/0sv0hslzRD+vlIvuA9v7yW NwFkAcp4FoInBByuwqcNOKudIQ1tBCUf5+lWNLLIHQkiG8yHIjd5WkK4c5oPwY6r oFQJ2dej2rSkjG9zMpteSxJcrfb4jRO1qBkDW8ARC6ymedV7IiZgNwmZSvXsffH1 nsgDslxgJUFeGC+2Dsf/rV/H/19zPc/v7GsXcKDFmw== =E2gE -----END PGP SIGNATURE-----
--- End Message ---
