Your message dated Wed, 02 Nov 2016 05:19:14 +0000 with message-id <[email protected]> and subject line Bug#807208: fixed in tahoe-lafs 1.11.0-2 has caused the Debian Bug report #807208, regarding Various bugs in /etc/init.d/tahoe-lafs to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 807208: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=807208 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: tahoe-lafs Version: 1.10.2-2 Tags: patch Dear Maintainer, There are a couple of bugs in /etc/init.d/tahoe-lafs: - When AUTOSTART is set to "none", the initscript attempts to start the node “/var/lib/tahoe-lafs/none”. - When AUTOSTART lists a non-existing node, the initscript attempts to start it. - When a node is not owned by any existing user (node with an uid but without an username), stat -c %U returns "UNKNOWN". The attached patch resolves these issues. However, for the third issue, it may be a good idea to allow starting nodes that are not owned by a regular user, perhaps by using sudo -u '#uid' -g '#uid' instead of su. Regrads, Sebastien Behuret *** /etc/init.d/tahoe-lafs 2015-09-16 06:40:00.000000000 +0100 --- tahoe-lafs 2015-12-06 13:41:44.487529209 +0000 *************** *** 39,45 **** node_uid () { local node_dir="$1" ! stat -c %U "$CONFIG_DIR/${node_dir}" } _tahoe () { --- 39,45 ---- node_uid () { local node_dir="$1" ! [ -d "$CONFIG_DIR/${node_dir}" ] && stat -c %U "$CONFIG_DIR/${node_dir}" } _tahoe () { *************** *** 47,57 **** --- 47,67 ---- local node_name="$2" local node_uid=$(node_uid "$node_name") + if [ -z "$node_uid" ]; then + log_failure_msg "${node_name} node directory does not exist!" + return 1 + fi + if [ "$node_uid" = "root" ]; then log_failure_msg "${node_name} node directory shouldn't be owned by root!" return 1 fi + if [ "$node_uid" = "UNKNOWN" ]; then + log_failure_msg "${node_name} node directory is not owned by any user!" + return 1 + fi + case "$action" in start|restart) su -s "/bin/sh" \ *************** *** 77,84 **** if [ $# -eq 0 ]; then if [ "$AUTOSTART" = "none" ] || [ -z "$AUTOSTART" ]; then log_warning_msg " Autostart disabled." ! fi ! if [ "$AUTOSTART" = "all" ]; then # all nodes shall be taken care of automatically for name in $(nodes_in $CONFIG_DIR); do _tahoe "$command" "$name" || STATUS="$?" --- 87,93 ---- if [ $# -eq 0 ]; then if [ "$AUTOSTART" = "none" ] || [ -z "$AUTOSTART" ]; then log_warning_msg " Autostart disabled." ! elif [ "$AUTOSTART" = "all" ]; then # all nodes shall be taken care of automatically for name in $(nodes_in $CONFIG_DIR); do _tahoe "$command" "$name" || STATUS="$?"
--- End Message ---
--- Begin Message ---Source: tahoe-lafs Source-Version: 1.11.0-2 We believe that the bug you reported is fixed in the latest version of tahoe-lafs, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Ramakrishnan Muthukrishnan <[email protected]> (supplier of updated tahoe-lafs package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Wed, 02 Nov 2016 10:21:21 +0530 Source: tahoe-lafs Binary: tahoe-lafs Architecture: source all Version: 1.11.0-2 Distribution: unstable Urgency: medium Maintainer: Ramakrishnan Muthukrishnan <[email protected]> Changed-By: Ramakrishnan Muthukrishnan <[email protected]> Description: tahoe-lafs - Secure distributed file store Closes: 807208 Changes: tahoe-lafs (1.11.0-2) unstable; urgency=medium . * d/control: update twisted version to match src/allmydata/_auto_deps.py. * d/rules: remove the dh_prep overrides, which are not needed anymore. * d/tahoe-lafs.init: - when AUTOSTART is set to "none", don't start a node named "none". - when AUTOSTART lists a non-existing node, don't attempt to start it. - handle the case where the node is not owned by any existing user. Thanks to Sébastien Béhuret <[email protected]> for the patch. (Closes: #807208) Checksums-Sha1: 2b7efe6508b83a840a86299ae5fb68d7b4a06f9a 2012 tahoe-lafs_1.11.0-2.dsc ae36f92f84032304afd38d017bd6ffc4fa280bdb 11896 tahoe-lafs_1.11.0-2.debian.tar.xz 8b20bcf579423747964366b00861e75441ac6fb2 1128618 tahoe-lafs_1.11.0-2_all.deb Checksums-Sha256: 20b3397f7a42ba6d3fcb905eeb930aada70af366c2882eb3a45adc9ed9644c9f 2012 tahoe-lafs_1.11.0-2.dsc 3ed3bbb4d30aedc799a829eb66ed46439db733933d3eb9e96733d9fc737a3394 11896 tahoe-lafs_1.11.0-2.debian.tar.xz 5f2fd637270d56dcc61994b86df464c57487104c367249dde51e6514d80f6720 1128618 tahoe-lafs_1.11.0-2_all.deb Files: d862e1570de2c7cfa076b97c2ac297be 2012 utils optional tahoe-lafs_1.11.0-2.dsc 47275c17408e7105600d54d88e8a18a8 11896 utils optional tahoe-lafs_1.11.0-2.debian.tar.xz 10f1cc7da4b68d33f42ea3e841210ee1 1128618 utils optional tahoe-lafs_1.11.0-2_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJYGXL6AAoJEM9kzWHrRsqafxMP/0mqyTJIb1SyA8wv/2YDjJbu aBJQgiU51RNptxUtu6KzqIjwf4Z9bNgNozrmiI3yGGVgaRPP5cNiqeJ2oxi+c+SJ K27GXb2c9dncjpDAGS3oIRuM+pGReanK4rZeKeyE6JOreqk+FtdKg03SHSdfEa8R ATsCyUyv6RrSftBP6fEDNDU4Q7Xk0ZyyZ7qTYftIJayTsqov4bNKOrTci3brrNQb ooFKvZYGK4NHP3fI28S2KnijGfCvxlIgmBorVecwYyG7JaS81xM38ZcAjvyekhyG +ij2C1Znz1CPBWFbD+2M8ZvYu/nm4YDoluv0tF3cy3vUPu4mwy/cYkp3AIDMh0t8 1uMC7ofGzyncwhFtyKHJ51BKG9q8mJu0RAQb0EIU7H3q/h7a9X0+sHPBQzS6EdTW 5ol39SQBST+O0Zr/tj95vSyu4GfHeIwnIwFnxCMfi/+IBxSw44+Q306qQxc+SZby 4idcGaeVTbhMEiJMlaPD7fS4fdn5goT0nnuc2334ZPoqSomy3yuvow2LaDtcCWgx s+CTHtkFUw1kTqtdPHwnRvnnPiVzmhseTkd4TaRzWkPczrh9M4CI3TE6TB4lw/P6 Ew99u7hVIrFMoPjiPEGSDpiGaaIVskTe0G/6CzNXbR8DJ5WebzTgFTxUdTUuVBai nt2Afk4s97xlDx0o2ukw =aCUD -----END PGP SIGNATURE-----
--- End Message ---
