Your message dated Mon, 21 Nov 2016 06:35:09 +0000
with message-id <[email protected]>
and subject line Bug#829714: fixed in tcptrace 6.6.7-5
has caused the Debian Bug report #829714,
regarding tcptrace: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
829714: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829714
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: tcptrace
Version: 6.6.7-4.1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timestamps username hostname
X-Debbugs-Cc: [email protected]
Hi!
While working on the "reproducible builds" effort [1], we have noticed
that tcptrace could not be built reproducibly.
It embeds the current build date/time, the username and hostname into
the binary.
The attached patch strips this to enable reproducible building.
Regards,
Reiner
[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/Makefile.in b/Makefile.in
index 03e1cd9..9bc3957 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -200,8 +200,7 @@ tcptrace: ${OFILES}
# If you have problems getting "whoami", "hostname", or "date" to run on
# your machine, just hack in a quick string below in place of the command.
version.o: ${CFILES} Makefile
- ${CC} ${CFLAGS} -o version.o -c $(srcdir)/version.c \
- -DBUILT_USER="\"`whoami`\"" -DBUILT_HOST="\"`hostname`\"" -DBUILT_DATE="\"`date`\""
+ ${CC} ${CFLAGS} -o version.o -c $(srcdir)/version.c
#
# special rules for scanner/parser
diff --git a/tcptrace.c b/tcptrace.c
index 7cd7519..4fd23df 100644
--- a/tcptrace.c
+++ b/tcptrace.c
@@ -658,8 +658,6 @@ static void
Version(void)
{
fprintf(stderr,"Version: %s\n", tcptrace_version);
- fprintf(stderr," Compiled by '%s' at '%s' on machine '%s'\n",
- built_bywhom, built_when, built_where);
}
diff --git a/version.c b/version.c
index e8715fc..68fd3f0 100644
--- a/version.c
+++ b/version.c
@@ -57,9 +57,3 @@ static char const GCC_UNUSED rcsid_version[] =
"@(#)$Header: /usr/local/cvs/tcptrace/version.c,v 5.4 2003/11/19 14:38:06 sdo Exp $";
-/* build information */
-/* constants filled in when version.c is compiled */
-char *built_bywhom = BUILT_USER;
-char *built_when = BUILT_DATE;
-char *built_where = BUILT_HOST;
-
diff --git a/version.h b/version.h
index 4f95979..705760a 100644
--- a/version.h
+++ b/version.h
@@ -67,9 +67,3 @@ static char const GCC_UNUSED rcsid_version[] =
/* the string to print */
#define VERSION "Ostermann's tcptrace -- version " VERSION_NUM " -- " VERSION_DATE
-
-/* build information */
-/* constants filled in when version.c is compiled */
-extern char *built_bywhom;
-extern char *built_when;
-extern char *built_where;
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: tcptrace
Source-Version: 6.6.7-5
We believe that the bug you reported is fixed in the latest version of
tcptrace, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Noah Meyerhans <[email protected]> (supplier of updated tcptrace package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 20 Nov 2016 15:27:21 -0800
Source: tcptrace
Binary: tcptrace
Architecture: source amd64
Version: 6.6.7-5
Distribution: unstable
Urgency: medium
Maintainer: Noah Meyerhans <[email protected]>
Changed-By: Noah Meyerhans <[email protected]>
Description:
tcptrace - Tool for analyzing tcpdump output
Closes: 624296 829714
Changes:
tcptrace (6.6.7-5) unstable; urgency=medium
.
* Restructure the source package to use quilt format with all
Debian modifications contained within the debian/ directory.
* Update to debhelper 9 compatibility.
* Update to policy version 3.9.8 (no changes needed)
* Import patch from Reiner Herrmann <[email protected]> to support
reproducible builds. (Closes: #829714)
* Import patch from Christophe Rhodes <[email protected]> to correct a
URL decoding error in mod_http.c. (Closes: #624296)
Checksums-Sha1:
b715234193d9554d6c40d0defdfddae91a0a0bb8 1718 tcptrace_6.6.7-5.dsc
d99f366717ff51ac067b86f3e8094c01a7a66023 6236 tcptrace_6.6.7-5.debian.tar.xz
d229d5cb7f36ba3851fafab420641087919c660d 284676
tcptrace-dbgsym_6.6.7-5_amd64.deb
4d94122dcc04a97827a153f879b7ab3de1437d55 4710 tcptrace_6.6.7-5_amd64.buildinfo
b8e480af8cf4201409463797c1990e6855823209 159232 tcptrace_6.6.7-5_amd64.deb
Checksums-Sha256:
fc57df999dfa41ad8f8c4a8ad85a8ed53d5956adb0a1ac1109b01df8aaa9eb17 1718
tcptrace_6.6.7-5.dsc
dfc74648b96e9c565e75e75e0e6cfb16614d7c0f893900b54c3bf14c0c00a233 6236
tcptrace_6.6.7-5.debian.tar.xz
d5d521097e49719b2912514a5011ad7f1f2bd7b606eb89189b2bc4b6db6032ea 284676
tcptrace-dbgsym_6.6.7-5_amd64.deb
029126d0ea264e06d45519daa8a4b9b6e83dc82a859b33433016ff3d0a39fb06 4710
tcptrace_6.6.7-5_amd64.buildinfo
a477dbdc387eb7101c8f25d11676f8b0af3b165891e66f6ba4677d88c0d42202 159232
tcptrace_6.6.7-5_amd64.deb
Files:
fc4b545757079fe9bed98391dc1ac168 1718 net optional tcptrace_6.6.7-5.dsc
020fafd6736c7bbf32960a78373452d4 6236 net optional
tcptrace_6.6.7-5.debian.tar.xz
8a40d195d1c93085bb3d27f8bca39c67 284676 debug extra
tcptrace-dbgsym_6.6.7-5_amd64.deb
de35d1c238814ac77bfb3a4be64a6242 4710 net optional
tcptrace_6.6.7-5_amd64.buildinfo
ce309f3d5aaef9e2ef0df1ce9fde0cc3 159232 net optional tcptrace_6.6.7-5_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIuBAEBCAAYBQJYMpKEERxub2FobUBkZWJpYW4ub3JnAAoJEPYw89L1q13T+30P
/ibopxgqucCdEVCQXhKCkLUH5C7BvRVNQ9zTiJyksAE0M83Fxq8ss/Zo9BicvPZ/
q3+MkbOkMthSetFcUGj1stVzgKNOCMOuWTORGi6Vpss/0qkC4+EF6a2lPnE4XjTK
csMBTIoeLsg2TTKnecknUVvnHHDiIx9QvrzUhCYEcIrfynqjc1Jjmk6/XkEQMhF8
QPsGpLgNerhFswpxU4QKkStgAYR31nlooEBE4GEzgGeSLgvoMnIrB2yJMWzIzXmt
EfSup9o5EOMCnZ/ZTJLI6nGjxCjF6AJeJ6ekXmoVpx7Zf36hDrSP2IK6nGEqE+K/
gMywmygmhRCbqgPYWY24ZPvIg+9qlE6ixmlGhOBHNsV0ci0WijbOajybb/lbzMXM
nK71lKwj9rNcvRUNaQZoeP/aPPkrpChtB0a6ZH2j1ViDy9v17EfFEUc50L6n6n2b
Xcxj4rd1pAg23MOpAhBhrSKWBe4cfcJYqcghkQiUWyrUxAxOlzqf5GFFtlsdPU+I
pMCtCwaTb3amkAfCL1Xgmm4N0j41wDI/q2SEHWegDSnjJ8hEWIUejE14/9J2oTMB
ueaN4cMDZLRB5Ymg3RZ+2iftb/hB0L08UXEWQ5rxvzj7sjbo+WYbr+0lRvwkIIQE
wUA/+UPcJ9ILkJAQSOFjZ6JQyg7t1kaK/Acn3sb1Dz3s
=Bv0+
-----END PGP SIGNATURE-----
--- End Message ---
