Your message dated Sun, 27 Nov 2016 00:03:51 +0000 with message-id <[email protected]> and subject line Bug#819036: fixed in daemontools 1:0.76-6.1 has caused the Debian Bug report #819036, regarding daemontools: supervise does not handle restarting the monitored process if fork(2) fails to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 819036: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819036 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: daemontools Severity: normal Dear Maintainer, I would like to report bug in daemontools. Supervise process in daemontools does not correctly hande the situation when the monitored process (e.g. dnscache) died and supervise is trying to fork new process and fork() fails. Supervise then only logs: supervise: warning: unable to fork for dnscache, sleeping 60 seconds: out of memory Here is the patch (6 years tested) which fixes the problem: diff -Nur admin.orig/daemontools-0.76/src/supervise.c admin/daemontools-0.76/src/supervise.c --- admin.orig/daemontools-0.76/src/supervise.c 2010-02-19 11:08:15.000000000 +0100 +++ admin/daemontools-0.76/src/supervise.c 2010-02-19 12:53:16.000000000 +0100 @@ -86,6 +86,8 @@ const char *run[2] = { "./run", 0 }; +int flagfailed = 0; + void trystart(void) { int f; @@ -94,6 +96,7 @@ case -1: strerr_warn4(WARNING,"unable to fork for ",dir,", sleeping 60 seconds: ",&strerr_sys); deepsleep(60); + flagfailed = 1; trigger(); return; case 0: @@ -153,6 +156,11 @@ } } + if (flagfailed && flagwant && flagwantup){ + flagfailed = 0; + trystart(); + } + if (read(fdcontrol,&ch,1) == 1) switch(ch) { case 'd': -- System Information: Debian Release: 8.3 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
--- End Message ---
--- Begin Message ---Source: daemontools Source-Version: 1:0.76-6.1 We believe that the bug you reported is fixed in the latest version of daemontools, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Dr. Tobias Quathamer <[email protected]> (supplier of updated daemontools package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sun, 27 Nov 2016 00:26:56 +0100 Source: daemontools Binary: daemontools daemontools-run Architecture: source Version: 1:0.76-6.1 Distribution: unstable Urgency: medium Maintainer: Gerrit Pape <[email protected]> Changed-By: Dr. Tobias Quathamer <[email protected]> Description: daemontools - collection of tools for managing UNIX services daemontools-run - daemontools service supervision Closes: 776876 793003 819036 831921 Changes: daemontools (1:0.76-6.1) unstable; urgency=medium . [ Jan Mojzis ] * Non-maintainer upload. * supervise.c: restart the monitored process when fork(2) fails (Closes: #819036) * d/rules: fix mtimes before building binary package to produce reproducible output (Closes: #793003) (Closes: #776876) * d/rules: do not FTBFS with dpkg-buildpackage -A (thx Santiago Vila) (Closes: #831921) * d/implicit: fixed md5sums permissions 0664 -> 0644 * d/control: bump to standards-version 3.9.8 * d/control: fixed the description . [ Dr. Tobias Quathamer ] * New upload with all changes from Jan, his previous NMU to DELAYED/5 did not end up in unstable. Checksums-Sha1: 3eec85af794cad3394156a79cf4ae28df04905dc 1665 daemontools_0.76-6.1.dsc 19bd2fcd469cc24a75985d25dfde896f792cda73 19739 daemontools_0.76-6.1.diff.gz Checksums-Sha256: 784b70c3d500d97d05224249f4dd69ba44333c240b34c566d4f5197b6dcbb958 1665 daemontools_0.76-6.1.dsc 4037720a5c10e190a97ca93662d7380f109a041c2fe1e890df4461ea28950844 19739 daemontools_0.76-6.1.diff.gz Files: ce2f9ac9119d1a7a58b858de3346fb12 1665 admin optional daemontools_0.76-6.1.dsc 10cae62cc2fecd5dfd88d996d03d7ab2 19739 admin optional daemontools_0.76-6.1.diff.gz -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJYOhxfAAoJEBMC8fA26+sZTcEP+wUFzlRMrzE4/KhYpmxVHted gN6FPegeXlMewONG4Hwm6IW7ak0ZHAq2T1rzQJpTYaq55MRkD7vjCD0njICSj8ki IDnTxAN3vIR5zlotiefHwJs2lifbP0sh3ELOGVrIXNmnjgnh+acGeTOM/nLcjETP 5v38FJRnlh6RCBudrWjTILBX+pdAGN8QbcgvVh+L3NPN4R6oA27TkJygQiDM5mfA CTk7FIml8xxrjJkVa0yKdptL7kJVwmQA4jsY1OSHEZifOMNgFwFYQ4HBZs8JT7dM mxaUOiVmCfaY61sXuRzX6ildwSOV+Xa3egaPhO5rR+3gDTCsl1BtVJ9yM2gS4C8y /47ejV2/Edac4Zdo72F2KzAM94fEugFtNJduWJVuOqqSO9rSPq/SGBuVkwf3uHn2 ed3tA7zgu0UkZX5ibrK0eJnZXwWNZ3dZsZJO3rmYMFz/pAIoSlvY0EMvupdQMs7R g/XNP2fyEc0ffsIhNMchiSdrgW0rRpcpUwz8vNy4kfeqiERztRDJTcs8tu6P/csx 0BBRYkVhT6WQ7ktRKb3z7FrDCBpyLx/BXNzoI1DXL25nopMXO0HNM9eC3Y7+Z46u GrEzr0E2UaXUYMmYNpkZeFb1neNw1x3cTXmaI5BWW0Kk1Ala65UcA1TgqunTDWf3 BVdJcQGcS/rFdg7bc/OW =aGmF -----END PGP SIGNATURE-----
--- End Message ---
