Your message dated Sun, 27 Nov 2016 21:05:53 +0000 with message-id <[email protected]> and subject line Bug#755447: fixed in debarchiver 0.11.0 has caused the Debian Bug report #755447, regarding debarchiver: Allow vrfycmd to include command line options to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 755447: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=755447 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: debarchiver Version: 0.10.1 Severity: normal Hi Ola, I ran into another quirk today :) The way that $vrfycmd is used means it's not directly possible to set that to a command that requires some arguments other than the changes file. What I wanted to do was this: $vrfycmd = "dscverify --no-default-keyrings --keyring /var/lib/debarchiver/.gnupg/pubring.gpg"; So that I could sign packages uploaded to this repo with a different key to the one that is in the DD keyring, to avoid there ever being any sort of accident with them actually getting pushed into a distro upload queue (either by me, or by someone else later). It looks like there's a few easy options to fix this though. My favourite so far is the patch below, which is backward compatible for any existing user config, but lets me instead do: @vrfycmd = ("dscverify", "--no-default-keyrings", "--keyring", "/var/lib/debarchiver/.gnupg/pubring.gpg"); Which ensures there'll never be any quoting issues for weird arguments. Alternatively we could do system("$vrfycmd $cfile"), but that has a different set of pros and cons. It looks like the rest of the *cmd options go through cmdaction() so they don't have this problem. If you like this version, it probably also wants a oneliner in the sample debarchiver.conf too to note @vrfycmd can be an array now. Cheers, Ron --- /usr/bin/debarchiver 2014-07-21 06:05:08.059769856 +0930 +++ debarchiver 2014-07-21 07:22:11.316828267 +0930 @@ -96,6 +96,7 @@ $rmcmd = "rm -f"; $movecmd = "mv"; $vrfycmd = "dscverify"; +@vrfycmd = ($vrfycmd); $cachedir = "/var/cache/debarchiver"; $inputdir = "/var/lib/debarchiver/incoming"; $destdir = "/var/lib/debarchiver/dists"; @@ -1742,9 +1743,9 @@ } # Verify signatures. if ($verify) { - if (system($vrfycmd,$cfile)) { # non-zero == verification failure + if (system(@vrfycmd,$cfile)) { # non-zero == verification failure pdebug(4, "Signature verification failed for $cfile"); - $CConf{ERROR} = "$CConf{ERROR}$vrfycmd was not able to verify $cfile.\n"; + $CConf{ERROR} = "$CConf{ERROR}@vrfycmd was not able to verify $cfile.\n"; return "reject"; } }
--- End Message ---
--- Begin Message ---Source: debarchiver Source-Version: 0.11.0 We believe that the bug you reported is fixed in the latest version of debarchiver, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Ola Lundqvist <[email protected]> (supplier of updated debarchiver package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 14 Nov 2016 21:34:42 +0100 Source: debarchiver Binary: debarchiver Architecture: source all Version: 0.11.0 Distribution: unstable Urgency: medium Maintainer: Ola Lundqvist <[email protected]> Changed-By: Ola Lundqvist <[email protected]> Description: debarchiver - tool to handle Debian package archives Closes: 755447 Changes: debarchiver (0.11.0) unstable; urgency=medium . * Input directory is added to INC to allow input.conf to be read also after perl 5.26 is released. * Allow use of command line options to vrfycmd configuration option. Closes: #755447. The change is based on a patch from Ron Lee <[email protected]>. Checksums-Sha1: 46e0dc7fb20b4de4501261b79a3017e301f5b2b5 1443 debarchiver_0.11.0.dsc bf0b487f29370d2384127cc06f328d675fe9c42d 139499 debarchiver_0.11.0.tar.gz 2f7ea3b302b2b64ef81bd2dab4e28885e261577e 71748 debarchiver_0.11.0_all.deb Checksums-Sha256: 4224f3fdd7c511ff4fdba7d3d0b6e841c2d094613fee58b4a25460e632024476 1443 debarchiver_0.11.0.dsc bcf2b8d707ddc0b6d18ce615521b87042671f0a50312c4ac0b85be47cff12bbf 139499 debarchiver_0.11.0.tar.gz 54f757152cb65f389ae43686a400f3f5092d95934328e4e566a48fe0b40032f5 71748 debarchiver_0.11.0_all.deb Files: 4f92fea5420e84f9bd026f351a779f93 1443 devel optional debarchiver_0.11.0.dsc 91deb4f6b7cc2f5c0ee6250793f435c8 139499 devel optional debarchiver_0.11.0.tar.gz 48b147fdb40de6f2a165487d92614e04 71748 devel optional debarchiver_0.11.0_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJYOzojAAoJEF6Q3PqUJodv7ggP/AiMS35Ekj349hcYLZqzUCKF JZvWAanSIekUzdSVXFgQ8dKJbwDF6MFxXHqO5EWYWJISEaqn5rNkoAt9NXeb+ztr uxm7JxMlcoH+S78uR8FM6qcH+UI3lLOlp4dBqd6nPdYAzG5ZygIiBxgUaFHDaPJY LJC9TTVBv/GygUNUBMQxH8B0QsEUZVmfwYrWjwh2jJLIqzO4SJHFJ+kru8X7Vj4V fvyDFcgWb1d3/89ZGKCKGP+Gkk7tjXzw4kKquj+uqk/N9mUASg6Xlrr4Koou/hTh q+J+iXyeqFlQFDUNop2PgpGTAFTkcYVnhcjOe97B8Y+JmnzEgC1w6+Mb6NZCpTYI kjexF0AN3YJFH/3LX8D0iKZegXtX/1KIGBUdEsYIG9KeiBvuOSVeSmpooUFRhqk4 31/WVFdwCIbS1DsOGg0cU3aw3IXj2Uz/f6wYemMW4P8/GNbiNd7MpCqZQP70bqoX cI/XnVFr7hR1xvl/Bs/NtJwnWDuT65hhFFLcHGlGESKkGS1qAFZ1rkYM8K2uOPYi plLpZ5y94d7z1kHjHcYvsdD1M7GLwIxlbv4gUOF6MiLVwiiypbXJi46uXa5bRSBF BRW2i0eWahCOzkf5upQUu/7aDS2/GoYklADWVPXG379KGTw/47nn/ishSqwcjUaL iRKUbJY7iM4DYKG3GsuU =5cdV -----END PGP SIGNATURE-----
--- End Message ---
