Your message dated Tue, 29 Nov 2016 21:20:10 +0000
with message-id <[email protected]>
and subject line Bug#754351: fixed in colormake 0.9.20140504-1
has caused the Debian Bug report #754351,
regarding Colormake not working on cross-compilers (patch included)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
754351: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754351
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: colormake
Version: 0.9-1


I was using colormake and noticed that my g++ lines weren't getting coloured 
when the compiler was anything other than plain "g++".  I'm using a few cross 
compilers, but you can test this with the mingw compiler.

Here's an example line:

    i686-w64-mingw32-g++ -Wall -O2 -g -mconsole -c main.cc

I believe the problem is in this bit of the gcc regex...

    (([[:ascii:]]+-)?g?cc|(g|c)\+\+).*)$

This matches one or more ascii's followed by dash then "cc" or "gcc", but not 
"g++".  The "|" is within the overall brackets so only allows "ascii-gcc" OR 
"g++", so non-crosscompiler "g++" lines were correctly matched.  I believe the 
fix is the addition of brackets so that gcc|cc|g++|c++ are all an atom apart 
from the [ascii] prefix.

    (([[:ascii:]]+-)?(g?cc|(g|c)\+\+)).*)$

Now "([[:ascii:]]+-)?" is one optional prefix atom and (g?cc|(g|c)\+\+)) is 
the required suffix atom, and can be any of "gcc", "cc", "g++", or "c++".

I've attached a patch that makes this change, but it's trivial enough that it 
could be done quicker by hand.
--- /usr/share/colormake/colormake.pl.bak	2014-07-09 13:39:56.000000000 +0100
+++ /usr/share/colormake/colormake.pl	2014-07-09 13:41:33.000000000 +0100
@@ -88,7 +88,7 @@
 	{
 		$in = 'make';
 	}
-	elsif ($thisline =~ s/^(\s*(libtool:\s*)?((compile|link):\s*)?(([[:ascii:]]+-)?g?cc|(g|c)\+\+).*)$/$col_gcc$1$col_norm/)
+	elsif ($thisline =~ s/^(\s*(libtool:\s*)?((compile|link):\s*)?(([[:ascii:]]+-)?(g?cc|(g|c)\+\+)).*)$/$col_gcc$1$col_norm/)
 	{
 		$in = 'gcc';
 	}

--- End Message ---
--- Begin Message ---
Source: colormake
Source-Version: 0.9.20140504-1

We believe that the bug you reported is fixed in the latest version of
colormake, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ludovic Rousseau <[email protected]> (supplier of updated colormake package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 29 Nov 2016 20:54:44 +0100
Source: colormake
Binary: colormake
Architecture: source all
Version: 0.9.20140504-1
Distribution: unstable
Urgency: medium
Maintainer: Ludovic Rousseau <[email protected]>
Changed-By: Ludovic Rousseau <[email protected]>
Description:
 colormake  - simple wrapper around make to colorize output
Closes: 754351
Changes:
 colormake (0.9.20140504-1) unstable; urgency=medium
 .
   * New upstream release
   * Fix "Colormake not working on cross-compilers (patch included)"
     fixed upstream (Closes: #754351)
   * debian/patches/12_hyphen-used-as-minus-sign removed: included upstream
   * debian/docs: upstream README renamed README.md
   * debian/compat: move from 7 to 10
   * Fix lintian vcs-field-uses-insecure-uri vcs-browser
   * Fix lintian vcs-field-not-canonical
Checksums-Sha1:
 f4e3bcf95fd5602f5ba4382f3e15afbda95d75cc 1934 colormake_0.9.20140504-1.dsc
 dbe5c6dfc0171518f28ea725b0949424344ec3ea 11855 
colormake_0.9.20140504.orig.tar.gz
 998d51c13a9834d450146ab1101420831d2a05f2 4836 
colormake_0.9.20140504-1.debian.tar.xz
 e43cb5b740eb07fc673a17702663e3a4a8c98358 10068 colormake_0.9.20140504-1_all.deb
 496c47023bd5da8f9a2d86cf112a99fbb6b1db93 5428 
colormake_0.9.20140504-1_amd64.buildinfo
Checksums-Sha256:
 cb01cee8105f7e936b0da64a492e597dcd20a60868534504cf65217e7bdb82de 1934 
colormake_0.9.20140504-1.dsc
 6b605f944df8c879cb8f6185fb0c8cfd538f27dffdf4098c0a0f034f0331a6c4 11855 
colormake_0.9.20140504.orig.tar.gz
 c9b57aab8457222ebdde2be245ca1ec8c407563900d3be226b8566a936583e3b 4836 
colormake_0.9.20140504-1.debian.tar.xz
 e81a15c44eaa68284881a9e063927a2cf04d0f9e89d46fccd2380f7e32528dd8 10068 
colormake_0.9.20140504-1_all.deb
 c40c8705c271b80fbfeb819faf9fc61c354c595d7ef621bbaa6919fefda9ce86 5428 
colormake_0.9.20140504-1_amd64.buildinfo
Files:
 8ab0761508daebfcf732118cfb203b2c 1934 devel optional 
colormake_0.9.20140504-1.dsc
 175d0a04c9a3f6756a702eb3bb2965c6 11855 devel optional 
colormake_0.9.20140504.orig.tar.gz
 8c021fb5d1a15084dd84ec5a7c7d1a34 4836 devel optional 
colormake_0.9.20140504-1.debian.tar.xz
 cd25ab6048b3241b9cd22c4b30d9bc46 10068 devel optional 
colormake_0.9.20140504-1_all.deb
 00d000ed1cb185a80e542961f139846e 5428 devel optional 
colormake_0.9.20140504-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE9eEbn/6REUb0HZU9eKG03+j5xX4FAlg9450ACgkQeKG03+j5
xX4eFQ//eAbYdMkh8Gt9us6hmXKud1X5liXjeiVKmW/62Myup0tLUwA7zlnAB/bd
0m57xyxbzccwY2wHFz0UDQFynZF8the2EecrpKHeyKCUuffRcJijJ4bQcNv8VLKV
RZF43WsF9NnCK58rqOJ10zmMUijFWdNZrcQuGx3ZeLJZDwoQp60D32u20asXjVZ2
52V/MItLyaM+mDiJm0Y3lRvASSoOkuPJN+4ZGLM4JYqusTLUQjLPBhCiEx54/tk3
ZzungT2V9CJ6CKS1qnHyB6mOdYshptBNVr2jGfqzGjfyDXJHET1NAiOVoxw4kH9k
aH1CeN+gktC1NhANLd2wNKP9m7BHMX9HUXYrgneHUWBWiyJaZJtZ690Opxz4Sw3m
KHUPUH6lUo/ZXJzREtTjHJ5EqUlwxc/kSOgG6S5TO7smM0HfQGG3TS45cEJdW0Z+
/00tQ0N1/E1Rrg7pYPNimNEpYvv0dTfEUkLIxZJufmNA3PgT4gWygHU1rjs3zFDB
F+UoGoCTl4gV5ZUZVEWHu4XLnrKNxXQPJCEWh7HTWIJcco5kMsGQtMbBBYSUErJ8
fCfAmyMZhlj+zroTr8iVdEiuV+2PYm7i2qUT34Vg8y9Hts70IrzsGdNDvrCrCyXb
IK2r7HEovWO69EA+KcMS6/bwuVeops1TKpKdNWQniPjmCM1uk8Q=
=sAbc
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to