Your message dated Thu, 01 Dec 2016 13:04:42 +0000
with message-id <e1ccr2y-000iv8...@fasolo.debian.org>
and subject line Bug#797521: fixed in ibus-table 1.9.1-4
has caused the Debian Bug report #797521,
regarding ibus-table: please make the output of ibus-table-createdb 
deterministic
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
797521: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797521
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: ibus-table
Version: 1.9.1-3
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: toolchain randomness
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Hi,

While working on the "reproducible builds" effort [0], we have noticed
that ibus-table-createdb creates output with non-determinstic output
due to Python dict ordering.

The attached patch removes this randomness from the build system. Once
applied, packages using ibus-table can be built reproducibly in our
reproducible toolchain.

 [0] https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-
diff --git a/engine/tabsqlitedb.py b/engine/tabsqlitedb.py
index 258c838..b8a858a 100644
--- a/engine/tabsqlitedb.py
+++ b/engine/tabsqlitedb.py
@@ -566,7 +566,7 @@ class tabsqlitedb:
         VALUES (:tabkeys, :phrase, :freq, :user_freq);
         ''' %{'database': database}
         insert_sqlargs = []
-        for (tabkeys, phrase, freq, user_freq) in phrases:
+        for (tabkeys, phrase, freq, user_freq) in sorted(phrases):
              insert_sqlargs.append({'tabkeys': tabkeys, 'phrase': phrase, 
'freq': freq, 'user_freq': user_freq})
         self.db.executemany(insert_sqlstr, insert_sqlargs)
         self.db.commit()

--- End Message ---
--- Begin Message ---
Source: ibus-table
Source-Version: 1.9.1-4

We believe that the bug you reported is fixed in the latest version of
ibus-table, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 797...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aron Xu <a...@debian.org> (supplier of updated ibus-table package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 01 Dec 2016 20:37:35 +0800
Source: ibus-table
Binary: ibus-table
Architecture: source
Version: 1.9.1-4
Distribution: unstable
Urgency: medium
Maintainer: IME Packaging Team <pkg-ime-de...@lists.alioth.debian.org>
Changed-By: Aron Xu <a...@debian.org>
Description:
 ibus-table - table engine for IBus
Closes: 797521
Changes:
 ibus-table (1.9.1-4) unstable; urgency=medium
 .
   [ Aron Xu ]
   * Build using Python3
 .
   [ Chris Lamb ]
   * Make the output of ibus-table-createdb deterministic (Closes: #797521)
Checksums-Sha1:
 b9d6938d9df47cd060200aeeefae65cf1442d5e8 1748 ibus-table_1.9.1-4.dsc
 02b914edaaf4dd22090d2e6e8edbd08f3c02cc52 4176 ibus-table_1.9.1-4.debian.tar.xz
Checksums-Sha256:
 683ca431f61ea20e648c8333836c0c462e443531672bfb6e7eebb7a56aac13cb 1748 
ibus-table_1.9.1-4.dsc
 c8f7880ec3cdc7c0e77a228e9aed6931d542b77c92ed96fea9447e012bc6d782 4176 
ibus-table_1.9.1-4.debian.tar.xz
Files:
 32b21884a2d20795ce613f17a14ef58d 1748 utils optional ibus-table_1.9.1-4.dsc
 66d8300959c124fe9ee12f93859b4749 4176 utils optional 
ibus-table_1.9.1-4.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJYQBnTAAoJEPbsVcVkKA0eXOIIAKF9ctW25WHwyb0mcY95RnPp
izeQPj4/+mhfLFF1vdyJEslOiKECM+slPVT9S0CcLNsxhhiznzQyVrPitBUdkaCp
YaR3Vb63If1Gy6nvhObht2We76Rq+xIvnvz3mKAV1fq1CexuIxmSnntQayuTM+Uu
Gte7zHXXsYxkBvsrpFhzJ72LNUSHtHjZyFclFNWpGor1TLIiDx/NuI8KGjeGz3wV
CeFaagxwnjMqTNbZC1K/3LvZG/j+Yn5ODGiVYaZsocyTibEhbyUYETG7Lvk6HwiC
X3UkX+OYtrmAbmYjaZwkMWNGWc+5QjZ+JPpEq91rLByFYfCIYgqqsJmguomxb/g=
=tdaA
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to