Your message dated Tue, 06 Dec 2016 18:04:30 +0000
with message-id <[email protected]>
and subject line Bug#841025: fixed in piuparts 0.73
has caused the Debian Bug report #841025,
regarding piuparts: hard links patch for bug #754878 makes little sense
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
841025: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841025
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
package: piuparts
submitter: Alexander Thomas <[email protected]>
x-debbugs-cc: Alexander Thomas <[email protected]>
Hi Alexander,
thanks for your bug report, I turned it into one so we don't loose track
of it!
On Fri, Oct 14, 2016 at 03:53:49PM +0200, Alexander Thomas wrote:
> In July 2014, a patch was included to use `cp -al` instead of `cp -ax`
> when the -e option is used and the chroot is on the same filesystem as
> where piuparts is run. I wonder why this was included without making
> it optional, or maybe why it was included at all.
a quick grep in todays piuparts for "cp -al" (and for "cp" too) reveal no hits.
can you confirm that piuparts 0.72 is affected?
> Hard-linking the chroot makes little sense unless there is a guarantee
> that none of the existing files will be modified. The only difference
> with just running the test in the provided chroot itself, is that new
> or deleted files will not be reflected in the original directory.
> Modifications to existing files however will be reflected in the
> original chroot, because of the hard links. Because the whole point of
> piuparts testing is to detect unexpected changes, at some point a
> naughty package will clobber existing files, and this change will
> persist.
> Maybe the submitter of the patch mistook `cp -al` as a copy-on-write,
> or didn't mind that this would make the -e option of piuparts
> destructive.
>
> In our setup,
could you maybe expand a little bit on this, I'm curious (and having
users is motivating!
> we perform multiple separate runs of piuparts, and it is
> essential to start from a pristine copy of the same chroot every time.
> We use the -e option to avoid having to re-generate and customize the
> chroot for every test, or unpack the same tarball over and over again.
> It is essential that the original chroot is not modified. Relying on
> hard links method breaks this workflow unless we wrap every test
> inside yet another cp -ax, which again makes everything slower.
>
> If anyone sees a valid use case for the hard linked chroot, an option
> to enable it separately should be added. Otherwise this patch should
> be reverted.
reading #754878 it tells me this code should only be used with the
--existing-chroot option.
Right now I'm too tired to actually look at the code itself… Git patches
are also much welcome too! ;-)
> --
> Alexander Thomas
Thanks again! :)
--
cheers,
Holger
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: piuparts
Source-Version: 0.73
We believe that the bug you reported is fixed in the latest version of
piuparts, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Holger Levsen <[email protected]> (supplier of updated piuparts package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 06 Dec 2016 18:14:19 +0100
Source: piuparts
Binary: piuparts piuparts-master piuparts-slave piuparts-common
Architecture: source
Version: 0.73
Distribution: unstable
Urgency: medium
Maintainer: piuparts developers team <[email protected]>
Changed-By: Holger Levsen <[email protected]>
Description:
piuparts - .deb package installation, upgrading, and removal testing tool
piuparts-common - common piuparts components
piuparts-master - piuparts master components
piuparts-slave - piuparts slave components
Closes: 841025
Changes:
piuparts (0.73) unstable; urgency=medium
.
* Add new option, --hard-link, and do *not* use it by default.
(Closes: #841025)
Checksums-Sha1:
20f42ce3b49df0eeb8b4ca0382ba09a5884267fa 1963 piuparts_0.73.dsc
4190575ea4aaca1789f04840249b9c7c1f65da34 231028 piuparts_0.73.tar.gz
Checksums-Sha256:
61cb06182576241533c546ec4fc4b65c549b90ecfa8396dd07f37b54394cbe1a 1963
piuparts_0.73.dsc
95f0fcac9d5446a0063be1f35c29d2a4177b741e14543da370cefc6e669b3725 231028
piuparts_0.73.tar.gz
Files:
4d22de5c46809f86fc11be04e5d4a51d 1963 devel extra piuparts_0.73.dsc
9f7c428a08314a4302746760ef779278 231028 devel extra piuparts_0.73.tar.gz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIVAwUBWEb21gkauFYGmqocAQpxABAAqo577PEZE7Kku3q94MONjGQyLmLkjqkQ
ucD7E9w5gGpyI8QPywnLY7ASU1aYPKIPmPkkRUOpAOL57DpAEEh+cG04f7sNZDvz
PQXDpzSjtXIW28XgRur3KZCCIn5Ad/dKSaDZqyEIGdJTN+NcPZo/naMPlyVMDXoY
VPWizmd9zz+QE7cGp5TYwxm+2ftNSgjgxjgeAgeWK93QPvLyJi457B0dUpE6ESaH
AlATi7XANGY50rq0AqGX/ivlRQqgE1RaafQPYvH/b57AmRfypgnCSJphLuPe99W6
VI2IqAiKwDPFtgot5oaKgNAHz9sVpGlJsIZfTnzoauzgjCNA+yDse+DeESyaFuei
skmMZcX1jR96rTMGSmS2UndnDZDgeAudAdqJlQ0YvUlq56ubi5YKMGHN/phUdx7H
7f45+th4Qkj4NwkIwtDpeDBk8m/g2pYf/KwrVaN9rAYhvcSD/Zj3CNNv5F1u7oHr
SdX2BhhqJuSwn61FbUUYwNh3kuK/R0xapwbALV/zXO5lNAQhzbio92RvlWFjpXq5
qCzjjDVNfIKpGD6xUbSUqQUy0Az4uUeJq4TQIs+1sbN6f9+UoLRz4NP/75b+YlaP
eZnTwf3YMsDzQtwdrpaPlaVt8UjKtEb5pcrdeI+ozF+K/RD6RXHSDb5zO2++cFfm
3/XQB8jxlAw=
=KneW
-----END PGP SIGNATURE-----
--- End Message ---
