Your message dated Sat, 17 Dec 2016 10:50:09 +0000
with message-id <[email protected]>
and subject line Bug#848280: fixed in qtltools 1.0+dfsg-2
has caused the Debian Bug report #848280,
regarding qtltools: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
848280: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848280
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: qtltools
Version: 1.0+dfsg-1
Severity: wishlist
Tags: patch upstream
User: [email protected]
Usertags: fileordering
X-Debbugs-Cc: [email protected]
Hi!
While working on the "reproducible builds" effort [1], we have noticed
that qtltools could not be built reproducibly.
It collects source files with find, which returns files in
undeterministic readdir() order, which causes object files to be linked
in the same undeterministic order.
The attached patch fixes this by sorting the files.
Regards,
Reiner
[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible_build.patch b/debian/patches/reproducible_build.patch
new file mode 100644
index 0000000..b38c78b
--- /dev/null
+++ b/debian/patches/reproducible_build.patch
@@ -0,0 +1,16 @@
+Author: Reiner Herrmann <[email protected]>
+Description: Sort source files for deterministic linking order
+
+--- a/Makefile
++++ b/Makefile
+@@ -27,8 +27,8 @@
+ BFILE=bin/QTLtools
+ HFILE=$(shell find src -name *.h)
+ TFILE=$(shell find lib -name *.h)
+-CFILE=$(shell find src -name *.cpp)
+-OFILE=$(shell for file in `find src -name *.cpp`; do echo obj/$$(basename $$file .cpp).o; done)
++CFILE=$(shell find src -name *.cpp | LC_ALL=C sort)
++OFILE=$(shell for file in `find src -name *.cpp | LC_ALL=C sort`; do echo obj/$$(basename $$file .cpp).o; done)
+ VPATH=$(shell for file in `find src -name *.cpp`; do echo $$(dirname $$file); done)
+
+ #DEFAULT VERSION (I.E. UNIGE DESKTOP RELEASE VERSION)
diff --git a/debian/patches/series b/debian/patches/series
index 825a79b..bc92ec2 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
Makefile_config.patch
Spelling_error.patch
+reproducible_build.patch
--- End Message ---
--- Begin Message ---
Source: qtltools
Source-Version: 1.0+dfsg-2
We believe that the bug you reported is fixed in the latest version of
qtltools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dylan Aïssi <[email protected]> (supplier of updated qtltools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 16 Dec 2016 22:12:04 +0100
Source: qtltools
Binary: qtltools qtltools-example
Architecture: source amd64 all
Version: 1.0+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team
<[email protected]>
Changed-By: Dylan Aïssi <[email protected]>
Description:
qtltools - Tool set for molecular QTL discovery and analysis
qtltools-example - Tool set for molecular QTL discovery and analysis - example
Closes: 848280
Changes:
qtltools (1.0+dfsg-2) unstable; urgency=medium
.
* Add a patch to fix reproducible builds. (Closes: #848280)
(Thanks to Reiner Herrmann <[email protected]>)
Checksums-Sha1:
f991fcbc0ffe1949a563d3e7f4dd19a524777fd1 2215 qtltools_1.0+dfsg-2.dsc
bd26ea18c033e40deba7e8020731bc36863d78d4 13555832
qtltools_1.0+dfsg-2.debian.tar.xz
d13be60fc8eebaae7826ab89bb7815edb975a166 81156398
qtltools-dbgsym_1.0+dfsg-2_amd64.deb
8e8fc18fcecff13b7cf1f6e7bc356e2db9e2b430 13556284
qtltools-example_1.0+dfsg-2_all.deb
296bdc899cbfc6454a1e860130a6021efabebed3 6882
qtltools_1.0+dfsg-2_amd64.buildinfo
72ce19bc2712d70ff62d48737e9268bde2ca2461 694056 qtltools_1.0+dfsg-2_amd64.deb
Checksums-Sha256:
d78f38bb62945ab17afe597502422c8e81a07efb5a477475e61e8be0ed78216c 2215
qtltools_1.0+dfsg-2.dsc
da0f42f8a3743fac2678acf96e8d4c06c8725a1bd103ffa65ca3608a383c0211 13555832
qtltools_1.0+dfsg-2.debian.tar.xz
ee5544ba81e467edafdeb5f81fe04f1ccb237ce8b8356a3c1fb4fd99694effe8 81156398
qtltools-dbgsym_1.0+dfsg-2_amd64.deb
3e367828f0378d3e93942d974bafb3a727f3c8430f006704eb6c3f03b7590e0d 13556284
qtltools-example_1.0+dfsg-2_all.deb
4f610c7a6205a41300c9f6ac65af41110e881728d9198e333ade2e2459253bd3 6882
qtltools_1.0+dfsg-2_amd64.buildinfo
cf2c65581a368d49d53be24b67cfbb9cc1503982b38223948e67f4caf1ad849c 694056
qtltools_1.0+dfsg-2_amd64.deb
Files:
46737bf8be7ab4185f5130fc7a9b50e5 2215 science optional qtltools_1.0+dfsg-2.dsc
cc250062711ec8112de6e23dace79544 13555832 science optional
qtltools_1.0+dfsg-2.debian.tar.xz
21c1c56be0a4cba863ea35ce8398376d 81156398 debug extra
qtltools-dbgsym_1.0+dfsg-2_amd64.deb
0ff0f2e75abb0a4e2d0ac92c84ef6a6f 13556284 doc optional
qtltools-example_1.0+dfsg-2_all.deb
f06c80fde33545ed5004144f4496d542 6882 science optional
qtltools_1.0+dfsg-2_amd64.buildinfo
bf071133fb9c1a1b68183a36f1b51956 694056 science optional
qtltools_1.0+dfsg-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCAAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAlhVCUURHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtECBxAAnBIjJn+WMrOtFuq2hP1g1rB9g+DgHoHF
i6cTEtweiZJDfEhzcK/Wm1MC9fJvOHdVlb5rEDncsF1/Uqwmr3XAUed8hslS+HUR
p6lu82AZYzf4FuE5yh8YJgLE1t71VmE3gKFUM+djd6uI99ffLR6EHO+FWpMa9dPK
7CS/CZedPSgEKzOwEkcOQYMY0f3tf/lVoOyGJx+cxxohfr4W/vTjQggM3tNyeqdd
63mpFw/GiegNxu8EhFjXP0N+yKQGv7qvk527AxvopHOBawuDSznXARTod56Doz5Z
nFhSgqw+l2s0V2frDFvfpEToIOuJabOQT5JHyxN1+yKN90vFzEKBzga1+fvWNsLH
xAPLLzxAEY3fY2a98ttI5l6n6yxSjvxRRHaABXkl0RvZ6s4qG0oGgLVJMh/LN2tn
YELm/SFOAQMAFcEoF3kF3+F6c4A/Y0QW5ZPuuYAoAz5vFq8f2KK03LoCcR/Yrqg0
1p89UBzKU1lWTClxHsEcv8fcLjCoPmR2Qp9oaAvCdsErrfVkDwxip8b54q053Y9j
OBvtLzHtTTu2OSFbQA3bDc9vd9WvHOrD68hFrRSTnjCByZSFYZDqE3LBsWPYxltG
DfkT/gytTd5d/QTa9o4qYKqL4Ti4JA9e2WypoiF9RqEpFfevqqaMXMpWhKbsrupV
BFn8Uq++AoI=
=FueM
-----END PGP SIGNATURE-----
--- End Message ---
