Your message dated Sat, 17 Dec 2016 14:17:16 +0100
with message-id <[email protected]>
and subject line Re: Bug#749598: atop: atopsarflags handling is broken
has caused the Debian Bug report #749598,
regarding atop: atopsarflags handling is broken
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
749598: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749598
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: atop
Version: 1.26-2
Usertags: goto-cc
During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.
[...]
cc atop.o version.o various.o deviate.o procdbase.o acctproc.o photoproc.o
photosyst.o rawlog.o ifprop.o parseable.o showgeneric.o showlinux.o
showsys.o showprocs.o atopsar.o -o atop -Wl,-z,relro -lncurses -lm -lz
error: conflicting function declarations "do_atopsarflags"
old definition in module atop file atop.c line 376
void (char *, char *)
new definition in module atopsar file atopsar.c line 1043
void (char *val)
Makefile:28: recipe for target 'atop' failed
make[1]: *** [atop] Error 64
make[1]: Leaving directory
'/srv/jenkins-slave/workspace/sid-goto-cc-atop/atop-1.26'
dh_auto_build: make -j1 returned exit code 2
debian/rules:4: recipe for target 'build' failed
make: *** [build] Error 2
Reviewing the code, this is indeed a major problem rather than an issue of
excess arguments only: the calling convention here
http://sources.debian.net/src/atop/1.26-2/atop.c?hl=1034#L1034
will result in do_atopsarflags always being called with "atopsarflags" as value
string. Consequently first case 'a' will be taken, and then the default case
will be picked, repeatedly, for the remaining characters.
http://sources.debian.net/src/atop/1.26-2/atopsar.c?hl=1082,1093#L1082
Best,
Michael
pgpGrGPxzH0KU.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Version: 2.2.4-1~exp1
closing as promised.
Greetings
Marc
On Tue, Oct 25, 2016 at 09:27:44AM +0200, Marc Haber wrote:
> From: Marc Haber <[email protected]>
> Subject: Bug#749598: atop: atopsarflags handling is broken
> To: Michael Tautschnig <[email protected]>, [email protected],
> [email protected]
> Reply-To: Marc Haber <[email protected]>,
> [email protected]
> Date: Tue, 25 Oct 2016 09:27:44 +0200
> User-Agent: Mutt/1.5.23 (2014-03-12)
>
> Hi,
>
> On Wed, Aug 10, 2016 at 05:52:44PM +0200, Marc Haber wrote:
> > can you please recheck with the latest version of atop from
> > experimental? Thanks!
>
> I have uploaded one more new version to experimental. I will close
> this bug by the end of November 2016 unless I know that this bug still
> applies.
>
> Greetings
> Marc
>
> --
> -----------------------------------------------------------------------------
> Marc Haber | "I don't trust Computers. They | Mailadresse im Header
> Leimen, Germany | lose things." Winona Ryder | Fon: *49 6224 1600402
> Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
--
-----------------------------------------------------------------------------
Marc Haber | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany | lose things." Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
--- End Message ---
