Your message dated Sun, 25 Dec 2016 15:18:59 +0000
with message-id <[email protected]>
and subject line Bug#660614: fixed in logtools 0.13e
has caused the Debian Bug report #660614,
regarding add way to quiet "Skipping bad line" cron spam
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
660614: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=660614
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: logtools
Version: 0.13d
Severity: normal
Tags: patch
Hi,
We're processing several GB of logs daily with clfmerge, thanks for the useful
tool! However one problem: the logs daily contain say one or two truncated
lines which trigger a "Skipping bad line" warning.
We're really missing a way to ignore this - now we get daily cron spam about
this while it's not a problem. I've implemented attached 'verbose' option,
which only outputs that warning when -v is passed to clfmerge. Would you
be willing to apply it?
(BTW: I encountered some deprecation and lintian warnings while building
the package which you may want to look into.)
thanks,
Thijs
-- System Information:
Debian Release: 6.0.4
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -Nru logtools-0.13d/changes.txt logtools-0.13d+uvt1/changes.txt
--- logtools-0.13d/changes.txt 2008-06-06 07:35:00.000000000 +0200
+++ logtools-0.13d+uvt1/changes.txt 2012-02-20 09:31:16.000000000 +0100
@@ -1,3 +1,9 @@
+logtools (0.13d+uvt1) unstable; urgency=low
+
+ * Add verbose option.
+
+ -- Thijs Kinkhorst <[email protected]> Mon, 20 Feb 2012 09:31:03 +0100
+
logtools (0.13d) unstable; urgency=low
* Merged changes from NMU and fixed some more GCC 4.3 warnings.
diff -Nru logtools-0.13d/clfmerge.1 logtools-0.13d+uvt1/clfmerge.1
--- logtools-0.13d/clfmerge.1 2001-09-20 15:35:44.000000000 +0200
+++ logtools-0.13d+uvt1/clfmerge.1 2012-02-20 09:32:57.000000000 +0100
@@ -3,7 +3,7 @@
clfmerge \- merge Common\-Log Format web logs based on time\-stamps
.SH "SYNOPSIS"
-.B clfmerge [\-\-help | \-h] [\-b size] [\-d] [file names]
+.B clfmerge [\-\-help | \-h] [\-b size] [\-d] [\-v] [file names]
.SH "DESCRIPTION"
The
@@ -67,6 +67,10 @@
which allows programs like Webalizer to produce good graphs for large hosting
sites. Also it will make the domain name in lower case.
+.TP
+.B \-v
+Be more verbose.
+
.SH "EXIT STATUS"
.B 0
No errors
diff -Nru logtools-0.13d/clfmerge.cpp logtools-0.13d+uvt1/clfmerge.cpp
--- logtools-0.13d/clfmerge.cpp 2008-06-06 07:32:58.000000000 +0200
+++ logtools-0.13d+uvt1/clfmerge.cpp 2012-02-20 09:32:54.000000000 +0100
@@ -41,6 +41,8 @@
int getLine();
bool valid() const { return m_valid; }
+
+ bool verbose;
private:
bool m_valid;
@@ -164,7 +166,7 @@
m_valid = true;
return 0;
}
- fprintf(stderr, "Skipping bad line: %s\n", m_line);
+ if ( verbose ) fprintf(stderr, "Skipping bad line: %s\n", m_line);
}
return 0; // to make compilers happy - will not be reached
}
@@ -188,7 +190,7 @@
void usage(const char *const arg)
{
- fprintf(stderr, "usage: %s [filenames]", arg);
+ fprintf(stderr, "usage: %s [OPTION] [filenames]", arg);
fprintf(stderr, "\n"
"This program merges web logs in common log format into a single stream\n"
"on standard output. It reads from multiple input files and outputs the\n"
@@ -205,10 +207,10 @@
return 0;
unsigned int map_items = 0;
- bool set_map_items = false, domain_mangling = false;
+ bool set_map_items = false, domain_mangling = false, verbose = false;
int int_c;
optind = 0;
- while(-1 != (int_c = getopt(argc, argv, "b:hd")) )
+ while(-1 != (int_c = getopt(argc, argv, "b:hdv")) )
{
switch(char(int_c))
{
@@ -223,6 +225,8 @@
break;
case 'd':
domain_mangling = true;
+ case 'v':
+ verbose = true;
break;
}
}
@@ -248,6 +252,7 @@
for(i = optind; i < argc; i++)
{
items[item_count] = new LogFile;
+ items[item_count]->verbose = verbose;
int rc = items[item_count]->open(argv[i], domain_mangling);
// if rc==2 then file not found, if rc==1 then 0 length file
if(rc > 1)
diff -Nru logtools-0.13d/debian/changelog logtools-0.13d+uvt1/debian/changelog
--- logtools-0.13d/debian/changelog 2008-06-06 07:35:00.000000000 +0200
+++ logtools-0.13d+uvt1/debian/changelog 2012-02-20 09:31:16.000000000 +0100
@@ -1,3 +1,9 @@
+logtools (0.13d+uvt1) unstable; urgency=low
+
+ * Add verbose option.
+
+ -- Thijs Kinkhorst <[email protected]> Mon, 20 Feb 2012 09:31:03 +0100
+
logtools (0.13d) unstable; urgency=low
* Merged changes from NMU and fixed some more GCC 4.3 warnings.
--- End Message ---
--- Begin Message ---
Source: logtools
Source-Version: 0.13e
We believe that the bug you reported is fixed in the latest version of
logtools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Russell Coker <[email protected]> (supplier of updated logtools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 26 Dec 2016 02:11:11 +1100
Source: logtools
Binary: logtools
Architecture: source amd64
Version: 0.13e
Distribution: unstable
Urgency: medium
Maintainer: Russell Coker <[email protected]>
Changed-By: Russell Coker <[email protected]>
Description:
logtools - Russell's misc tools for managing log files.
Closes: 437492 660614 849126
Changes:
logtools (0.13e) unstable; urgency=medium
.
* Fixes build problems with latest STL. Closes: #849126
* Added patch from Thijs Kinkhorst <[email protected]> for "verbose" mode
in clfmerge. Closes: #660614
I wrote a similar change for clfdomainsplit.
* Made DEB_BUILD_OPTIONS=nostrip work. Closes: #437492
Checksums-Sha1:
0314b071476e58ef3e1eb71ffbcdbe9badcd6715 1387 logtools_0.13e.dsc
4d989b1d9ec776467636fbe81e85753b703d2997 62468 logtools_0.13e.tar.gz
f2ab4dd78035b01ce5199635555c6d1f8cb4ecad 174412 logtools-dbgsym_0.13e_amd64.deb
146b48bba16198a3235f04002dc0aff538f34620 4751 logtools_0.13e_amd64.buildinfo
87ab02d7ad3cbe87ab5d7467a62be04870168106 33082 logtools_0.13e_amd64.deb
Checksums-Sha256:
79cfb4414d007592c34267245c2eb2a085c8f0d62f8666150765c733fcacfafc 1387
logtools_0.13e.dsc
919fe52497dad6783ad5e07f8b7bff596a486c7a24e00b005304007b6b54949b 62468
logtools_0.13e.tar.gz
e9700921396d69cc714472d710f69c30a26fa669e24578524b66e6f64433c541 174412
logtools-dbgsym_0.13e_amd64.deb
5e136247269f7083806c2a2c1723c81a04846c9132e58eae16cf61e3b792e275 4751
logtools_0.13e_amd64.buildinfo
f626c9f8a0fbbbd0473122621b062385883dc7fac1cdea84584cbc5784e0bf00 33082
logtools_0.13e_amd64.deb
Files:
8598b6268ba86b8f3f22cae34f56dec6 1387 admin optional logtools_0.13e.dsc
2b4e1c418981e8440ce0af1616c7644d 62468 admin optional logtools_0.13e.tar.gz
6bde1f9d544fb9debe41d257a9c010c8 174412 debug extra
logtools-dbgsym_0.13e_amd64.deb
e29749445214d2764335d345d0c0f86d 4751 admin optional
logtools_0.13e_amd64.buildinfo
95ffa258cd58e82931172c883be7d710 33082 admin optional logtools_0.13e_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEn31hncwG9XwCqmbH0UHNMPxLj3kFAlhf4bAACgkQ0UHNMPxL
j3nHOw//VqQuS5DbGb9WoD5rnTfzTSip3e2tuoI+iHPAQZZCjx4WyRbZh3GFKV2F
t9DhCcom7uVt27GmALNs477feMIcuux4CahnqGBesaTdPw4y+/LaW6kEkJEvlbqC
8l597HDEBM1QK9cBTXSEI3UbZh2adu2vWOOIx2KWyeq+jVnupukKglcDDyMaiY9z
6J9M46+tIS/4njruUbsoBOzM5Crpby1yHMAGp6xpB6j9kiKjxtKf7A2o60iseZ0k
91e3IOhi8gH/D7FvB0nUKYU9BJn/26liRAxw6ZFjytFHJ3V/duDakBwYEDvqMQfx
KLOYZzP8x3L6nHBil+un7lV6iOaTamsoV/Ix9EQ0Uo1kFb6oCivRf4FB9IvavrPU
EWXC8x38YIZEm9n+d3Dt+txIWnChS2nIZjV1hlJwwK13Sn6ejlsx33Xn9dNPR5cC
PcqFUZ8EadP8zGAlBSvXuYfBSfJcysu6G2jzweWfwuX0liEREC9Q3HxF224b9Um1
CE1v0nulVcYlb6TWwTiYeOsdZ1FkQpzt7RhNPRxClPkmZzH6t0YbNR99rSKMtAGz
DbBNQTtJZVp/jsFYfgVkRjRxFfvd5riTks+Fxrh8NUxjqKR2D8VD4D2LUUXvKXth
nIFkRkKEHZZtadmVLV4hqLaeTvyWt/togjFE57pJpkj+CIHPXiE=
=0gte
-----END PGP SIGNATURE-----
--- End Message ---
