Your message dated Fri, 20 Jan 2017 12:34:20 +0000
with message-id <[email protected]>
and subject line Bug#850478: fixed in git-buildpackage 0.8.11
has caused the Debian Bug report #850478,
regarding git-pbuilder deliberately deletes source.changes
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
850478: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850478
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: git-buildpackage
Version: 0.8.9
Severity: important
X-Debbugs-Cc: Debian pbuilder maintenance team
<[email protected]>
Disclaimer: These views are my own and not necessarily shared with
Mattia; he has the final say with regards to pbuilder :)
Hi,
Currently, straight after git-pbuilder invokes pdebuild, it deletes
../*_source.changes, provided there is at least one such file, and the
build was not done with -S. This causes two problems:
1. It ignores version numbers and package names, causing potential data
loss, which I feel is justification enough for the Severity: important.
While it's a data loss bug, I don't think it's major enough to be RC.
(Please clone this if you want to separate this bug from the point
below...)
2. I like being able to perform source-only uploads. While you can get
pbuilder to generate a source-only changes file for a source+binary
build with --changes-option=-S, this has the unfortunate side-effect
of not copying back the .deb files, since they aren't referenced by
the .changes. Also, the changes file is _arch.changes, which is
misleading, and having the real _arch.changes is useful. Thus, I
would like to have a --source-only-changes option which functions
like sbuild (the main dpkg-buildpackage invocation generates
_arch.changes, and then a manual dpkg-genchanges --build=source is
performed) so that users can get both from one build.
In looking into this, I discovered that pdebuild itself actually
ends up producing a _source.changes, since it calls
dpkg-buildpackage -S to generate the dsc to copy into the chroot. I
presume that the original intention of the deletion performed by
git-pbuilder was to delete *this* changes file, since the dsc
subsequently produced by the build inside the chroot will not be
identical, but is copied back as part of the build, making the
original _source.changes invalid.
Now, I'm of the view that dpkg-source -b should be used instead,
which is what sbuild uses to create the dsc. This also has the
advantage of not generating .buildinfo files (no annoying
debian/files lingering after the build, either). Then the only
_source.changes generated by pbuilder would be if the user requested
it, and therefore having it deleted by git-pbuilder would be wrong.
I should think changes like this are too late for Stretch, but
perhaps for Buster (or experimental?) we could coordinate our
efforts to get this to work?
This is not just hypothetical, either; I actually have patched
git-pbuilder[1] and pbuilder to implement this, but the implications
of the switch to dpkg-source -b would need to be discussed
I appreciate this is a lot of irrelevant details, but I hope by
explaining where we are and where I'd like to get to makes the issues
clear. A lot of this will end up going into a bug report against
pbuilder blocked by this tomorrow.
Regards,
James
[1] Commented out the 3-line if statement that deletes _source.changes
--- End Message ---
--- Begin Message ---
Source: git-buildpackage
Source-Version: 0.8.11
We believe that the bug you reported is fixed in the latest version of
git-buildpackage, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Guido Günther <[email protected]> (supplier of updated git-buildpackage package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 20 Jan 2017 12:54:40 +0100
Source: git-buildpackage
Binary: git-buildpackage git-buildpackage-rpm
Architecture: all source
Version: 0.8.11
Distribution: experimental
Urgency: medium
Maintainer: Guido Günther <[email protected]>
Changed-By: Guido Günther <[email protected]>
Closes: 820846 848354 850478 851645 851844
Description:
git-buildpackage-rpm - Suite to help with RPM packages in Git repositories
git-buildpackage - Suite to help with Debian packages in Git repositories
Changes:
git-buildpackage (0.8.11) experimental; urgency=medium
.
* [8bd74df] command_wrappers: Simplify RunAtCommand
* [1140886] buildpackage: Don't set a compression level if unset and make
this the default. This allows compressors to use the their default
compression level. Only applies when not using pristine-tar.
Thanks to Antoine Beaupré for investigating (Closes: #820846)
* [0fdff8e] buildpackage: Use commit instead of tree to create archive.
This makes sure we use the timestamps of the commit when creating the
tarball. Only applies when not using pristine-tar
Thanks to Ximin Luo for investigating (Closes: #851645)
* [3f4b9f8] make: Check if we can use parallel flake
* [534c055] git-pbuilder: Don't remove changes file (Closes: #850478)
* [b863399] pull: Allow to specify remote on the command line
(Closes: #851844)
* [d3cb4db] gbp-posttag-push: add missing dry-run for debian branch push
* [f9a7640] buildpackage: verify generated tarballs when using pristine-tar
* [b8ea662] pq: Hardcode commit abbrev to 7 when exporting patches.
This avoids path churn with git >= 2.11.0 (Closes: #848354)
* Test suite enhancements
Checksums-Sha1:
6074e0e5b86dce6d5535c1d80bda23af5699ec65 2171 git-buildpackage_0.8.11.dsc
de24444a542486315eddf0651ce829938f1e9860 1721648 git-buildpackage_0.8.11.tar.xz
10121ea4c24484ad3ddcb3923d250d66574b4743 103170
git-buildpackage-rpm_0.8.11_all.deb
2dbb931a8d4bce140c80555c078d0110b39a52f8 345788 git-buildpackage_0.8.11_all.deb
Checksums-Sha256:
fbecf4caa7405466343617a53e5c0732b5c0f2dd82f00f56ce1d88d9ac70640d 2171
git-buildpackage_0.8.11.dsc
b87487863eeb2ae11d5365e11064cb0603adc5f9f100661adc185146cbf6dd98 1721648
git-buildpackage_0.8.11.tar.xz
aced2d13b231079def7b3d2ef7efd195a50da5759f4afc53003c6def01e6737c 103170
git-buildpackage-rpm_0.8.11_all.deb
3c98e4c4442a0593bae4b0951050249fc7dd9f9ac235505b3ff8d678601422db 345788
git-buildpackage_0.8.11_all.deb
Files:
b02ca93380fb3b15bed85ec994afaa60 2171 vcs optional git-buildpackage_0.8.11.dsc
5e5984351fb2ba377dcc45cd1d5ea60b 1721648 vcs optional
git-buildpackage_0.8.11.tar.xz
a17f8e2c5a27b147576e723764a35681 103170 vcs optional
git-buildpackage-rpm_0.8.11_all.deb
5dbc82683b5baf52d7def19d82d3460c 345788 vcs optional
git-buildpackage_0.8.11_all.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEvHzQcjh1660F3xzZB7i3sOqYEgsFAliCAEMACgkQB7i3sOqY
EgtnDg//QVrejaS/xXMspxWXzXyiyItyBjZu4uhp1OMK6kRuB+EMPFPBDM0pvMfg
BSynfRX5yYAAF98rod1rMIoXsTJD3Bq8Rx9Vu8cuuQ7CZBscRcUqBaNM5KcpC4F2
3JZXy7eyP6r1/JGAPWPr4nZl7gEBFYVVZQ2SelDGoQRb4YV0z3BfYicVW5QpdkWL
AWurqN//l46cQzhq+LLu9CLWDz/XNzXxsPu5MWb7wYR+ckwCWF3PN39iZLvVkZu+
YkHYWfoNI9UUGAX///7h4U7h6g3rNQQft2ehDtMYk5d0tbig8u6bqHzoswfnc/lr
1OG8XBzPKGP8J7r6J7fM34Ok8TNax7ASWdDWPFKAbbl8rJN6U5k98100DM9fTDtU
IDcvRL54Ktfvn7PmDFzJmlhIqgoBCPREFUP/8gqLzcWUCgfwdevbi5qAQvFg82PR
LKkOB9hWl9DMnl4XNp+XKVoTXJUuG/HooYf9EVV9vdiyHJrJPyWAKbJtZAvaTron
JWcxQgbZ2MQa8VnmycQJoi7toyNWDHjWtghhlsViySNmLiVqlGQKh65roHoI0eAo
zLF5DSK2jwEptmR5jasM/kG9rsREnQQ0R5zbKFSfQXHNr3fsD311rTu+ZkD5iaFW
lh99W/RLohpWvUOim9WpuWhoXIlDnsAiR9sw4UeFxZi5y9k7mE4=
=SKQy
-----END PGP SIGNATURE-----
--- End Message ---
