Your message dated Mon, 23 Jan 2017 00:20:20 +0000 with message-id <[email protected]> and subject line Bug#764625: fixed in xen-tools 4.7-1 has caused the Debian Bug report #764625, regarding xen-tools: no gateway in /etc/network/interfaces to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 764625: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764625 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: xen-tools Version: 4.4-1 Severity: wishlist Tags: patch This is fixed in git in commit 079382302ba0fd6bb22d5ca8d502eaa4c0ac1730 but I don't see it in the BTS. Is everybody using the git version? Anyway, the current code uses the variable "gateway" for two different things, namely, the ip of the gateway and the complete line to be written in /etc/network/interfaces. In general, I consider bad coding style that the same variable is used for two different things (even if they are related). So, I would propose something like this instead, which, by looking at the "bcast" variable, maybe it's a little bit closer to what the programmer had in mind when this bug was introduced. diff --git a/xen-tools-4.4/hooks/common/40-setup-networking-deb b/xen-tools-4.4/hooks/common/40-setup-networking-deb index 162d0b2..c25d049 100755 --- a/xen-tools-4.4/hooks/common/40-setup-networking-deb +++ b/xen-tools-4.4/hooks/common/40-setup-networking-deb @@ -88,9 +88,9 @@ setupStaticNetworking () # # gateway address? # - gateway=''; + gway=''; if [ -n "${gateway}" ]; then - gateway=" gateway ${gateway}" + gway=" gateway ${gateway}" fi # @@ -108,7 +108,7 @@ iface lo inet loopback auto eth0 iface eth0 inet static address ${ip1} -${gateway} +${gway} netmask ${netmask} ${bcast} ${point} Thanks.
--- End Message ---
--- Begin Message ---Source: xen-tools Source-Version: 4.7-1 We believe that the bug you reported is fixed in the latest version of xen-tools, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Axel Beckert <[email protected]> (supplier of updated xen-tools package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 23 Jan 2017 00:39:11 +0100 Source: xen-tools Binary: xen-tools Architecture: source all Version: 4.7-1 Distribution: unstable Urgency: medium Maintainer: Axel Beckert <[email protected]> Changed-By: Axel Beckert <[email protected]> Description: xen-tools - Tools to manage Xen virtual servers Closes: 764625 776487 842609 Changes: xen-tools (4.7-1) unstable; urgency=medium . * New upstream release + release-testing: Several enhancements, race condition avoidance, … + Fixes reported error code in case of subcommand failure (Reported and fixed by Yuri Sakhno, thanks!) + Fixes typo found by lintian. + Support for Ubuntu 16.10 Yakkety Yak. + Preliminary support for Ubuntu 17.04 Zesty Zapus. + Knows future Debian release names Buster (10) and Bullseye (11). + Knows about Ubuntu's "devel" alias. + Risen default values for RAM sizes in /etc/xen-tools/xen-tools.cfg to cope with risen resource consumption and availability. (Closes: #776487) + Default file system is now ext4 (instead of ext3). + Fixes inconsistent/non-functional handling of --nopygrub parameter. Thanks Daniel Reichelt for the bug report and patch! (Closes: #842609) + Fixes possible missing gateway in generated /etc/network/interfaces. (Closes: #764625) + Support situations where distributions (e.g. Squeeze) might be EoL, but its archive signing key is still not removed from the default keyring. + Workaround LVM related race condition when using --force with LVM. * Declare compliance with Debian Policy 3.9.8. (No changes needed.) * Use NEWS.markdown as upstream changelog, don't install it as docs. * Switch many URLs (upstream and in packaging) to https:// and update URLs where they were broken or redirect somewhere else now. * Fix some typos in older debian/changelog and debian/NEWS items. Checksums-Sha1: 9c193b3ce8c994bb740e26f060ab9eab71b1da5c 2189 xen-tools_4.7-1.dsc ed088c2f3366536a6b7286814a4860c15be44eba 255819 xen-tools_4.7.orig.tar.gz d19d5ba5b6d0bf19f2601f838cf193f481094d86 25684 xen-tools_4.7-1.debian.tar.xz 27746cd9ff306e0bad41cf1d2d35f12d1197f116 137300 xen-tools_4.7-1_all.deb 67b158a9fa6e56184b4e831c60fe107b8022ff05 6234 xen-tools_4.7-1_amd64.buildinfo Checksums-Sha256: 4c00a7b65fe0fb5a555289586d7ef3b953f97e6512066124338a58d786a31523 2189 xen-tools_4.7-1.dsc 4c570c29a2dd5a68c6ecf9bbc0b83e6a680d7a61457dfb85fca3c0ac8d32edee 255819 xen-tools_4.7.orig.tar.gz 862b5cf05720afb131f0ad48c52c540f7cfb638c6f0afad1d2fe4bbcff9fd73c 25684 xen-tools_4.7-1.debian.tar.xz 19cb6bf1aebffdf4dce4b3f81fa64c75a537270b04c517e78a32f34a8637b944 137300 xen-tools_4.7-1_all.deb 0fe47b95158cc3519ca39781678d2c45b8b55d1d9d8da62c7c0f67a37362c177 6234 xen-tools_4.7-1_amd64.buildinfo Files: 1ec67c0d7a4d89941f652ffdc2055dee 2189 utils extra xen-tools_4.7-1.dsc fd5eaf978068fbc9fafe8e7a99603b31 255819 utils extra xen-tools_4.7.orig.tar.gz b646cbc0dc4c3a728fd5c3d5b53dd1b5 25684 utils extra xen-tools_4.7-1.debian.tar.xz f874cdf07ce963e76216df25cbb70d90 137300 utils extra xen-tools_4.7-1_all.deb d39c9a937875a437fb5624415ecd7277 6234 utils extra xen-tools_4.7-1_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEERoyJeTtCmBnp12Ema+Zjx1o1yXUFAliFRLYACgkQa+Zjx1o1 yXXaNg/+Le902q66A0PW6ydbF3vFITiZI3DIXgIpZ0nG0hrcD2IvyDo3LhcjdaqB z+0JgY/y5JIwTWgmsTmpAysFZNqKFFTcpcE3MxjEDIHnKa+arztzXrj7rZbH7IW7 pS4S0jBWyDySjhK8NilH5wInWUArsoanc8Bd8UAktlqJ1hqQAZSyJQa3CbjmMVH/ MTOP6MRAXjshSsSGEms32y7QA6dG5YYUiJf/morq4IOAL0O+q2A/3Z6x0840IWym MvarPhNyz0eRdMItOaI3vFFXWKvq+g0OhdPdySX/70sNDo7qHIlIPq0l20FXW1q0 QuUurnAJ74hw2HJVZE51c+5ptsqoiEjTgGXm3OjqKprT40G1qaBbu0PJMa78JINJ As1qOpPlNQVd8CjhsGQSYUAGQD89fR9GAo7M/f/v7YJpoOa17b+28vA5R94pEAq8 8p5VJ8aaEl5d8tT/cbhXXxL+JE9fxqVYHhvnos4khtALlKflqGSPBY5+jJE5HC5P eoaZZ4bI6IPbjDhXVkWMNvoWoPC/xs5zj2ZUAaJS9+j3bXfa5MHQMFtKvXNXxfEM Iv1qC/3ZvHLxht6hPtrAra0alTveMT3MJtLq1PCMF3nUuOR23VNBAntQZYh66G2B GUnjIrxUHFFOiI6s66No/kZ99GeikvjtoCpLKLZhPmkzUq1e2hI= =RnPG -----END PGP SIGNATURE-----
--- End Message ---
