Your message dated Wed, 22 Feb 2017 14:50:04 +0000 with message-id <[email protected]> and subject line Bug#855054: fixed in nagios-plugins-contrib 21.20170222 has caused the Debian Bug report #855054, regarding nagios-plugins-contrib: check_raid does not properly report failed spare to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 855054: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=855054 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: nagios-plugins-contrib Severity: normal Tags: upstream patch Dear Maintainer, it seems that the check_raid plugin has trouble reporting a failed spare. In this case it, in fact, reports an internal error instead. Consider this example mdstat output: md1 : active raid1 sdc1[0] sdh1[5](F) sdg1[4] sdf1[3] sde1[2] sdd1[1] 1953382400 blocks super 1.2 [5/5] [UUUUU] bitmap: 2/15 pages [8KB], 65536KB chunk md0 : active raid1 sda1[0] sdb1[1] 124967936 blocks super 1.2 [2/2] [UU] bitmap: 1/1 pages [4KB], 65536KB chunk It seems that sdh1 in array md0 failed. It is a spare, so the next line ('U's) stays unchanged. The failure is detected by the check_raid plugin, but when trying to report this case, it fails with a runtime error: $ ./check_raid -p mdstat Can't use an undefined value as an ARRAY reference at ./check_raid line 3663. Apparently, this line in the if-branch regarding hot-spare failures references an unknown field in the md hash, not returning the correct array. I was able to fix the problem using the attached patch. After applying the patch, I get: $ ./check_raid -p mdstat WARNING: mdstat:[md1(1.82 TiB raid1):hot-spare failure:sdh1:UUUUU, md0(119.18 GiB raid1):UU] which looks more like what I would expect. Please note that I can't comment on the behaviour of one of the disks in the array failing (as I haven't had that yet), but I'm assuming the corner case of a failing spare simply hasn't been on the radar. This issue was noticed in the current backports version (20.20170118~bpo8+1) but also seems to be present in unstable. Upstream might be interested as well. Kind regards Saschadiff --git a/check_raid/check_raid b/check_raid/check_raid index 33e724e..9969954 100644 --- a/check_raid/check_raid +++ b/check_raid/check_raid @@ -3660,7 +3660,7 @@ $fatpacked{"App/Monitoring/Plugin/CheckRaid/Plugins/mdstat.pm"} = '#line '.(1+__ } elsif (@fd > 0) { # FIXME: this is same as above? $this->warning; - $s .= "hot-spare failure:". join(",", @{$md{failed_disks}}) .":$md{status}"; + $s .= "hot-spare failure:". join(",", @fd) .":$md{status}"; } else { $s .= "$md{status}";
--- End Message ---
--- Begin Message ---Source: nagios-plugins-contrib Source-Version: 21.20170222 We believe that the bug you reported is fixed in the latest version of nagios-plugins-contrib, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Bernd Zeimetz <[email protected]> (supplier of updated nagios-plugins-contrib package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Wed, 22 Feb 2017 14:32:22 +0100 Source: nagios-plugins-contrib Binary: nagios-plugins-contrib Architecture: source amd64 Version: 21.20170222 Distribution: unstable Urgency: medium Maintainer: Debian Nagios Maintainer Group <[email protected]> Changed-By: Bernd Zeimetz <[email protected]> Description: nagios-plugins-contrib - Plugins for nagios compatible monitoring systems Closes: 772278 851351 855054 855155 855253 Changes: nagios-plugins-contrib (21.20170222) unstable; urgency=medium . [ Bernd Zeimetz ] * [5091e4a] Disable EPN for check_raid. Thanks to Daniel Pocock (Closes: #851351) * [5bdff51] check_raid: fix failed mdadm hotspare detection. Thanks to Sascha Steinbiss (Closes: #855054) * [5232be1] percona-nagios-plugins: fix bashism. Thanks to Raphael Geissert (Closes: #772278) . [ Stefan Schörghofer ] * [6495faa] Fixes check_ssl_cert problems with Openssl > 1.1.x (Closes: #855253) . [ Bernd Zeimetz ] * [bf4fb49] Add autopkgtest for check_ssl_cert. * [9aacdb6] Auto update of debian/tests/control * [0d7ac29] Fix check_cert_expire_dirs to make it work at all. check_cert_expire_dirs was not able to find check_cert_expire. Fixing that. (Closes: #855155) Checksums-Sha1: 2dc50b8b7a5e04dccdd17bf89f631a475cbe3b8c 2297 nagios-plugins-contrib_21.20170222.dsc fea0f0c5580b1c4c3d89e72e517da4acc989119c 856520 nagios-plugins-contrib_21.20170222.tar.xz 84657f7cba7eed24c0d1fcb5e369b00fda16295e 28030 nagios-plugins-contrib-dbgsym_21.20170222_amd64.deb 4cf14a6bae6cc45d510cabcfe32144348c2fad6d 6103 nagios-plugins-contrib_21.20170222_amd64.buildinfo f97bf1bb32e252ef53306c5b9028c6d39f023f50 446474 nagios-plugins-contrib_21.20170222_amd64.deb Checksums-Sha256: a1057dddcf396c123c2960a783cfcfa5e258be3e8876bf81b4e29c4fc29ad507 2297 nagios-plugins-contrib_21.20170222.dsc 677cce642f19740978f7e3e8504199514d8f58e9b3d9a4a950ec54c3faa1908b 856520 nagios-plugins-contrib_21.20170222.tar.xz d593b55b59ffd2026b0c4a7dd97d0ab4da8c9aa923b37530be14ec5b81991251 28030 nagios-plugins-contrib-dbgsym_21.20170222_amd64.deb 4819a7f477397edb931634424ccb030d8046bd6d25adfc7eaafb7396df83bd9d 6103 nagios-plugins-contrib_21.20170222_amd64.buildinfo 2a76e472d1ceb59a73c54a86b9ea874e1bd70404d6339da4981686c5ca1d6e56 446474 nagios-plugins-contrib_21.20170222_amd64.deb Files: 9b0e7692818d3d4803c994f699f6b714 2297 net extra nagios-plugins-contrib_21.20170222.dsc 56625e7f682fc177fabb1cdedd642636 856520 net extra nagios-plugins-contrib_21.20170222.tar.xz 0b535db2b7b356862f7a986c3882d35e 28030 debug extra nagios-plugins-contrib-dbgsym_21.20170222_amd64.deb 36e7371cc8bade52f14eae134bb0c9a8 6103 net extra nagios-plugins-contrib_21.20170222_amd64.buildinfo e78c53e03bba0cabd0c6f510bab7b312 446474 net extra nagios-plugins-contrib_21.20170222_amd64.deb -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE7KHj8o4RJDLUhd2V6zYXGm/5Q18FAlitlgwACgkQ6zYXGm/5 Q1/WDQ//R5c0JZWIjBWfemwxT5rwdbDUiTGQbCLv+v0li0qWcnEBgCyi+NWVat9b ExTyH8Mc24tiw3xFedqft9s5wqhv1se2C3EVsTthixtIzLPJ2vogrcPFGiPr+1eX ZXgXBvvLekwCWyn0iwMbyQOabgC6ArbLNUz1faA84Tlb5SfGMZFfQi6OGtHNKWg9 u4zFMsWI8CoK2r/Rv8oIf+ck1v+WnLAflgYJZkmQqYud97syzi6j2l579WLrCCTe TYtXUqdlUitVOoyxFCBPEWutv2GbwDcY6rW1sMerDn+RFH3Fo4U4n+HAevjSsuA/ PS3RqcWKNA5usjIs7Rxjl39T7AqukZsdRVHuhgoVYntQ9MDWnRRrlZhPAksd3wJ9 PcK5BdWytzGVIFGwRFkJ/fUnKX4xAKxCslXFm22hmdVW082JDCRSulhyXg0mkriZ Q89wXS9yzWdZjHpR6AXFdAiD1uDegDIhAQkxRj//hqLkLL4iyJasr6b7FqeY50Vc 31QGCNwCkaDcVNNvaKRrxTVrgDbwEk/WNDuhmIajZMg0RYeB6JNjSXJO7dHEyPo7 aplzYu3ru53sx/0qi1a22Dflcto3qZYAHFmvLMFhXMClwDyRAaWQjRmZ+oRXpa/6 bLf4Wqa01MBIqNs96PJnRlE/VIQeIDhw/Sn1lNajSX54/tfeNGo= =JD65 -----END PGP SIGNATURE-----
--- End Message ---
