Your message dated Sun, 21 May 2017 21:05:05 +0000
with message-id <[email protected]>
and subject line Bug#862975: fixed in laptop-mode-tools 1.71-2
has caused the Debian Bug report #862975,
regarding laptop-mode-tools: Fails to modify wireless txpower using "fixed" 
with "iw"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
862975: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862975
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: laptop-mode-tools
Version: 1.71-1
Severity: normal
Tags: patch

Dear Maintainer,

When using the wireless-power module (with its config-file unmodified), it
fails to enable wireless powersavings. When running with debugging enabled,
and when running the borked internal command manually:

> sudo iw dev wlan0 set txpower fixed

it shows:

> Missing TX power level argument.

When I manually run the command with an added parameter, e.g.:

> sudo iw dev wlan0 set txpower fixed 1

and then check the result with:

> sudo iw dev wlan0 info

it shows the updated value OK. Note that the lowest value it accepts in my
case is 1, not 0.

This has been fixed (actually, avoided) upstream with the following sequence
of commits:

https://github.com/rickysarraf/laptop-mode-tools/commit/3644486a9ee4fda7887fa0ecf224e66c4d12a0d2
https://github.com/rickysarraf/laptop-mode-tools/commit/791191702b91f7e23b280f35e292869631f5ba22
https://github.com/rickysarraf/laptop-mode-tools/commit/9ca191ff3e5b002f759d69435f14c7f54020085f

Namely, they use:

> iw dev wlan0 set power_save [on/off]

and *no* txpower settings if "iw" is available, falling back to the old
txpower commands with iwconfig (and fixed a variable typo in the test).

So it would be good if upstream's new way of running the two commands could
be backported as a Debian patch while we wait for upstream to make the next
release for packaging. For that purpose I attached a diff by merging the
relevant parts of the above 3 commits (note it is the diff that should be
turned into a Debian patch, not a diff for creating the debian patch itself).

-- System Information:
Debian Release: 9.0
  APT prefers unstable
    APT policy: (900, 'unstable'), (500, 'testing'), (500, 'stable'), (100, 
'experimental')
    Architecture: amd64
     (x86_64)

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages laptop-mode-tools depends on:
ii  init-system-helpers  1.48
ii  lsb-base             9.20161125
ii  psmisc               22.21-2.1+b2
ii  util-linux           2.29.2-1

Versions of packages laptop-mode-tools recommends:
ii  ethtool         1:4.8-1+b1
ii  hdparm          9.51+ds-1
ii  net-tools       1.60+git20161116.90da8a0-1
ii  python-qt4      4.11.4+dfsg-2+b1
ii  sdparm          1.08-1+b1
ii  udev            232-23
ii  wireless-tools  30~pre9-12+b1

Versions of packages laptop-mode-tools suggests:
ii  acpid  1:2.0.28-1+b1

-- Configuration Files:
/etc/laptop-mode/conf.d/auto-hibernate.conf changed [not included]
/etc/laptop-mode/conf.d/bluetooth.conf changed [not included]
/etc/laptop-mode/conf.d/configuration-file-control.conf changed [not included]
/etc/laptop-mode/conf.d/cpufreq.conf changed [not included]
/etc/laptop-mode/conf.d/dpms-standby.conf changed [not included]
/etc/laptop-mode/conf.d/eee-superhe.conf changed [not included]
/etc/laptop-mode/conf.d/kbd-backlight.conf changed [not included]
/etc/laptop-mode/conf.d/lcd-brightness.conf changed [not included]
/etc/laptop-mode/conf.d/radeon-dpm.conf changed [not included]
/etc/laptop-mode/conf.d/runtime-pm.conf changed [not included]
/etc/laptop-mode/conf.d/video-out.conf changed [not included]
/etc/laptop-mode/conf.d/wireless-ipw-power.conf changed [not included]
/etc/laptop-mode/conf.d/wireless-iwl-power.conf changed [not included]

-- no debconf information

-- debsums errors found:
--- a/usr/share/laptop-mode-tools/modules/wireless-power        2017-01-12 
15:57:19.000000000 +0200
+++ b/usr/share/laptop-mode-tools/modules/wireless-power        2017-05-19 
16:56:56.701809056 +0300
@@ -66,17 +66,12 @@
 
        if [ -n "$IW" ]; then
                $IW dev $IF set power_save $ONOFF
-                if [ $ONOFF = "ON" ]; then
-                    $IW dev $IF set txpower auto
-                else
-                    $IW dev $IF set txpower fixed
-                fi
        else
                $IWCONFIG $IF power $ONOFF
-                if [ $ONOFF = "ON" ]; then
+                if [ $ONOFF = "on" ]; then
                     $IWCONFIG $IF txpower auto
                 else
-                    $IW dev $IF txpower fixed
+                    $IWCONFIG dev $IF txpower fixed
                 fi
        fi
 }

--- End Message ---
--- Begin Message ---
Source: laptop-mode-tools
Source-Version: 1.71-2

We believe that the bug you reported is fixed in the latest version of
laptop-mode-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ritesh Raj Sarraf <[email protected]> (supplier of updated laptop-mode-tools 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 22 May 2017 02:20:16 +0545
Source: laptop-mode-tools
Binary: laptop-mode-tools
Architecture: source all
Version: 1.71-2
Distribution: unstable
Urgency: medium
Maintainer: Ritesh Raj Sarraf <[email protected]>
Changed-By: Ritesh Raj Sarraf <[email protected]>
Description:
 laptop-mode-tools - Tools for Power Savings based on battery/AC status
Closes: 862975
Changes:
 laptop-mode-tools (1.71-2) unstable; urgency=medium
 .
   * Backport patch from upstream. fix-iw-txpower-issue.patch
     This fixes syntax errors with the newer 'iw' command
     Thanks: Rowan Thorpe (Closes: #862975)
Checksums-Sha1:
 937a47663b3c56fc018aca02160e5ca2987cfb7b 1850 laptop-mode-tools_1.71-2.dsc
 fd106ff067d13184b51ef646186810d60ed4377a 21756 
laptop-mode-tools_1.71-2.debian.tar.xz
 2101a317c1fec6d4ec401004b08c21010bbb8aa6 121262 
laptop-mode-tools_1.71-2_all.deb
 0030c3c13c3442f82dda31b997f2bbfb4bc7812c 5747 
laptop-mode-tools_1.71-2_amd64.buildinfo
Checksums-Sha256:
 77ad3b94dc238c23da048f04663c291a4452669d5f6376f51e8f9192664f36e2 1850 
laptop-mode-tools_1.71-2.dsc
 b2c07394d9c0f2f1a1eaa753952c93587259e9b62063a69035e98bb965f6ea12 21756 
laptop-mode-tools_1.71-2.debian.tar.xz
 f6463603797bd965e1531567fcb0ecc986f5aede56637e92ef268d1d1e54aa64 121262 
laptop-mode-tools_1.71-2_all.deb
 bd3e015d59a930354d7bee895eb45c4f4e82da45aea10e84f480229841d21a12 5747 
laptop-mode-tools_1.71-2_amd64.buildinfo
Files:
 d618b3c5f5b47dee9288f5b66eaff56b 1850 utils optional 
laptop-mode-tools_1.71-2.dsc
 2e7dd0afe2698f8feaea36c175e6743d 21756 utils optional 
laptop-mode-tools_1.71-2.debian.tar.xz
 3266db5bed0ae91be5fdd6bdf70327c3 121262 utils optional 
laptop-mode-tools_1.71-2_all.deb
 ab592f02b3510d9ec1ca42f7ae91e2da 5747 utils optional 
laptop-mode-tools_1.71-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQCVDstmIVAB/Yn02pjpYo/LhdWkFAlkh+r4ACgkQpjpYo/Lh
dWkUBhAAgZSElA8a+CzKO7n3qeGs6xOlnVUDZJfuxb43brVQhitGcvlo7b9MSIlh
yLRuM3X6EaCGlj1lSeud2y2Gm2dBH0Gns0PaN9isgO8tTifBsx+pVM/nLXpibUoO
VksRuFEdjdleDlaUrsjoGQJU4nHrHRtoNGuRjnHdJ0uIfI6o53nSU9vP1lXhu/1C
oWcHsI4BsrJemQ3tSCD54i3AJtkxf9liNxWcmfsushKf9Uqqw1p5i5ZRp9teRxwt
p0DfDKuZbfcR2eGpSiN1oheZzpUrnCyo5OeOOIUZDSSz6Qx5B04Ffd8oqEqIPtTj
lSWj8L66GYeAv0joEU8Jb5ldL3f4ae4kQ+bLoKB/so0EqM0293RQBDvh/mqwjVwA
wYPmElL1i6sieGVOqldCcKXMI82Z5L2khCjeTN7dpVFnNZyBkkD+XQVHrVQto+Nc
pxUxuXze7Oii/bqpJg8DEIgP9iqQWt766IZs85eTe2JCkBa8gzVF1KzvSBTacieW
xlhyW4lRn438o7of54WRvWP67Utccvpriqdeebxz9i2rmvX86yEKr8bRFG8dq861
UPS+Aq1dyKuUFZQlduv6nJKcY97dfyz0ySd0eycDo8oaDK2EgIG0vUpCRsAmEwKp
iP4FVlot0ZlqbAhBu1fgXO7lwS2/SK3P4OYeZc0bUPAUceT2o7Y=
=uGRm
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to