Your message dated Sat, 27 May 2017 21:05:07 +0000
with message-id <[email protected]>
and subject line Bug#849151: fixed in php-horde-crypt 2.7.8-1
has caused the Debian Bug report #849151,
regarding php-horde-crypt: add gnupg as an explicit test dep, update for gnupg2
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
849151: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849151
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: php-horde-crypt
Version: 2.7.5-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu zesty ubuntu-patch
Dear Maintainer,
autopkgtests for php-horde-crypt are currently failing on Ubuntu but
passing on Debian. This appears to be because our images have
/usr/bin/gpg present (with version 2.x) which the current tests fail on.
It seems like gnupg should be listed as a test dep and the tests should
be updated to be compatible with 2.x. I have sent the patch below
upstream in a ticket and verified that the resulting source package does
pass in Unstable.
In Ubuntu, the attached patch was applied to achieve the following:
* d/t/control: add explicit dependency on gnupg for tests
* debian/patches/update_tests_gnupg2.patch: Update tests for gnupg2
changes. Closes LP: #1652133.
Thanks for considering the patch.
*** /tmp/tmpe2HfZ0/php-horde-crypt_2.7.5-1ubuntu1.debdiff
diff -Nru php-horde-crypt-2.7.5/debian/patches/series
php-horde-crypt-2.7.5/debian/patches/series
--- php-horde-crypt-2.7.5/debian/patches/series 1969-12-31 16:00:00.000000000
-0800
+++ php-horde-crypt-2.7.5/debian/patches/series 2016-12-22 10:33:31.000000000
-0800
@@ -0,0 +1 @@
+update_tests_gnupg2.patch
diff -Nru php-horde-crypt-2.7.5/debian/patches/update_tests_gnupg2.patch
php-horde-crypt-2.7.5/debian/patches/update_tests_gnupg2.patch
--- php-horde-crypt-2.7.5/debian/patches/update_tests_gnupg2.patch
1969-12-31 16:00:00.000000000 -0800
+++ php-horde-crypt-2.7.5/debian/patches/update_tests_gnupg2.patch
2016-12-22 10:37:12.000000000 -0800
@@ -0,0 +1,64 @@
+Description: Update tests for gnupg2 changes
+ The tests currently rely on gpg1 behavior, so pass parameters to gpg
+ that make gpg2 emulate the behavior of gpg1 as necessary. Thanks to
+ https://github.com/keybase/keybase-issues/issues/1712 for related, but
+ not identical, issues and solution suggestions.
+ .
+ Split testVerifyPassphrase() into two tests: gpg2 always spawns a
+ gpg-agent, which caches passphrases. So the first correct passphrase
+ ends up leading to the second bad passphrase attempt passing.
+Author: Nishanth Aravamudan <[email protected]>
+Bug: https://bugs.horde.org/ticket/14548
+Bug-Ubuntu: https://launchpad.net/bugs/1652133
+Forwarded:
https://bugs.horde.org/view.php?actionID=view_file&type=patch&file=update_tests_gnupg2.patch&ticket=14548
+Last-Update: 2016-12-22
+
+--- a/Horde_Crypt-2.7.5/lib/Horde/Crypt/Pgp/Backend/Binary.php
++++ b/Horde_Crypt-2.7.5/lib/Horde/Crypt/Pgp/Backend/Binary.php
+@@ -75,8 +75,15 @@
+ '--no-options',
+ '--no-default-keyring',
+ '--yes',
+- '--homedir ' . $this->_tempdir
++ '--homedir ' . $this->_tempdir,
++ '--keyid-format short'
+ );
++
++ $result = $this->_callGpg(array('--version'), 'r', null, false,
false, true);
++ /* gpg > 1.x requires specifying the pinentry-mode */
++ if (!preg_match('/gpg \(GnuPG\) = (1\.[0-9\.]+)/', $result->stdout,
$m)) {
++ $this->_gnupg[] = '--pinentry-mode loopback';
++ }
+ }
+
+ /**
+@@ -678,6 +685,7 @@
+ if ($parseable) {
+ putenv('LANGUAGE=C');
+ }
++ putenv('GPG_TTY=$(tty)');
+ if ($mode == 'w') {
+ if ($fp = popen($cmdline, 'w')) {
+ putenv('LANGUAGE=' . $language);
+--- a/Horde_Crypt-2.7.5/test/Horde/Crypt/Pgp/TestBase.php
++++ b/Horde_Crypt-2.7.5/test/Horde/Crypt/Pgp/TestBase.php
+@@ -511,7 +511,7 @@
+ $this->assertNotEmpty($out->result);
+ }
+
+- public function testVerifyPassphrase()
++ public function testVerifyPassphraseCorrect()
+ {
+ $this->assertTrue(
+ $this->_pgp->verifyPassphrase(
+@@ -520,7 +520,10 @@
+ 'Secret'
+ )
+ );
++ }
+
++ public function testVerifyPassphraseIncorrect()
++ {
+ $this->assertFalse(
+ $this->_pgp->verifyPassphrase(
+ $this->_getPublicKey(),
diff -Nru php-horde-crypt-2.7.5/debian/tests/control
php-horde-crypt-2.7.5/debian/tests/control
--- php-horde-crypt-2.7.5/debian/tests/control 2016-12-17 14:04:22.000000000
-0800
+++ php-horde-crypt-2.7.5/debian/tests/control 2016-12-22 10:37:12.000000000
-0800
@@ -1,3 +1,3 @@
Tests: phpunit
Restrictions: needs-recommends
-Depends: @, php-cli, php-horde-test
+Depends: @, php-cli, php-horde-test, gnupg
-- System Information:
Debian Release: stretch/sid
APT prefers yakkety-updates
APT policy: (500, 'yakkety-updates'), (500, 'yakkety-security'), (500,
'yakkety'), (100, 'yakkety-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.8.0-30-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
--
Nishanth Aravamudan
Ubuntu Server
Canonical Ltd
--- End Message ---
--- Begin Message ---
Source: php-horde-crypt
Source-Version: 2.7.8-1
We believe that the bug you reported is fixed in the latest version of
php-horde-crypt, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mathieu Parent <[email protected]> (supplier of updated php-horde-crypt
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 27 May 2017 22:14:43 +0200
Source: php-horde-crypt
Binary: php-horde-crypt
Architecture: source all
Version: 2.7.8-1
Distribution: unstable
Urgency: medium
Maintainer: Horde Maintainers <[email protected]>
Changed-By: Mathieu Parent <[email protected]>
Description:
php-horde-crypt - ${phppear:summary}
Closes: 849151
Changes:
php-horde-crypt (2.7.8-1) unstable; urgency=medium
.
* New upstream version 2.7.8
- with GnuPG 2 support (incomplete)
- Remove 0001-Escape-user-provided-recipients-and-charset-data.patch,
merged
* Add gnupg as a test dependency (Closes: #849151)
* Fix GnuPG 2 support (from https://github.com/horde/horde/pull/221)
Checksums-Sha1:
91d60bccf3afb1d916060819a81e1547763fab15 2120 php-horde-crypt_2.7.8-1.dsc
7e815c96578c05ea561cafe42f526a481a5bc4f4 151452
php-horde-crypt_2.7.8.orig.tar.gz
8e3a8da2be3e919755bd551a4bb1071c01dcd2e1 4080
php-horde-crypt_2.7.8-1.debian.tar.xz
62b7592180a20a8133970457019998c3884464c1 112870 php-horde-crypt_2.7.8-1_all.deb
599b4cd22524353c6447e2c44cae18ee1b518d40 6232
php-horde-crypt_2.7.8-1_amd64.buildinfo
Checksums-Sha256:
2029c3ef7178f83a4be8295267a03594edb79657f5a7b1ad65029cf6d30bf48d 2120
php-horde-crypt_2.7.8-1.dsc
0e618294ac042e075492b7006699dc51b139372fc320a047c58476bdd5fe7757 151452
php-horde-crypt_2.7.8.orig.tar.gz
1e26657de81756940da7b9d9b0d7fd475afd855c47ff78e11e565ca30b6486f2 4080
php-horde-crypt_2.7.8-1.debian.tar.xz
63eb3a1eab7cbfda2f15984ece3d46cc37572ee8afa4cb13dee231b3766ac776 112870
php-horde-crypt_2.7.8-1_all.deb
247b200816331527d97e97ac53c261300607068143c2763090bc0153490edfe6 6232
php-horde-crypt_2.7.8-1_amd64.buildinfo
Files:
d51093a2ae4455f75300209be4c8c5c9 2120 php extra php-horde-crypt_2.7.8-1.dsc
d40b6bbe1dd47a255d072bf7b326e4dc 151452 php extra
php-horde-crypt_2.7.8.orig.tar.gz
860cb1bfda443223dd3afa5953a5ca96 4080 php extra
php-horde-crypt_2.7.8-1.debian.tar.xz
f52ed1e2245f27613f9da78bedbdb01f 112870 php extra
php-horde-crypt_2.7.8-1_all.deb
9d140b7e8fd6a541262ce35abff314bc 6232 php extra
php-horde-crypt_2.7.8-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCAAxFiEEqIGbPTP9weQZ135HrgOYBGZoH6UFAlkp4METHHNhdGhpZXVA
ZGViaWFuLm9yZwAKCRCuA5gEZmgfpefTD/9xgkFd/8F3ACVS+ky+lzH2GQnLESyJ
OeDRpetEZtZCmp/9gbOCNgr6MTDOXOn84Yi35sXXq37tCQuNBI+pMMtAo5cR7b7G
BGPsE1rb4dUAX+QDU6BKFI4JtUGnkBADrsjJsgRDd8pG3Qhxc1sT3myPehTTzqLs
RLKCUjyoFKNCdseBAGkAs841dT8vFJL5Qb3G9glXSGEP7oAGUT8NKL+CqyTMNsQK
56mC3zDZkvEefGXU7fjG03r50pE9d4BT350bHd9DwOZ/AMYr8GrdV0Ayg521zKVi
RG7dzVKSnIWsp6N7ODmD1G+nFAequsbKCqAGnn9rpf3bimtsU9IN/0acT6b/JOwo
8EZySDBQAe7XxGc52xA9COzbk8ip1JAKM4BzneJ79SqRx28oH4IyRnTWDe1QShqz
3BU6TUTf1QLjpoGbEn+BbpBWmFJ4H+6wkDHQT52GpxaMsjgVci4gLE7Q/qNxbDMl
IL8xwnmlhBsQ4YlH2jQEvOGpCkWPblk/tuYh9nn7dUSe6YKL0tlP4XEkpxLMgRWh
gAfv6WRzBXt+3Tpxyi40JLZEuU9CvCBYwlQ5ZWMLCjhIljnqIOLzKldClWjpsNLm
U92uy+M6IN5rr6sSNSgPwbi3XCW8g2EJVfha50fBoYRQorOfAGNQ5wCol+f+Fyxi
OD1+1CmFrfDg1A==
=QVNr
-----END PGP SIGNATURE-----
--- End Message ---
