Your message dated Sat, 24 Jun 2017 18:36:42 +0200
with message-id <[email protected]>
and subject line Re: Bug#653711: force __FAVOR_BSD in <netinet/tcp.h> and 
<netinet/udp.h>
has caused the Debian Bug report #653711,
regarding force __FAVOR_BSD in <netinet/tcp.h> and <netinet/udp.h>
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
653711: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653711
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libbsd-dev
Severity: wishlist
Tags: patch

El 25 de desembre de 2011 11:56, Robert Millan <[email protected]> ha escrit:
>> +#define __FAVOR_BSD 1
>>  #include <netinet/in_systm.h>
>>  #include <netinet/in.h>
>>  #include <netinet/ip.h>
>>  #include <netinet/ip_icmp.h>
>>  #include <netinet/tcp.h>
>>  #include <netinet/udp.h>
>> +#undef __FAVOR_BSD
>
> Shouldn't this kind of fix be in libbsd-dev?  E.g. in overlay netinet/in.h:
>
> #if __FAVOR_BSD
> #  include_next <netinet/in.h>
> #else
> #  define __FAVOR_BSD 1
> #  include_next <netinet/in.h>
> #  undef __FAVOR_BSD
> #endif

Let's make a bug out of this.  Patch attached.

-- 
Robert Millan
--- /dev/null
+++ b/include/bsd/netinet/tcp.h
@@ -0,0 +1,8 @@
+#include <features.h>
+#if __FAVOR_BSD
+#  include_next <netinet/tcp.h>
+#else
+#  define __FAVOR_BSD 1
+#  include_next <netinet/tcp.h>
+#  undef __FAVOR_BSD
+#endif
--- /dev/null
+++ b/include/bsd/netinet/udp.h
@@ -0,0 +1,8 @@
+#include <features.h>
+#if __FAVOR_BSD
+#  include_next <netinet/udp.h>
+#else
+#  define __FAVOR_BSD 1
+#  include_next <netinet/udp.h>
+#  undef __FAVOR_BSD
+#endif

--- End Message ---
--- Begin Message ---
Hi!

On Fri, 2011-12-30 at 15:31:29 +0100, Robert Millan wrote:
> Package: libbsd-dev
> Severity: wishlist
> Tags: patch

> El 25 de desembre de 2011 11:56, Robert Millan <[email protected]> ha escrit:
> >> +#define __FAVOR_BSD 1
> >>  #include <netinet/in_systm.h>
> >>  #include <netinet/in.h>
> >>  #include <netinet/ip.h>
> >>  #include <netinet/ip_icmp.h>
> >>  #include <netinet/tcp.h>
> >>  #include <netinet/udp.h>
> >> +#undef __FAVOR_BSD
> >
> > Shouldn't this kind of fix be in libbsd-dev?  E.g. in overlay netinet/in.h:
> >
> > #if __FAVOR_BSD
> > #  include_next <netinet/in.h>
> > #else
> > #  define __FAVOR_BSD 1
> > #  include_next <netinet/in.h>
> > #  undef __FAVOR_BSD
> > #endif
> 
> Let's make a bug out of this.  Patch attached.

I've always been rather uncomfortable with this request, as it introduced
yet another dependency on a glibc internal.

But this does not seem to make any sense anymore since the deprecation of
_BSD_SOURCE and _SVID_SOURCE by the new _DEFAULT_SOURCE. Thus closing now.

Thanks,
Guillem

--- End Message ---

Reply via email to