Your message dated Wed, 05 Jul 2017 09:33:56 +0000
with message-id <[email protected]>
and subject line Bug#864534: fixed in bloboats 1.0.2+dfsg-3
has caused the Debian Bug report #864534,
regarding bloboats FTCBFS: uses the build architecture compiler
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
864534: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864534
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: bloboats
Version: 1.0.2+dfsg-2
Tags: patch
User: [email protected]
Usertags: rebootstrap
bloboats fails to cross build from source, because it uses the build
architecture compiler. Luckily, dh_auto_build knows how to do that and
just using it makes the build almost succeed. Except that make install
relinks the final executable - without a cross compiler. Thus changing
the Makefile target dependencies is in order. After applying the
attached patch, bloboats cross builds successfully. It also builds
faster by avoiding unnecessary rebuilds and by actually honouring
DEB_BUILD_OPTIONS=parallel=... via dh_auto_build. Please consider
applying it after stretch is released.
Helmut
diff --minimal -Nru bloboats-1.0.2+dfsg/debian/changelog
bloboats-1.0.2+dfsg/debian/changelog
--- bloboats-1.0.2+dfsg/debian/changelog 2016-07-10 22:48:24.000000000
+0200
+++ bloboats-1.0.2+dfsg/debian/changelog 2017-06-10 08:25:10.000000000
+0200
@@ -1,3 +1,12 @@
+bloboats (1.0.2+dfsg-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Let dh_auto_build pass cross compilers.
+ + Do not rebuild during make install (cross.patch).
+
+ -- Helmut Grohne <[email protected]> Sat, 10 Jun 2017 08:25:10 +0200
+
bloboats (1.0.2+dfsg-2) unstable; urgency=medium
* Team upload.
diff --minimal -Nru bloboats-1.0.2+dfsg/debian/patches/cross.patch
bloboats-1.0.2+dfsg/debian/patches/cross.patch
--- bloboats-1.0.2+dfsg/debian/patches/cross.patch 1970-01-01
01:00:00.000000000 +0100
+++ bloboats-1.0.2+dfsg/debian/patches/cross.patch 2017-06-10
08:25:10.000000000 +0200
@@ -0,0 +1,33 @@
+From: Helmut Grohne <[email protected]>
+Subject: reverse X and X-stamp targets
+
+By having X contain the rules and X-stamp depend on X, X is always run. Thus
+the binary is relinked during make install. This is bad, because
+dh_auto_install doesn't pass cross compilers to make install.
+
+Index: bloboats-1.0.2+dfsg/Makefile
+===================================================================
+--- bloboats-1.0.2+dfsg.orig/Makefile
++++ bloboats-1.0.2+dfsg/Makefile
+@@ -143,8 +143,8 @@
+ all: config-stamp build-stamp
+
+ #main: $(OBJ)
+-build-stamp: build
+-build: config-stamp $(OBJ)
++build: build-stamp
++build-stamp: config-stamp $(OBJ)
+ mkdir -p bin
+ $(CXX) $(LDFLAGS) $(OBJ) $(LIBS) $(CXXFLAGS)
+ touch build-stamp
+@@ -155,8 +155,8 @@
+ $(CXX) -o bin/$(BINARY) $(OBJ) $(ICON) $(LIBS)
+ #$(STRIP) bin/$(BINARY)
+
+-config-stamp: config
+-config:
++config: config-stamp
++config-stamp:
+ echo "datadir $(DATADIR)" >bloboats.dirs
+ echo "privatedir $(PRIVATEDIR)" >>bloboats.dirs
+ chmod 644 bloboats.dirs
diff --minimal -Nru bloboats-1.0.2+dfsg/debian/patches/series
bloboats-1.0.2+dfsg/debian/patches/series
--- bloboats-1.0.2+dfsg/debian/patches/series 2016-07-10 22:48:24.000000000
+0200
+++ bloboats-1.0.2+dfsg/debian/patches/series 2017-06-10 08:25:10.000000000
+0200
@@ -3,3 +3,4 @@
03-uint32.patch
Hardening.patch
gcc-6-FTBFS.patch
+cross.patch
diff --minimal -Nru bloboats-1.0.2+dfsg/debian/rules
bloboats-1.0.2+dfsg/debian/rules
--- bloboats-1.0.2+dfsg/debian/rules 2016-07-10 22:48:24.000000000 +0200
+++ bloboats-1.0.2+dfsg/debian/rules 2017-06-10 08:25:08.000000000 +0200
@@ -5,7 +5,7 @@
override_dh_auto_build:
- $(MAKE) DATADIR=/usr/share/games/bloboats
+ dh_auto_build -- DATADIR=/usr/share/games/bloboats
override_dh_auto_install:
$(MAKE) \
--- End Message ---
--- Begin Message ---
Source: bloboats
Source-Version: 1.0.2+dfsg-3
We believe that the bug you reported is fixed in the latest version of
bloboats, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Markus Koschany <[email protected]> (supplier of updated bloboats package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 05 Jul 2017 10:34:29 +0200
Source: bloboats
Binary: bloboats
Architecture: source
Version: 1.0.2+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Markus Koschany <[email protected]>
Description:
bloboats - Boat racing game
Closes: 864534
Changes:
bloboats (1.0.2+dfsg-3) unstable; urgency=medium
.
* Team upload.
* Fix FTCBFS.
- Let dh_auto_build pass cross compilers.
- Do not rebuild during make install (cross.patch).
Thanks to Helmut Grohne for the report and patch. (Closes: #864534)
* Drop deprecated menu file and xpm icon.
* Switch to compat level 10.
* Declare compliance with Debian Policy 4.0.0.
* wrap-and-sort -sa.
* Use https for Format field.
* Install desktop icon to /usr/share/icons/hicolor/256x256/apps.
Checksums-Sha1:
43bee807fc2aa8d2e41df1e81f30d5a7c17d59c5 2141 bloboats_1.0.2+dfsg-3.dsc
56884486d46d4a3860af4c89a12d05e6506d14ad 35372
bloboats_1.0.2+dfsg-3.debian.tar.xz
52bc55b10d345a9ae94c2265173d44d785de5f21 9699
bloboats_1.0.2+dfsg-3_amd64.buildinfo
Checksums-Sha256:
de36847fcdc649cc6ae347e1888d3a74ff4f64eb60611a55eb0924916356008e 2141
bloboats_1.0.2+dfsg-3.dsc
0b7c2197cbe633958b782d8a877196463e931651199cba587b9e932252be2c4c 35372
bloboats_1.0.2+dfsg-3.debian.tar.xz
03ec1a4d643b63831f128714a86c0ab952667f7f304c7934e3186e8a78d9fa29 9699
bloboats_1.0.2+dfsg-3_amd64.buildinfo
Files:
26b08d0578a87511b4a08e25d66bb6ce 2141 games optional bloboats_1.0.2+dfsg-3.dsc
2ce17925765179a07085030bc944cd02 35372 games optional
bloboats_1.0.2+dfsg-3.debian.tar.xz
544a367bf0d92ade666df8e83f51d243 9699 games optional
bloboats_1.0.2+dfsg-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKjBAEBCgCNFiEErPPQiO8y7e9qGoNf2a0UuVE7UeQFAllcqU9fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEFD
RjNEMDg4RUYzMkVERUY2QTFBODM1RkQ5QUQxNEI5NTEzQjUxRTQPHGFwb0BkZWJp
YW4ub3JnAAoJENmtFLlRO1HkiRcP/2hXxyUI4uQMKrHhES8bHrkBQd5Ws6+MuRq/
axZ2louMuC4lWbjQLCb93X9W+32c8Cpq4AdtsyKaaQptg2daSQ1Su7816AVjYJo3
DBCsICaOGtPuOfVS7McyXKKh1lmxO01BeXHhYC/1d3aKOkBNEIdgDL3IxlWZBlwp
WJ6PH+qrdkcyoLVktZczubiDoZW4CrVbm4zcGtIqbMm5XXIP5D5XHprGeCxYorWh
GkyPAQlykBcVyKajiaEDI9n2wz7gnS5mkZFvmPpz4r5WONxdk4+fc9wPy7yUsre1
6nXZRhplgVUn9ofJpXuMom0W4WKti2kG6aYVlyB959d+IINyxn3owPRMzYfYZ+7j
wdEbCz1BOn3ZW+xb6yEp0mGVdQDuFrz/qbyaG7Z5B7JwvjKHkBvsxu7cNb9pNLV9
h7/r5eDAPMIhBenPk0NtP+GxVzzMHw/7bo13eww208IyRxPE+cI61v0WMqgLy3Ze
PZ0dpCaz9wBSXlzXLvDVXRkoapcw9lY6wYZ0syP8ei1YgJQCpVu+VoBFwTz+3bXp
1oFB9YgHEe7y4105USrdNUVI3/eWtEIv40d/639f8tJIFB3bxGscD+GjKsrYk83M
X9L6Msl26eJFcEoS7g//2yNO0zxfrWwmkmTTlf/k8bx/xOQlAfL92BpCajrvrMFJ
CODNG6TP
=/b++
-----END PGP SIGNATURE-----
--- End Message ---