Your message dated Mon, 10 Jul 2017 16:29:56 +0900
with message-id <[email protected]>
and subject line Re: xgalaga++: please make the build reproducible
has caused the Debian Bug report #826418,
regarding xgalaga++: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
826418: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826418
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: xgalaga++
Version: 0.8.4-2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: fileordering
X-Debbugs-Cc: [email protected]
Hi!
While working on the "reproducible builds" effort [1], we have noticed
that xgalaga++ could not be built reproducibly.
The list of source files is not sorted, which leads to a
non-deterministic linking order.
The attached patch fixes this.
Regards,
Reiner
[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible_build.patch b/debian/patches/reproducible_build.patch
new file mode 100644
index 0000000..0f7c834
--- /dev/null
+++ b/debian/patches/reproducible_build.patch
@@ -0,0 +1,14 @@
+Author: Reiner Herrmann <[email protected]>
+Description: Sort source files to get a deterministic linking order
+
+--- a/Makefile
++++ b/Makefile
+@@ -124,7 +124,7 @@
+ LDOPTS = $(GOAL_OPTS) $(LNK_LIBS)
+
+ # source files in this project
+-sources := $(wildcard $(srcdir)/*.$(SOURCE_SUFFIX))
++sources := $(sort $(wildcard $(srcdir)/*.$(SOURCE_SUFFIX)))
+
+ # object files in this project
+ objs := $(notdir $(sources))
diff --git a/debian/patches/series b/debian/patches/series
index 67dff1b..9112cf3 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
fix_man_section
+reproducible_build.patch
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Fixed in 0.8.4-3
--
takaki
--- End Message ---
