Your message dated Tue, 25 Jul 2017 18:42:23 +0200
with message-id <[email protected]>
and subject line Re: Bug#869532: diffoscope: ftbfs with new binutils
has caused the Debian Bug report #869532,
regarding diffoscope: ftbfs with new binutils
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
869532: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=869532
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: diffoscope
Version: 84
Severity: normal

Dear Maintainer,

diffoscope 84 ftbfs in Ubuntu artful (and I think experimental but haven't
checked this yet) with failures like this:

________________________________ test_item1_elf ________________________________

differences = [<Difference nm -s {} -- nm -s {} []>, <Difference 
alloc_system-d16b8f0e.0.o -- alloc_system-d16b8f0e.0.o []>, <Differ...r -dump 
{} []>, <Difference find {} -execdir llvm-dis -o - '{}' ';' -- find {} -execdir 
llvm-dis -o - '{}' ';' []>]>]>]

    @skip_unless_tools_exist('nm')
    @skip_if_binutils_does_not_support_x86()
    def test_item1_elf(differences):
        assert differences[1].source1 == 'alloc_system-d16b8f0e.0.o'
        assert differences[1].source2 == 'alloc_system-d16b8f0e.0.o'
        expected_diff = get_data('rlib_elf_expected_diff')
>       assert differences[1].details[0].unified_diff == expected_diff
E       IndexError: list index out of range

I'm fairly sure this is down to this change in behaviour in readelf:

(artful-amd64)root@aeglos:/tmp# readelf --wide --decompress --hex-dump=.data 
alloc_system-d16b8f0e.0.o

Section '.data' has no data to dump.
(artful-amd64)root@aeglos:/tmp# echo $?
1

vs:

(sid-amd64)root@aeglos:/# readelf --wide --decompress --hex-dump=.data 
/build/alloc_system-d16b8f0e.0.o 

Section '.data' has no data to dump.
(sid-amd64)root@aeglos:/# echo $?
0

which in turn is down to 

   
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=32ec889602502348b704cfb16e65c83dc3eec095

On thinking about this, I think this is arguably a binutils bug so I've filed

   https://sourceware.org/bugzilla/show_bug.cgi?id=21820

too. But I thought you might want to know :) I can't see any very easy way of
working around this in diffoscope but I'm new to the codebase.

Cheers,
mwh


-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 
'xenial'), (400, 'xenial-proposed'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-83-generic (SMP w/4 CPU cores)
Locale: LANG=en_NZ.UTF-8, LC_CTYPE=en_NZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message ---
On Mon, Jul 24, 2017 at 12:59:47PM +1200, Michael Hudson-Doyle wrote:
> diffoscope 84 ftbfs in Ubuntu artful (and I think experimental but haven't
> checked this yet) with failures like this:

Thank you for your report!

> which in turn is down to 
> 
>    
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=32ec889602502348b704cfb16e65c83dc3eec095
> 
> On thinking about this, I think this is arguably a binutils bug so I've filed
> 
>    https://sourceware.org/bugzilla/show_bug.cgi?id=21820
> 
> too. But I thought you might want to know :) I can't see any very easy way of
> working around this in diffoscope but I'm new to the codebase.

binutils upstream went on and reverted to the previous behaviour of not
erroring out in the "dump an empty but present section" case, so
diffoscope tests passes with binutils 2.29 + the fixing commit (tested
with the new binutils upload to unstable and artful).
Therefore, I'm closing this bug.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


--- End Message ---

Reply via email to