Your message dated Sun, 30 Jul 2017 22:34:02 +0000
with message-id <[email protected]>
and subject line Bug#835625: fixed in nikwi 0.0.20120213-4
has caused the Debian Bug report #835625,
regarding nikwi: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
835625: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=835625
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: nikwi
Version: 0.0.20120213-3
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: ordering
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0], I noticed
that nikwi could not be built reproducibly.
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible_build.patch 1970-01-01 01:00:00.000000000
+0100
--- b/debian/patches/reproducible_build.patch 2016-08-27 18:51:19.004085540
+0100
@@ -0,0 +1,49 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2016-08-27
+
+--- nikwi-0.0.20120213.orig/src/tools/upack/upack.c
++++ nikwi-0.0.20120213/src/tools/upack/upack.c
+@@ -159,9 +159,9 @@ static void packFile(char *filename, cha
+
+ static void scanDirectory(char *dirname, char *path)
+ {
+- DIR *dir;
++ int n;
+ char *spath;
+- struct dirent *de;
++ struct dirent *de, **namelist;
+ if (chdir(dirname))
+ return;
+
+@@ -170,15 +170,15 @@ static void scanDirectory(char *dirname,
+ sprintf(spath, "%s/%s", path, dirname);
+ else
+ sprintf(spath, "%s", dirname);
+- dir = opendir(".");
+- if (!dir)
+- {
++ n = scandir(".", &namelist, 0, alphasort);
++ if (n < 0) {
+ chdir("..");
+ printf("cannot open `%s'\n", dirname);
+ return;
+ }
+- while ((de = readdir(dir)))
++ while (n--)
+ {
++ de = namelist[n];
+ if (!strcmp(de->d_name, ".") || !strcmp(de->d_name, ".."))
+ continue;
+ if (chdir(de->d_name))
+@@ -199,8 +199,9 @@ static void scanDirectory(char *dirname,
+ }
+ scanDirectory(de->d_name, spath);
+ }
++ free(de);
+ }
+- closedir(dir);
++ free(namelist);
+
+ free(spath);
+ chdir("..");
--- a/debian/patches/series 2016-08-27 18:41:21.055719434 +0100
--- b/debian/patches/series 2016-08-27 18:51:16.784055046 +0100
@@ -4,3 +4,4 @@
slashfx_main.patch
uscript_type.patch
big-endian.patch
+reproducible_build.patch
--- End Message ---
--- Begin Message ---
Source: nikwi
Source-Version: 0.0.20120213-4
We believe that the bug you reported is fixed in the latest version of
nikwi, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Markus Koschany <[email protected]> (supplier of updated nikwi package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 31 Jul 2017 00:05:21 +0200
Source: nikwi
Binary: nikwi nikwi-data
Architecture: source
Version: 0.0.20120213-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Markus Koschany <[email protected]>
Description:
nikwi - platform game where your goal is to collect candies
nikwi-data - platform game where your goal is to collect candies - game data
Closes: 835625
Changes:
nikwi (0.0.20120213-4) unstable; urgency=medium
.
* Team upload.
* Switch to compat level 10.
* Declare compliance with Debian Policy 4.0.0.
* Drop deprecated menu file and xpm icon. Upscale xpm icon to 64x64 pixel,
convert it to png and install it into the hicolor icon directory.
* Add reproducible_build.patch and make the build reproducible.
Thanks to Chris Lamb for the report and patch, (Closes: #835625)
* Fix spelling mistake in nikwi.6 manpage.
Checksums-Sha1:
5004a9673c7d1e5ebb947aa2e25cba728a27e8b7 2254 nikwi_0.0.20120213-4.dsc
4959bc9e988fbcb207379876b9a0b2d15daaf521 17828
nikwi_0.0.20120213-4.debian.tar.xz
7508cbfb52274462ca3b1262d23229f541838d5c 9352
nikwi_0.0.20120213-4_amd64.buildinfo
Checksums-Sha256:
ffd1de6aa7e0a10e2d2b3d0210682d643770dc4bead515427fb37a735abee20f 2254
nikwi_0.0.20120213-4.dsc
ffa46a675f8ec8c00de5de54131013fdc8a008226fe360b2f0045f8387d7902b 17828
nikwi_0.0.20120213-4.debian.tar.xz
1fa66c0439b75644f95d9d142cc382a6d2fa3d97ef9402a736ede40c6e23cc33 9352
nikwi_0.0.20120213-4_amd64.buildinfo
Files:
75adc18f135a5270d5382348053b99a4 2254 games optional nikwi_0.0.20120213-4.dsc
1fe5be64acbcc76b5990821040d816f3 17828 games optional
nikwi_0.0.20120213-4.debian.tar.xz
f2850dbfb31a3ae027fefa16d456afdd 9352 games optional
nikwi_0.0.20120213-4_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKjBAEBCgCNFiEErPPQiO8y7e9qGoNf2a0UuVE7UeQFAll+XGxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEFD
RjNEMDg4RUYzMkVERUY2QTFBODM1RkQ5QUQxNEI5NTEzQjUxRTQPHGFwb0BkZWJp
YW4ub3JnAAoJENmtFLlRO1HkM14QAINh78yJAk5MA5D1T0YI7QvigEvCFkhYJr7u
/R+MmG6qkIKnBwuwMjw4g3GQYp8Oy9nBOU6n8qhC69Iq5ruMu0xRWoBUOhSyLoKi
i3L3HQyb55sDq7An7S1kL86hf38woed2fsnFQJcX/vbzArJUdSvy7uuMHgnsllf1
cnTDssMEyafGqM6NUytQByet6NCahYGjbbhcA7iJeQZKZtgGsWIxZuofBfG05fhd
/0U893eMaBH1rYbXJv8n9BMS+vAimgAU19lfcXSere5yDqt8iGauMeWTFJT5ITkl
90VSqN1toydhFSUPaFgFya6Dnopd9QPZX92jt/Ksthg2Jst6TK/B7ZZRkQ/eVBmS
rSw8/X6s496W6OtfzjOEHT/pLbAfSD8hM+3qy5JdY08wfC9hYCf6wOrYvpnhnjMH
g/qGAlOWe9ifqrPf5RdNynKU5q36lfEd8RzM3srCNTYKcJiqtFzWcBlsAOcua4zx
DCIFgvY+J5cxoWv0jHpClMO74skmvgTq1oL4mFZPQnrNci8iKnrmADU6z5ZInqmv
eoNkubhVMwpn5uWCgP4GI2dswNVi9lPO6DkbGh9rFY/FFtMLVhxEINA0Dh2eHKr9
/PNG9n5J7yxa/E3AJrwp81mE+mK8GRm0rv4mhYtqmU52YAHILLdqcyv+GHjdxlSg
KE9EU9bH
=Dbra
-----END PGP SIGNATURE-----
--- End Message ---
