Your message dated Tue, 01 Aug 2017 14:55:44 +0000
with message-id <[email protected]>
and subject line Bug#870150: fixed in sks 1.1.6-6
has caused the Debian Bug report #870150,
regarding sks FTBFS with OCaml 4.05.0: missing ?cloexec argument to
UnixLabels.socket
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
870150: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870150
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:sks
Version: 1.1.6-5
Severity: important
Tags: patch
User: [email protected]
Usertags: ocaml-4.05.0-transition
Dear maintainer,
sks FTBFS with OCaml 4.05.0. Relevant log:
> [...]
> ocamlc -I lib -I bdb -I +zarith -I +cryptokit -ccopt -g -ccopt -O2 -ccopt
> -fdebug-prefix-map=/tmp/sks-1.1.6=. -ccopt -fstack-protector-strong -ccopt
> -Wformat -ccopt -Werror=format-security -ccopt -O3 -ccopt
> -Werror-implicit-funct
> File "eventloop.ml", line 133, characters 15-19:
> Error: This expression has type ?cloexec:bool -> Unix.file_descr
> but an expression was expected of type
> Unix.file_descr = Unix.file_descr
> ocamlc -I lib -I bdb -I +zarith -I +cryptokit -ccopt -g -ccopt -O2 -ccopt
> -fdebug-prefix-map=/tmp/sks-1.1.6=. -ccopt -fstack-protector-strong -ccopt
> -Wformat -ccopt -Werror=format-security -ccopt -O3 -ccopt
> -Werror-implicit-funct
> Makefile:357: recipe for target 'eventloop.cmo' failed
> make[2]: *** [eventloop.cmo] Error 2
> [...]
Attached is a patch. Unfortunately it is not compatible with the
version of OCaml currently in unstable, so you'll have to wait until
we upload ocaml >= 4.05.0.
Cheers,
--
Stéphane
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.11.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8),
LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Description: Fix FTBFS with OCaml 4.05.0
Author: Stephane Glondu <[email protected]>
Last-Update: 2017-07-30
--- sks-1.1.6.orig/eventloop.ml
+++ sks-1.1.6/eventloop.ml
@@ -129,7 +129,7 @@ let create_sock addr =
let domain =
Unix.domain_of_sockaddr addr in
let sock =
- socket ~domain ~kind:SOCK_STREAM ~protocol:0 in
+ socket ~domain ~kind:SOCK_STREAM ~protocol:0 ?cloexec:None in
setsockopt sock SO_REUSEADDR true;
if domain = PF_INET6 then
setsockopt sock IPV6_ONLY true;
--- sks-1.1.6.orig/reconComm.ml
+++ sks-1.1.6/reconComm.ml
@@ -40,7 +40,7 @@ let send_dbmsg msg =
let s = Unix.socket
~domain:(Unix.domain_of_sockaddr db_command_addr)
~kind:Unix.SOCK_STREAM
- ~protocol:0 in
+ ~protocol:0 ?cloexec:None in
protect ~f:(fun () ->
Unix.connect s ~addr:db_command_addr;
let cin = Channel.sys_in_from_fd s in
@@ -57,7 +57,7 @@ let send_dbmsg_noreply msg =
let s = Unix.socket
~domain:(Unix.domain_of_sockaddr db_command_addr)
~kind:Unix.SOCK_STREAM
- ~protocol:0 in
+ ~protocol:0 ?cloexec:None in
protect ~f:(fun () ->
Unix.connect s ~addr:db_command_addr;
let cout = Channel.sys_out_from_fd s in
@@ -78,7 +78,7 @@ let get_keystrings_via_http addr hashes
let s = Unix.socket
~domain:(Unix.domain_of_sockaddr addr)
~kind:Unix.SOCK_STREAM
- ~protocol:0 in
+ ~protocol:0 ?cloexec:None in
protect ~f:(fun () ->
Unix.bind s ~addr:(match_client_recon_addr addr);
Unix.connect s ~addr;
--- sks-1.1.6.orig/sks_do.ml
+++ sks-1.1.6/sks_do.ml
@@ -40,7 +40,7 @@ let send_dbmsg msg =
let s = Unix.socket
~domain:(Unix.domain_of_sockaddr db_command_addr)
~kind:Unix.SOCK_STREAM
- ~protocol:0 in
+ ~protocol:0 ?cloexec:None in
protect ~f:(fun () ->
Unix.connect s ~addr:db_command_addr;
let cin = Channel.sys_in_from_fd s in
--- sks-1.1.6.orig/tester.ml
+++ sks-1.1.6/tester.ml
@@ -49,7 +49,7 @@ let send_msg addr msg =
let s = Unix.socket
~domain:(Unix.domain_of_sockaddr addr)
~kind:Unix.SOCK_STREAM
- ~protocol:0 in
+ ~protocol:0 ?cloexec:None in
protect ~f:( fun () ->
Unix.connect s ~addr:addr;
let cin = Channel.sys_in_from_fd s
@@ -65,7 +65,7 @@ let send_msg_noreply addr msg =
let s = Unix.socket
~domain:(Unix.domain_of_sockaddr addr)
~kind:Unix.SOCK_STREAM
- ~protocol:0 in
+ ~protocol:0 ?cloexec:None in
protect ~f:(fun () ->
Unix.connect s ~addr:addr;
let cout = Channel.sys_out_from_fd s in
--- End Message ---
--- Begin Message ---
Source: sks
Source-Version: 1.1.6-6
We believe that the bug you reported is fixed in the latest version of
sks, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Kahn Gillmor <[email protected]> (supplier of updated sks package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 01 Aug 2017 10:20:24 -0400
Source: sks
Binary: sks
Architecture: source
Version: 1.1.6-6
Distribution: unstable
Urgency: medium
Maintainer: Christoph Martin <[email protected]>
Changed-By: Daniel Kahn Gillmor <[email protected]>
Description:
sks - Synchronizing OpenPGP Key Server
Closes: 870150
Changes:
sks (1.1.6-6) unstable; urgency=medium
.
[ Stéphane Glondu ]
* Fix FTBFS with OCaml 4.05.0 (Closes: #870150)
.
[ Daniel Kahn Gillmor ]
* bump Standards-Version to 4.0.0 (no changes needed)
* wrap-and-sort -ast
* implement basic autopkgtest
Checksums-Sha1:
be7dadf097ce6a16e098a9a7a4d54bf1b94f5b3f 2138 sks_1.1.6-6.dsc
6c6280547a99259146dfa06c5a03f8634e0ccfa1 27724 sks_1.1.6-6.debian.tar.xz
0c73d28f348a8d76838cb8735c76ae362b3521ad 7054 sks_1.1.6-6_amd64.buildinfo
Checksums-Sha256:
6029d292527ed844df135517906dfc9236d1c2f6d86d24e96e1b93d014592404 2138
sks_1.1.6-6.dsc
c9c232d4264e675ad7b4cc324bf20f6fe2f86b246f095fd784b03019b0c2eafc 27724
sks_1.1.6-6.debian.tar.xz
d2f305cfd6073e4895edb32eb0094a5abeb4ece03627b6554b28c249e7f5b78f 7054
sks_1.1.6-6_amd64.buildinfo
Files:
2fdfee1dabe618f14a04b81021c1818c 2138 net optional sks_1.1.6-6.dsc
9374b0d8812115f7a8a07f2573223c2a 27724 net optional sks_1.1.6-6.debian.tar.xz
fcdf5fc1fafe479a8cc4b72d51ba34b8 7054 net optional sks_1.1.6-6_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEOCdgUepHf6PklTkyFJitxsGSMjcFAlmAjmsACgkQFJitxsGS
MjclJQ/+JSgA9eR1pP3ddPlc5pzmdVjXuS4Qi4HDKEELttILZPm1N/mGGFMxOtSa
mwV0ckpCsPaIKf3QM2yf6z/S9Po9rsuqCUiI+oZYW9duioP4daA6OkMNUzt9Jn9y
dlbYk4kyfL0g9iRuBrbXGPLmCwUjvUkAwJ/bU2HAcr9llhEF30kKAT9XkDLNcD3C
Cmhgjo6jZKUf9UWaBa5Ess3OfJtF67qfkNXjaQxYOSDn3P6x9LTn1ABVcz4wM+w3
4AvDmzx2NP3cIaGIEETJTsWw0WzGkHd4CGO87vmOXOJXKscz+969wHywCrXYzhdN
+t6KztB7pJBfou9nFNLoKTAe0BzRJmAywncU8GkuZWFpMncAoFtlpDQvuXUozRUr
etLtOuvGwhvrblZ3zUSE22+52siU+oaPI3RCDw1hTVU1YTPMb6uDfK0rbE7D0wSP
9JTbLu33EOYPRgcJG16GzHUfvfmMtyETWpYQwYxeTxHcOxUjkNAROrrON39mVAhV
FRVAMA7Ce+Jg3Rbyw7Qz4n3pncIS4i4ZmSviu85YgkfXLa5fq9vFAbrXQq5kb/BW
clYvyVynkJj6lJ5CCV60NoO3Cf0IfBNGO2s0PFp7DmmXdehmmBfvRnFFT8bv6VnE
r5Wtve6V5G3G/22luDVOs+VvhoVHKPpf4mjBf3RTt13mfpD6NCg=
=mBlL
-----END PGP SIGNATURE-----
--- End Message ---
